test_assistant_service.py 87 KB

1234567891011121314151617181920212223242526272829303132333435363738394041424344454647484950515253545556575859606162636465666768697071727374757677787980818283848586878889909192939495969798991001011021031041051061071081091101111121131141151161171181191201211221231241251261271281291301311321331341351361371381391401411421431441451461471481491501511521531541551561571581591601611621631641651661671681691701711721731741751761771781791801811821831841851861871881891901911921931941951961971981992002012022032042052062072082092102112122132142152162172182192202212222232242252262272282292302312322332342352362372382392402412422432442452462472482492502512522532542552562572582592602612622632642652662672682692702712722732742752762772782792802812822832842852862872882892902912922932942952962972982993003013023033043053063073083093103113123133143153163173183193203213223233243253263273283293303313323333343353363373383393403413423433443453463473483493503513523533543553563573583593603613623633643653663673683693703713723733743753763773783793803813823833843853863873883893903913923933943953963973983994004014024034044054064074084094104114124134144154164174184194204214224234244254264274284294304314324334344354364374384394404414424434444454464474484494504514524534544554564574584594604614624634644654664674684694704714724734744754764774784794804814824834844854864874884894904914924934944954964974984995005015025035045055065075085095105115125135145155165175185195205215225235245255265275285295305315325335345355365375385395405415425435445455465475485495505515525535545555565575585595605615625635645655665675685695705715725735745755765775785795805815825835845855865875885895905915925935945955965975985996006016026036046056066076086096106116126136146156166176186196206216226236246256266276286296306316326336346356366376386396406416426436446456466476486496506516526536546556566576586596606616626636646656666676686696706716726736746756766776786796806816826836846856866876886896906916926936946956966976986997007017027037047057067077087097107117127137147157167177187197207217227237247257267277287297307317327337347357367377387397407417427437447457467477487497507517527537547557567577587597607617627637647657667677687697707717727737747757767777787797807817827837847857867877887897907917927937947957967977987998008018028038048058068078088098108118128138148158168178188198208218228238248258268278288298308318328338348358368378388398408418428438448458468478488498508518528538548558568578588598608618628638648658668678688698708718728738748758768778788798808818828838848858868878888898908918928938948958968978988999009019029039049059069079089099109119129139149159169179189199209219229239249259269279289299309319329339349359369379389399409419429439449459469479489499509519529539549559569579589599609619629639649659669679689699709719729739749759769779789799809819829839849859869879889899909919929939949959969979989991000100110021003100410051006100710081009101010111012101310141015101610171018101910201021102210231024102510261027102810291030103110321033103410351036103710381039104010411042104310441045104610471048104910501051105210531054105510561057105810591060106110621063106410651066106710681069107010711072107310741075107610771078107910801081108210831084108510861087108810891090109110921093109410951096109710981099110011011102110311041105110611071108110911101111111211131114111511161117111811191120112111221123112411251126112711281129113011311132113311341135113611371138113911401141114211431144114511461147114811491150115111521153115411551156115711581159116011611162116311641165116611671168116911701171117211731174117511761177117811791180118111821183118411851186118711881189119011911192119311941195119611971198119912001201120212031204120512061207120812091210121112121213121412151216121712181219122012211222122312241225122612271228122912301231123212331234123512361237123812391240124112421243124412451246124712481249125012511252125312541255125612571258125912601261126212631264126512661267126812691270127112721273127412751276127712781279128012811282128312841285128612871288128912901291129212931294129512961297129812991300130113021303130413051306130713081309131013111312131313141315131613171318131913201321132213231324132513261327132813291330133113321333133413351336133713381339134013411342134313441345134613471348134913501351135213531354135513561357135813591360136113621363136413651366136713681369137013711372137313741375137613771378137913801381138213831384138513861387138813891390139113921393139413951396139713981399140014011402140314041405140614071408140914101411141214131414141514161417141814191420142114221423142414251426142714281429143014311432143314341435143614371438143914401441144214431444144514461447144814491450145114521453145414551456145714581459146014611462146314641465146614671468146914701471147214731474147514761477147814791480148114821483148414851486148714881489149014911492149314941495149614971498149915001501150215031504150515061507150815091510151115121513151415151516151715181519152015211522152315241525152615271528152915301531153215331534153515361537153815391540154115421543154415451546154715481549155015511552155315541555155615571558155915601561156215631564156515661567156815691570157115721573157415751576157715781579158015811582158315841585158615871588158915901591159215931594159515961597159815991600160116021603160416051606160716081609161016111612161316141615161616171618161916201621162216231624162516261627162816291630163116321633163416351636163716381639164016411642164316441645164616471648164916501651165216531654165516561657165816591660166116621663166416651666166716681669167016711672167316741675167616771678167916801681168216831684168516861687168816891690169116921693169416951696169716981699170017011702170317041705170617071708170917101711171217131714171517161717171817191720172117221723172417251726172717281729173017311732173317341735173617371738173917401741174217431744174517461747174817491750175117521753175417551756175717581759176017611762176317641765176617671768176917701771177217731774177517761777177817791780178117821783178417851786178717881789179017911792179317941795179617971798179918001801180218031804180518061807180818091810181118121813181418151816181718181819182018211822182318241825182618271828182918301831183218331834183518361837183818391840184118421843184418451846184718481849185018511852185318541855185618571858185918601861186218631864186518661867186818691870187118721873187418751876187718781879188018811882188318841885188618871888188918901891189218931894189518961897189818991900190119021903190419051906190719081909191019111912191319141915191619171918191919201921192219231924192519261927192819291930193119321933193419351936193719381939194019411942194319441945194619471948194919501951195219531954195519561957195819591960196119621963196419651966196719681969197019711972197319741975197619771978197919801981198219831984198519861987198819891990199119921993199419951996199719981999200020012002200320042005200620072008200920102011201220132014201520162017201820192020202120222023202420252026202720282029203020312032203320342035203620372038203920402041204220432044204520462047204820492050205120522053205420552056205720582059206020612062206320642065206620672068206920702071207220732074207520762077207820792080208120822083208420852086208720882089209020912092209320942095209620972098209921002101210221032104210521062107210821092110211121122113211421152116211721182119212021212122212321242125212621272128212921302131213221332134213521362137213821392140214121422143214421452146214721482149215021512152215321542155215621572158215921602161216221632164216521662167216821692170217121722173217421752176217721782179218021812182218321842185218621872188218921902191219221932194219521962197219821992200220122022203220422052206220722082209221022112212221322142215221622172218221922202221222222232224222522262227222822292230223122322233223422352236223722382239224022412242224322442245224622472248224922502251225222532254225522562257225822592260226122622263226422652266226722682269227022712272227322742275227622772278227922802281228222832284228522862287228822892290229122922293229422952296229722982299230023012302230323042305230623072308230923102311231223132314231523162317231823192320232123222323232423252326232723282329233023312332233323342335233623372338233923402341234223432344234523462347234823492350235123522353235423552356235723582359236023612362236323642365236623672368236923702371237223732374237523762377237823792380238123822383238423852386238723882389239023912392239323942395239623972398239924002401240224032404240524062407240824092410241124122413241424152416241724182419242024212422242324242425242624272428242924302431243224332434243524362437243824392440244124422443244424452446244724482449245024512452245324542455245624572458245924602461246224632464246524662467246824692470247124722473247424752476247724782479248024812482248324842485248624872488248924902491249224932494249524962497249824992500250125022503250425052506250725082509251025112512251325142515251625172518251925202521252225232524252525262527252825292530253125322533253425352536253725382539254025412542254325442545254625472548254925502551255225532554255525562557255825592560256125622563256425652566256725682569257025712572257325742575257625772578257925802581258225832584258525862587258825892590259125922593259425952596259725982599260026012602
  1. """Tests for the assistant service (Phase 2) using synthetic event streams."""
  2. import itertools
  3. import json
  4. import re
  5. import threading
  6. import time
  7. from typing import Any
  8. from stt_daemon import events
  9. from stt_daemon.assistant.inference import InferenceJob, InferenceQueue
  10. from stt_daemon.assistant.service import EXECUTE_BUSY, AssistantService
  11. from stt_daemon.assistant.triage_dump import TriageDumper
  12. from stt_daemon.config import Config
  13. _sequence = itertools.count(1)
  14. class Clock:
  15. def __init__(self, start=1000.0):
  16. self.t = float(start)
  17. def __call__(self):
  18. return self.t
  19. def advance(self, dt):
  20. self.t += float(dt)
  21. class FakeSubscriber:
  22. def events(self):
  23. return iter(())
  24. def close(self):
  25. pass
  26. def _service():
  27. cfg = Config()
  28. clock = Clock()
  29. emitted: list[dict] = []
  30. def emit(type_, **fields):
  31. emitted.append({"type": type_, **fields})
  32. service = AssistantService(cfg, FakeSubscriber(), emit=emit, time_fn=clock)
  33. return service, emitted, clock
  34. def _ev(type_, clock, **fields):
  35. event = {"v": 1, "type": type_, "seq": next(_sequence), "ts": clock()}
  36. event.update(fields)
  37. return event
  38. def _transcript(clock, text, ts=None, session_dir=None):
  39. event = {
  40. "v": 1,
  41. "type": events.TRANSCRIPT,
  42. "seq": next(_sequence),
  43. "ts": clock() if ts is None else ts,
  44. "text": text,
  45. }
  46. if session_dir is not None:
  47. event["session_dir"] = session_dir
  48. return event
  49. def test_ready_requires_matching_segment_done():
  50. service, _, clock = _service()
  51. service.handle_event(_ev(events.SPEECH_START, clock))
  52. assert service.ready() is False
  53. service.handle_event(_ev(events.SPEECH_STOP, clock, seg_id=1))
  54. assert service.ready() is False # awaiting segment 1
  55. service.handle_event(_ev(events.SEGMENT_DONE, clock, seg_id=1, emitted=True))
  56. assert service.ready() is True
  57. def test_stale_segment_done_does_not_satisfy_later_turn():
  58. service, _, clock = _service()
  59. service.handle_event(_ev(events.SPEECH_STOP, clock, seg_id=1))
  60. service.handle_event(_ev(events.SPEECH_START, clock))
  61. service.handle_event(_ev(events.SPEECH_STOP, clock, seg_id=2))
  62. service.handle_event(_ev(events.SEGMENT_DONE, clock, seg_id=1, emitted=True))
  63. assert service.ready() is False # still awaiting segment 2
  64. service.handle_event(_ev(events.SEGMENT_DONE, clock, seg_id=2, emitted=True))
  65. assert service.ready() is True
  66. def test_gated_segment_done_clears_readiness():
  67. service, _, clock = _service()
  68. service.handle_event(_ev(events.SPEECH_STOP, clock, seg_id=3))
  69. service.handle_event(_ev(events.SEGMENT_DONE, clock, seg_id=3, emitted=False))
  70. assert service.ready() is True
  71. def test_speech_stop_without_seg_id_clears_readiness():
  72. """A discarded turn closes with speech_stop but no seg_id; readiness must recover."""
  73. service, _, clock = _service()
  74. service.handle_event(_ev(events.SPEECH_START, clock))
  75. assert service.ready() is False
  76. service.handle_event(_ev(events.SPEECH_STOP, clock)) # discarded: no seg_id
  77. assert service.speech_open is False
  78. assert service.awaited_seg_id is None
  79. assert service.ready() is True
  80. def test_status_resets_stale_speech_state_on_reconnect():
  81. service, _, clock = _service()
  82. service.handle_event(_ev(events.SPEECH_START, clock))
  83. assert service.speech_open is True
  84. service.handle_event(_ev(events.STATUS, clock, capture="x", segments_done=0))
  85. assert service.speech_open is False
  86. assert service.awaited_seg_id is None
  87. assert service.ready() is True
  88. def test_command_buffer_uses_arm_timestamp():
  89. service, _, clock = _service()
  90. clock.advance(10)
  91. assert service.arm() is True
  92. arm_ts = service.arm_ts
  93. assert arm_ts is not None
  94. # Replayed transcript from before arming is ignored.
  95. service.handle_event(_transcript(clock, "old", ts=arm_ts - 5))
  96. assert service.command_text == ""
  97. service.handle_event(_transcript(clock, "what time is it"))
  98. assert service.command_text == "what time is it"
  99. def test_mutual_exclusion_between_command_and_chat():
  100. service, _, _ = _service()
  101. assert service.toggle_chat() is True
  102. assert service.arm() is False # cannot arm in chat
  103. assert service.toggle_chat() is True # back to idle
  104. assert service.arm() is True
  105. assert service.toggle_chat() is False # cannot chat while armed
  106. def test_arm_timeout_disarms_and_emits_error():
  107. service, emitted, clock = _service()
  108. service.arm()
  109. clock.advance(service.cfg.assistant.command_arm_timeout_s + 0.1)
  110. service.tick()
  111. assert service.modes.mode.value == "idle"
  112. assert service.command_text == ""
  113. assert any(e["type"] == "error" and e["code"] == "arm_timeout" for e in emitted)
  114. def test_long_speech_does_not_disarm():
  115. service, emitted, clock = _service()
  116. service.arm()
  117. service.handle_event(_ev(events.SPEECH_START, clock))
  118. clock.advance(service.cfg.assistant.command_arm_timeout_s + 30.0)
  119. service.tick()
  120. assert service.modes.mode.value == "command_armed"
  121. assert not any(e["type"] == "error" for e in emitted)
  122. def test_captured_command_survives_arm_timeout():
  123. service, emitted, clock = _service()
  124. service.arm()
  125. service.handle_event(_transcript(clock, "what time is it"))
  126. service.handle_event(_ev(events.SPEECH_STOP, clock, seg_id=1))
  127. service.handle_event(_ev(events.SEGMENT_DONE, clock, seg_id=1, emitted=True))
  128. clock.advance(service.cfg.assistant.command_arm_timeout_s + 30.0)
  129. service.tick()
  130. assert service.modes.mode.value == "command_armed"
  131. assert service.command_text == "what time is it"
  132. assert not any(e["type"] == "error" for e in emitted)
  133. def test_stt_stall_cancels_armed_command():
  134. service, emitted, clock = _service()
  135. service.handle_event(_ev(events.HEARTBEAT, clock, worker_stall_s=0.0))
  136. service.arm()
  137. clock.advance(service.cfg.assistant.stall_timeout_ms / 1000.0 + 0.5)
  138. service.tick()
  139. assert service.modes.mode.value == "idle"
  140. assert any(e["type"] == "error" and e["code"] == "stt_stall" for e in emitted)
  141. def test_worker_stall_marks_stt_degraded():
  142. service, _, clock = _service()
  143. long_stall = service.cfg.assistant.worker_stall_ms / 1000.0 + 1.0
  144. service.handle_event(_ev(events.HEARTBEAT, clock, worker_stall_s=long_stall))
  145. assert service.stt_ok() is False
  146. assert service.ready() is False
  147. def test_chat_idle_timeout_exits_chat():
  148. service, _, clock = _service()
  149. assert service.toggle_chat() is True
  150. clock.advance(service.cfg.assistant.chat_idle_timeout_s + 0.1)
  151. service.tick()
  152. assert service.modes.mode.value == "idle"
  153. def test_chat_exit_phrase_exits_chat():
  154. service, _, clock = _service()
  155. assert service.toggle_chat() is True
  156. service.handle_event(_transcript(clock, "That's all."))
  157. assert service.modes.mode.value == "idle"
  158. assert service.chat_history == []
  159. def test_viewer_detached_exits_chat_and_forgets_history():
  160. service, _, clock = _service()
  161. assert service.toggle_chat() is True
  162. service.handle_event(_transcript(clock, "hello"))
  163. assert service.viewer_detached() is True
  164. assert service.modes.mode.value == "idle"
  165. assert service.chat_history == []
  166. def test_viewer_detached_is_noop_outside_chat():
  167. service, _, _ = _service()
  168. assert service.viewer_detached() is False
  169. assert service.modes.mode.value == "idle"
  170. def test_exit_chat_invokes_chat_reset():
  171. cfg = Config()
  172. resets: list[int] = []
  173. service = AssistantService(
  174. cfg, FakeSubscriber(), time_fn=Clock(), chat_reset=lambda: resets.append(1)
  175. )
  176. service.toggle_chat()
  177. service.viewer_detached()
  178. assert resets == [1]
  179. def test_chat_accumulates_turns():
  180. service, _, clock = _service()
  181. service.toggle_chat()
  182. for text in ("hello there", "how are you"):
  183. service.handle_event(_transcript(clock, text))
  184. assert service.chat_history == ["Unknown: hello there", "Unknown: how are you"]
  185. def test_execute_requires_readiness():
  186. service, _, clock = _service()
  187. service.arm()
  188. service.handle_event(_transcript(clock, "do it"))
  189. service.handle_event(_ev(events.SPEECH_START, clock))
  190. assert service.execute() is None # speech still open
  191. assert service.modes.mode.value == "command_armed"
  192. service.handle_event(_ev(events.SPEECH_STOP, clock, seg_id=1))
  193. assert service.execute() is None # awaiting segment 1
  194. service.handle_event(_ev(events.SEGMENT_DONE, clock, seg_id=1, emitted=True))
  195. assert service.execute() == "do it"
  196. assert service.modes.mode.value == "executing"
  197. assert service.finish() is True
  198. assert service.modes.mode.value == "idle"
  199. def test_execute_reports_busy_when_queue_rejects():
  200. service, emitted, clock = _service()
  201. # A zero-capacity lane rejects the priority command job on submit.
  202. service._inference = InferenceQueue(size=0)
  203. service.executor = object()
  204. service.arm()
  205. service.handle_event(_transcript(clock, "do it"))
  206. service.handle_event(_ev(events.SPEECH_STOP, clock, seg_id=1))
  207. service.handle_event(_ev(events.SEGMENT_DONE, clock, seg_id=1, emitted=True))
  208. assert service.execute() is EXECUTE_BUSY
  209. assert service.modes.mode.value == "idle"
  210. assert not any(e.get("code") == "busy" for e in emitted)
  211. def test_turn_ended_requires_quiet_gap():
  212. service, _, clock = _service()
  213. service.handle_event(_ev(events.SPEECH_STOP, clock, seg_id=1))
  214. service.handle_event(_ev(events.SEGMENT_DONE, clock, seg_id=1, emitted=True))
  215. assert service.ready() is True
  216. assert service.turn_ended() is False
  217. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  218. assert service.turn_ended() is True
  219. def test_emits_mode_and_command_text():
  220. service, emitted, clock = _service()
  221. service.arm()
  222. assert {"type": "mode", "mode": "command_armed"} in emitted
  223. service.handle_event(_transcript(clock, "hi"))
  224. assert any(e["type"] == "command_text" and e["text"] == "hi" for e in emitted)
  225. def test_cancel_clears_command_buffer():
  226. service, _, clock = _service()
  227. service.arm()
  228. service.handle_event(_transcript(clock, "hi"))
  229. assert service.cancel() is True
  230. assert service.modes.mode.value == "idle"
  231. assert service.command_text == ""
  232. assert service.arm_ts is None
  233. def test_pending_chat_is_not_lost_across_threads():
  234. """Transcripts appended on the reader thread while the ticker dispatches
  235. must all reach the model: the join-and-clear in _dispatch_chat is atomic,
  236. and the user bubble is emitted by the worker in _run_chat."""
  237. cfg = Config()
  238. cfg.assistant.turn_gap_s = 0.01
  239. dispatched: list[str] = []
  240. lock = threading.Lock()
  241. def emit(type_, **fields):
  242. if type_ == "chat_message" and fields.get("role") == "user":
  243. with lock:
  244. dispatched.append(fields["text"])
  245. service = AssistantService(cfg, FakeSubscriber(), emit=emit, chat_fn=lambda text: "ok")
  246. service.toggle_chat()
  247. service.start()
  248. try:
  249. total = 200
  250. producer = threading.Thread(
  251. target=lambda: [
  252. service.handle_event(
  253. {
  254. "v": 1,
  255. "type": events.TRANSCRIPT,
  256. "seq": i,
  257. "ts": time.time(),
  258. "text": f"w{i}",
  259. }
  260. )
  261. for i in range(total)
  262. ],
  263. daemon=True,
  264. )
  265. producer.start()
  266. deadline = time.time() + 10.0
  267. while time.time() < deadline:
  268. service.tick()
  269. with lock:
  270. words = sum(len(text.split()) for text in dispatched)
  271. done = words == 2 * total
  272. if not producer.is_alive() and done:
  273. break
  274. time.sleep(0.002)
  275. producer.join(timeout=5)
  276. with lock:
  277. words = sum(len(text.split()) for text in dispatched)
  278. assert words == 2 * total
  279. finally:
  280. service.stop()
  281. def _full_queue_service():
  282. service, emitted, clock = _service()
  283. service.toggle_chat()
  284. service._inference = InferenceQueue(size=1)
  285. service._inference.submit(
  286. InferenceJob(name="blocker", run=lambda: None, evictable=False)
  287. )
  288. return service, emitted, clock
  289. def test_chat_refusal_rebuffers_and_emits_queue_full_once():
  290. """A refused chat submit re-buffers under lock and emits queue_full on flip."""
  291. service, emitted, _ = _full_queue_service()
  292. service._pending_chat = ["hello world"]
  293. service._dispatch_chat()
  294. assert service._pending_chat == ["hello world"]
  295. assert service._chat_queue_full is True
  296. errors = [e for e in emitted if e["type"] == "error" and e.get("code") == "queue_full"]
  297. assert len(errors) == 1
  298. assert [e for e in emitted if e["type"] == "chat_message"] == []
  299. service._dispatch_chat()
  300. assert service._pending_chat == ["hello world"]
  301. errors = [e for e in emitted if e["type"] == "error" and e.get("code") == "queue_full"]
  302. assert len(errors) == 1
  303. def test_chat_dispatch_success_clears_latch_without_user_bubble():
  304. """Success clears the latch; the user bubble comes from _run_chat, not dispatch."""
  305. service, emitted, _ = _full_queue_service()
  306. service._pending_chat = ["hello world"]
  307. service._chat_queue_full = True
  308. service._inference.drop(lambda j: True)
  309. service._dispatch_chat()
  310. assert service._pending_chat == []
  311. assert service._chat_queue_full is False
  312. assert [e for e in emitted if e["type"] == "chat_message"] == []
  313. def test_run_chat_emits_user_first_then_reply():
  314. service, emitted, _ = _service()
  315. service.chat_fn = lambda text: "reply!"
  316. service._run_chat("hello")
  317. assert emitted == [
  318. {"type": "chat_message", "role": "user", "text": "hello"},
  319. {"type": "chat_message", "role": "assistant", "text": "reply!"},
  320. ]
  321. def test_chat_notify_emits_compaction_note():
  322. service, emitted, _ = _service()
  323. service.chat_notify("compacted", turns=4)
  324. assert {
  325. "type": "chat_message",
  326. "role": "note",
  327. "text": "Compacted 4 earlier turns into a summary.",
  328. } in emitted
  329. def test_chat_notify_emits_truncated_error():
  330. service, emitted, _ = _service()
  331. service.chat_notify("truncated", message="cut off")
  332. assert {"type": "error", "code": "truncated", "message": "cut off"} in emitted
  333. def test_clear_empties_chat_history():
  334. service, emitted, clock = _service()
  335. service.toggle_chat()
  336. for text in ("hello", "how are you"):
  337. service.handle_event(_transcript(clock, text))
  338. assert service.chat_history == ["Unknown: hello", "Unknown: how are you"]
  339. assert len(service._pending_chat) == 2
  340. assert service.clear() is True
  341. assert service.chat_history == []
  342. assert service._pending_chat == []
  343. assert {"type": "cleared"} in emitted
  344. def test_clear_invokes_chat_reset():
  345. cfg = Config()
  346. resets: list[int] = []
  347. service = AssistantService(
  348. cfg, FakeSubscriber(), time_fn=Clock(), chat_reset=lambda: resets.append(1)
  349. )
  350. service.toggle_chat()
  351. service.clear()
  352. assert resets == [1]
  353. def test_clear_does_not_change_mode():
  354. service, _, clock = _service()
  355. service.toggle_chat()
  356. assert service.modes.mode.value == "chat"
  357. service.clear()
  358. assert service.modes.mode.value == "chat"
  359. def test_clear_always_returns_true():
  360. service, _, _ = _service()
  361. assert service.clear() is True
  362. service.toggle_chat()
  363. service.handle_event(_ev(events.TRANSCRIPT, Clock(), text="test"))
  364. assert service.clear() is True
  365. def test_heartbeat_emits_inference_depth_and_in_flight():
  366. """Calling tick() emits heartbeat with inference_depth (int) and inference_in_flight (bool)."""
  367. service, emitted, clock = _service()
  368. service.tick()
  369. heartbeats = [e for e in emitted if e["type"] == "heartbeat"]
  370. assert len(heartbeats) == 1
  371. heartbeat = heartbeats[0]
  372. assert "inference_depth" in heartbeat
  373. assert isinstance(heartbeat["inference_depth"], int)
  374. assert "inference_in_flight" in heartbeat
  375. assert isinstance(heartbeat["inference_in_flight"], bool)
  376. def test_status_contains_inference_depth_and_in_flight():
  377. """status() snapshot contains inference_depth (int) and inference_in_flight (bool)."""
  378. service, _, _ = _service()
  379. status = service.status()
  380. assert "inference_depth" in status
  381. assert isinstance(status["inference_depth"], int)
  382. assert "inference_in_flight" in status
  383. assert isinstance(status["inference_in_flight"], bool)
  384. _AUTO = object()
  385. class FakeTriage:
  386. def __init__(
  387. self,
  388. questions=_AUTO,
  389. state_pair=("ok", ""),
  390. escalate=False,
  391. parsed=_AUTO,
  392. normalized=_AUTO,
  393. gate=True,
  394. ):
  395. if questions is _AUTO:
  396. questions = {"urgency": {"type": "noul", "instructions": "how urgent"}}
  397. self._questions = questions
  398. self._state_pair = state_pair
  399. self._escalate = escalate
  400. self._parsed = parsed
  401. self._normalized = normalized
  402. self._gate = gate
  403. self.build_state_calls: list[tuple] = []
  404. self.normalize_calls: list = []
  405. self.prompt_calls: list[tuple] = []
  406. self.gate_calls: list = []
  407. @property
  408. def questions(self):
  409. return self._questions
  410. def state(self):
  411. return self._state_pair
  412. def build_state(self, window):
  413. self.build_state_calls.append(tuple(window))
  414. return "\n".join("- " + str(item) for item in (window or []))
  415. def normalize(self, payload):
  416. self.normalize_calls.append(payload)
  417. if self._normalized is not _AUTO:
  418. return self._normalized
  419. if not isinstance(payload, dict):
  420. return {}
  421. signals = {"order": [], "items": {}, "escalated": False, "input_tokens": 0}
  422. signals.update(payload)
  423. if self._escalate:
  424. signals["escalated"] = True
  425. return signals
  426. def build_brief_prompt(self, deltas, signals):
  427. self.prompt_calls.append(
  428. (tuple(deltas), dict(signals) if isinstance(signals, dict) else signals)
  429. )
  430. return "BRIEF-PROMPT"
  431. def parse_brief(self, text):
  432. if self._parsed is _AUTO:
  433. return text if text else None
  434. return self._parsed
  435. def should_update_brief(self, signals):
  436. self.gate_calls.append(signals)
  437. return self._gate
  438. class FakeBriefFile:
  439. """Recording stand-in for BriefFile (write/clear/set_directory never raise)."""
  440. def __init__(self):
  441. self.writes: list[str] = []
  442. self.clears = 0
  443. self.directories: list[str] = []
  444. def set_directory(self, directory):
  445. self.directories.append(directory)
  446. def write(self, text):
  447. self.writes.append(text)
  448. def clear(self):
  449. self.clears += 1
  450. class FakeLane:
  451. def __init__(self, ready=True):
  452. self._ready = ready
  453. self.submits: list[tuple] = []
  454. self.drops = 0
  455. self.predict_gate = threading.Event()
  456. def ready(self):
  457. return self._ready
  458. def state(self):
  459. return ("ok", "") if self._ready else ("loading", "")
  460. def submit(self, state, questions, lang, generation):
  461. self.submits.append((state, questions, lang, generation))
  462. return True
  463. def drop_pending(self):
  464. self.drops += 1
  465. class FakeDebugSink:
  466. def __init__(self):
  467. self.events: list[tuple] = []
  468. def emit(self, type_, **fields):
  469. self.events.append((type_, fields))
  470. def _ok_reply(text):
  471. return "ok"
  472. def _triage_service(
  473. triage=None,
  474. lane=None,
  475. brief_fn=None,
  476. chat_fn: Any = _AUTO,
  477. brief_file=None,
  478. brief_reset=None,
  479. chat_reset=None,
  480. debug_sink=None,
  481. ):
  482. cfg = Config()
  483. cfg.assistant.turn_gap_s = 0.5
  484. clock = Clock()
  485. emitted: list[dict] = []
  486. def emit(type_, **fields):
  487. emitted.append({"type": type_, **fields})
  488. if triage is None:
  489. triage = FakeTriage()
  490. if lane is None:
  491. lane = FakeLane()
  492. if chat_fn is _AUTO:
  493. chat_fn = _ok_reply
  494. factory = (lambda: debug_sink) if debug_sink is not None else None
  495. service = AssistantService(
  496. cfg,
  497. FakeSubscriber(),
  498. emit=emit,
  499. time_fn=clock,
  500. triage=triage,
  501. laya_lane=lane,
  502. brief_fn=brief_fn,
  503. brief_reset=brief_reset,
  504. brief_file=brief_file,
  505. chat_fn=chat_fn,
  506. chat_reset=chat_reset,
  507. debug_sink_factory=factory,
  508. )
  509. return service, emitted, clock, triage, lane
  510. def _triage_events(emitted):
  511. return [e for e in emitted if e["type"] == "triage"]
  512. def _escalated_payload():
  513. return {"order": [], "items": {}, "escalated": True, "input_tokens": 3}
  514. def test_triage_status_disabled_when_no_analyzer():
  515. service, _, _ = _service()
  516. status = service.status()
  517. assert status["triage_state"] == "disabled"
  518. assert status["triage_reason"] == ""
  519. assert status["triage"] is None
  520. def test_triage_status_reflects_analyzer():
  521. service, _, _, _, _ = _triage_service(
  522. triage=FakeTriage(state_pair=("loading", "warming up"))
  523. )
  524. status = service.status()
  525. assert status["triage_state"] == "loading"
  526. assert status["triage_reason"] == "warming up"
  527. assert status["triage"] is None
  528. def test_status_contains_questions_from_analyzer():
  529. questions = {
  530. "urgency": {"type": "noul", "instructions": "how urgent"},
  531. "sentiment": {"type": "score", "instructions": "tone", "criteria": ["low", "high"]},
  532. }
  533. service, _, _, triage, _ = _triage_service(triage=FakeTriage(questions=questions))
  534. status = service.status()
  535. assert status["questions"] == questions
  536. assert status["questions"] is triage.questions
  537. def test_status_questions_none_without_analyzer():
  538. service, _, _ = _service()
  539. assert service.status()["questions"] is None
  540. def test_status_event_carries_questions():
  541. service, emitted, _, triage, _ = _triage_service()
  542. service.tick()
  543. statuses = [e for e in emitted if e["type"] == "status"]
  544. assert len(statuses) == 1
  545. assert statuses[0]["questions"] is triage.questions
  546. def test_triage_captures_transcript_lang():
  547. service, _, clock, _, _ = _triage_service()
  548. assert service._last_transcript_lang is None
  549. event = _transcript(clock, "hola")
  550. event["lang"] = "es"
  551. service.handle_event(event)
  552. assert service._last_transcript_lang == "es"
  553. service.handle_event(_transcript(clock, "hello"))
  554. assert service._last_transcript_lang is None
  555. def test_maybe_triage_passes_lang_to_lane():
  556. service, _, clock, _, lane = _triage_service()
  557. event = _transcript(clock, "hola")
  558. event["lang"] = "es"
  559. service.handle_event(event)
  560. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  561. service.tick()
  562. assert len(lane.submits) == 1
  563. _, _, lang, _ = lane.submits[0]
  564. assert lang == "es"
  565. def test_maybe_triage_runs_in_idle_mode():
  566. service, _, clock, triage, lane = _triage_service()
  567. service.handle_event(_transcript(clock, "hello"))
  568. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  569. service.tick()
  570. assert len(lane.submits) == 1
  571. state, questions, lang, gen = lane.submits[0]
  572. assert state == "- hello"
  573. assert questions is triage.questions
  574. assert lang is None
  575. assert gen == 0
  576. assert triage.build_state_calls == [("hello",)]
  577. assert service.triage_history == ["hello"]
  578. def test_maybe_triage_uses_transcript_buffer_not_chat_history():
  579. service, _, clock, triage, lane = _triage_service(chat_fn=None)
  580. service.chat_history = ["stale chat only"]
  581. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  582. service.tick()
  583. assert lane.submits == []
  584. assert triage.build_state_calls == []
  585. service.handle_event(_transcript(clock, "hello"))
  586. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  587. service.tick()
  588. assert len(lane.submits) == 1
  589. assert triage.build_state_calls == [("hello",)]
  590. def test_maybe_triage_requires_settled_turn():
  591. service, _, clock, _, lane = _triage_service()
  592. service.handle_event(_transcript(clock, "hello"))
  593. service.tick()
  594. assert lane.submits == []
  595. def test_maybe_triage_periodic_fires_before_turn_settles():
  596. service, _, clock, _, lane = _triage_service()
  597. service.cfg.triage.periodic_s = 0.2
  598. service.handle_event(_transcript(clock, "hello"))
  599. assert service.turn_ended() is False
  600. clock.advance(0.25) # due (0.2) yet still quieter than turn_gap_s (0.5)
  601. service.tick()
  602. assert service.turn_ended() is False
  603. assert len(lane.submits) == 1
  604. assert lane.submits[0][0] == "- hello"
  605. def test_maybe_triage_periodic_disabled_ignores_accumulating_speech():
  606. service, _, clock, _, lane = _triage_service()
  607. service.cfg.triage.periodic_s = 0.0
  608. service.handle_event(_transcript(clock, "hello"))
  609. clock.advance(0.25)
  610. service.tick()
  611. assert service.turn_ended() is False
  612. assert lane.submits == []
  613. def test_maybe_triage_periodic_rearms_after_submit():
  614. service, _, clock, _, lane = _triage_service()
  615. service.cfg.triage.periodic_s = 0.2
  616. service.handle_event(_transcript(clock, "first"))
  617. clock.advance(0.25)
  618. service.tick()
  619. assert len(lane.submits) == 1
  620. service.tick()
  621. service.tick()
  622. assert len(lane.submits) == 1 # identical window, no new speech
  623. service.handle_event(_transcript(clock, "second"))
  624. clock.advance(0.25)
  625. service.tick()
  626. assert len(lane.submits) == 2
  627. assert lane.submits[1][0] == "- first\n- second"
  628. def test_triage_debug_emits_submit_and_result():
  629. sink = FakeDebugSink()
  630. service, _, clock, _, lane = _triage_service(debug_sink=sink)
  631. service.handle_event(_transcript(clock, "hello"))
  632. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  633. service.tick()
  634. submits = [event for event in sink.events if event[0] == "triage-submit"]
  635. assert submits == [
  636. ("triage-submit", {"trigger": "settled", "window": 1, "generation": 0})
  637. ]
  638. _, _, _, gen = lane.submits[0]
  639. service._on_triage_result(gen, _escalated_payload())
  640. results = [event for event in sink.events if event[0] == "triage-result"]
  641. assert len(results) == 1
  642. assert results[0][1]["escalated"] is True
  643. assert results[0][1]["generation"] == 0
  644. def test_triage_debug_marks_periodic_trigger():
  645. sink = FakeDebugSink()
  646. service, _, clock, _, lane = _triage_service(debug_sink=sink)
  647. service.cfg.triage.periodic_s = 0.2
  648. service.handle_event(_transcript(clock, "hello"))
  649. clock.advance(0.25)
  650. service.tick()
  651. submits = [event for event in sink.events if event[0] == "triage-submit"]
  652. assert submits[0][1]["trigger"] == "periodic"
  653. def test_triage_debug_emits_brief_dispatch():
  654. sink = FakeDebugSink()
  655. service, _, clock, _, lane = _triage_service(
  656. brief_fn=lambda prompt: "RAW", debug_sink=sink
  657. )
  658. service.handle_event(_transcript(clock, "hello"))
  659. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  660. service.tick()
  661. _, _, _, gen = lane.submits[0]
  662. service._on_triage_result(gen, _escalated_payload())
  663. brief = [event for event in sink.events if event[0] == "triage-brief"]
  664. assert brief == [("triage-brief", {"action": "dispatch", "generation": 0})]
  665. def test_triage_debug_emits_brief_gate_skip():
  666. sink = FakeDebugSink()
  667. service, _, clock, _, lane = _triage_service(
  668. triage=FakeTriage(gate=False), brief_fn=lambda prompt: "RAW", debug_sink=sink
  669. )
  670. service.handle_event(_transcript(clock, "hello"))
  671. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  672. service.tick()
  673. _, _, _, gen = lane.submits[0]
  674. service._on_triage_result(gen, _escalated_payload())
  675. brief = [event for event in sink.events if event[0] == "triage-brief"]
  676. assert brief == [
  677. ("triage-brief", {"action": "skip", "reason": "gate", "generation": 0})
  678. ]
  679. def test_maybe_triage_skips_unready_lane():
  680. service, _, clock, _, lane = _triage_service(lane=FakeLane(ready=False))
  681. service.handle_event(_transcript(clock, "hello"))
  682. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  683. service.tick()
  684. assert lane.submits == []
  685. def test_maybe_triage_skips_without_questions():
  686. service, _, clock, triage, lane = _triage_service(
  687. triage=FakeTriage(questions=None)
  688. )
  689. service.handle_event(_transcript(clock, "hello"))
  690. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  691. service.tick()
  692. assert lane.submits == []
  693. assert triage.build_state_calls == []
  694. def test_maybe_triage_dedupes_identical_window():
  695. service, _, clock, triage, lane = _triage_service()
  696. service.handle_event(_transcript(clock, "hello"))
  697. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  698. service.tick()
  699. assert len(lane.submits) == 1
  700. state, questions, lang, gen = lane.submits[0]
  701. assert state == "- hello"
  702. assert questions is triage.questions
  703. assert lang is None
  704. assert gen == 0
  705. service.tick()
  706. service.tick()
  707. assert len(lane.submits) == 1
  708. service.handle_event(_transcript(clock, "second"))
  709. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  710. service.tick()
  711. assert len(lane.submits) == 2
  712. assert lane.submits[1][0] == "- hello\n- second"
  713. def test_second_transcript_produces_second_submit():
  714. service, _, clock, _, lane = _triage_service()
  715. service.handle_event(_transcript(clock, "first"))
  716. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  717. service.tick()
  718. assert len(lane.submits) == 1
  719. service.handle_event(_transcript(clock, "second"))
  720. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  721. service.tick()
  722. assert len(lane.submits) == 2
  723. assert lane.submits[1][0] == "- first\n- second"
  724. def test_tick_under_50ms_with_blocked_lane():
  725. service, _, clock, _, lane = _triage_service()
  726. assert not lane.predict_gate.is_set()
  727. service.toggle_chat()
  728. service.handle_event(_transcript(clock, "hello"))
  729. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  730. start = time.perf_counter()
  731. service.tick()
  732. elapsed = time.perf_counter() - start
  733. assert len(lane.submits) == 1
  734. assert elapsed < 0.05
  735. def test_on_triage_result_emits_signals():
  736. service, emitted, clock, _, lane = _triage_service()
  737. service.toggle_chat()
  738. service.handle_event(_transcript(clock, "hello"))
  739. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  740. service.tick()
  741. _, _, _, gen = lane.submits[0]
  742. payload = {
  743. "order": ["urgency"],
  744. "items": {"urgency": {"kind": "noul"}},
  745. "escalated": False,
  746. "input_tokens": 12,
  747. }
  748. service._on_triage_result(gen, payload)
  749. staged = _triage_events(emitted)
  750. assert len(staged) == 1
  751. assert staged[0]["stage"] == "signals"
  752. assert staged[0]["triage"] == service.last_triage
  753. assert staged[0]["triage"]["escalated"] is False
  754. assert staged[0]["triage"]["input_tokens"] == 12
  755. assert service.status()["triage"] == service.last_triage
  756. def test_triage_events_carry_the_server_timestamp():
  757. service, emitted, clock, _, lane = _triage_service(brief_fn=lambda prompt: "RAW")
  758. service.toggle_chat()
  759. service.handle_event(_transcript(clock, "hello"))
  760. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  761. service.tick()
  762. _, _, _, gen = lane.submits[0]
  763. expected_ts = clock()
  764. service._on_triage_result(gen, _escalated_payload())
  765. signals = [e for e in _triage_events(emitted) if e.get("stage") == "signals"]
  766. assert len(signals) == 1
  767. assert isinstance(signals[0]["ts"], (int, float))
  768. assert signals[0]["ts"] == expected_ts
  769. job = [j for j in service._inference._queue if j.name == "brief-update"][0]
  770. job.run()
  771. contents = [e for e in _triage_events(emitted) if e.get("stage") == "content"]
  772. assert len(contents) == 1
  773. assert isinstance(contents[0]["ts"], (int, float))
  774. assert contents[0]["ts"] == expected_ts # content reuses the signals timestamp
  775. def test_on_triage_result_suppresses_stale_generation():
  776. service, emitted, clock, _, lane = _triage_service()
  777. service.toggle_chat()
  778. service.handle_event(_transcript(clock, "hello"))
  779. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  780. service.tick()
  781. _, _, _, gen = lane.submits[0]
  782. service.clear()
  783. service._on_triage_result(gen, _escalated_payload())
  784. assert service.last_triage is None
  785. assert [e for e in _triage_events(emitted) if e.get("stage") == "signals"] == []
  786. service.handle_event(_transcript(clock, "hello"))
  787. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  788. service.tick()
  789. assert len(lane.submits) == 2
  790. def test_pending_brief_capped_by_char_budget():
  791. """The buffer keeps the newest deltas within budget, dropping the oldest."""
  792. service, _, clock, _, _ = _triage_service(brief_fn=lambda prompt: "RAW")
  793. service.cfg.triage.brief_pending_char_budget = 30
  794. service.handle_event(_transcript(clock, "aaa"))
  795. service.handle_event(_transcript(clock, "bbbb"))
  796. assert service._pending_brief == ["Unknown: aaa", "Unknown: bbbb"]
  797. service.handle_event(_transcript(clock, "ccccc"))
  798. assert service._pending_brief == ["Unknown: bbbb", "Unknown: ccccc"]
  799. assert service.triage_history == ["aaa", "bbbb", "ccccc"]
  800. def test_pending_brief_untouched_without_triage():
  801. service, _, clock = _service()
  802. service.handle_event(_transcript(clock, "hello"))
  803. assert service._pending_brief == []
  804. assert service.triage_history == ["hello"]
  805. def test_on_triage_result_accepts_non_chat_mode():
  806. service, emitted, clock, _, lane = _triage_service()
  807. service.handle_event(_transcript(clock, "hello"))
  808. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  809. service.tick()
  810. _, _, _, gen = lane.submits[0]
  811. window = service._last_triage_window
  812. service._on_triage_result(gen, _escalated_payload())
  813. assert service.last_triage is not None
  814. assert service._last_triage_window == window
  815. assert [e.get("stage") for e in _triage_events(emitted)] == ["signals"]
  816. def test_on_triage_result_ignores_none_payload():
  817. service, emitted, clock, _, lane = _triage_service()
  818. service.toggle_chat()
  819. service.handle_event(_transcript(clock, "hello"))
  820. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  821. service.tick()
  822. _, _, _, gen = lane.submits[0]
  823. service._on_triage_result(gen, None)
  824. assert service.last_triage is None
  825. assert _triage_events(emitted) == []
  826. def test_none_payload_dispatches_nothing_and_keeps_deltas():
  827. """A Laya predict failure never dispatches: no job, no events, deltas stay."""
  828. calls: list[str] = []
  829. service, emitted, clock, _, lane = _triage_service(
  830. brief_fn=lambda prompt: calls.append(prompt) or "RAW"
  831. )
  832. service.toggle_chat()
  833. service.handle_event(_transcript(clock, "hello"))
  834. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  835. service.tick()
  836. _, _, _, gen = lane.submits[0]
  837. assert service._pending_brief == ["Unknown: hello"]
  838. service._on_triage_result(gen, None)
  839. assert service.last_triage is None
  840. assert [e.get("stage") for e in _triage_events(emitted)] == []
  841. assert [j.name for j in service._inference._queue] == ["chat"]
  842. assert calls == []
  843. assert service._pending_brief == ["Unknown: hello"]
  844. assert service._brief_outstanding is False
  845. def test_none_payload_without_brief_fn_enqueues_nothing():
  846. service, emitted, clock, _, lane = _triage_service()
  847. service.toggle_chat()
  848. service.handle_event(_transcript(clock, "hello"))
  849. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  850. service.tick()
  851. _, _, _, gen = lane.submits[0]
  852. service._on_triage_result(gen, None)
  853. assert service.last_triage is None
  854. assert _triage_events(emitted) == []
  855. assert [j.name for j in service._inference._queue] == ["chat"]
  856. assert service._pending_brief == ["Unknown: hello"]
  857. def test_on_triage_result_ignores_empty_signals():
  858. service, emitted, clock, _, lane = _triage_service(
  859. triage=FakeTriage(normalized={})
  860. )
  861. service.toggle_chat()
  862. service.handle_event(_transcript(clock, "hello"))
  863. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  864. service.tick()
  865. _, _, _, gen = lane.submits[0]
  866. service._on_triage_result(gen, _escalated_payload())
  867. assert service.last_triage is None
  868. assert _triage_events(emitted) == []
  869. def test_substantive_turn_dispatches_one_brief_job():
  870. """A substantive settled turn calls the gate once and queues one brief job."""
  871. service, emitted, clock, triage, lane = _triage_service(
  872. triage=FakeTriage(escalate=True), brief_fn=lambda prompt: "RAW"
  873. )
  874. service.toggle_chat()
  875. service.handle_event(_transcript(clock, "we might churn"))
  876. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  877. service.tick()
  878. _, _, _, gen = lane.submits[0]
  879. service._on_triage_result(
  880. gen, {"order": [], "items": {}, "escalated": False, "input_tokens": 0}
  881. )
  882. assert service.last_triage is not None
  883. assert service.last_triage["escalated"] is True
  884. assert service._last_brief_signals == service.last_triage
  885. assert service._inference.depth() == 2
  886. assert [j.name for j in service._inference._queue] == ["chat", "brief-update"]
  887. assert [e.get("stage") for e in _triage_events(emitted)] == ["signals"]
  888. assert len(triage.gate_calls) == 1
  889. assert service._brief_outstanding is True
  890. assert service._brief_token == 1
  891. def test_brief_dispatches_without_escalation():
  892. service, _, clock, _, lane = _triage_service(brief_fn=lambda prompt: "RAW")
  893. service.toggle_chat()
  894. service.handle_event(_transcript(clock, "all calm"))
  895. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  896. service.tick()
  897. _, _, _, gen = lane.submits[0]
  898. service._on_triage_result(
  899. gen, {"order": [], "items": {}, "escalated": False, "input_tokens": 0}
  900. )
  901. assert service.last_triage is not None
  902. assert service._inference.depth() == 2
  903. assert [j.name for j in service._inference._queue] == ["chat", "brief-update"]
  904. def test_gated_out_turn_skips_brief():
  905. """A gated-out turn stores signals but never calls brief_fn."""
  906. calls: list[str] = []
  907. service, emitted, clock, triage, lane = _triage_service(
  908. triage=FakeTriage(gate=False),
  909. brief_fn=lambda prompt: calls.append(prompt) or "RAW",
  910. )
  911. service.toggle_chat()
  912. service.handle_event(_transcript(clock, "small talk"))
  913. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  914. service.tick()
  915. _, _, _, gen = lane.submits[0]
  916. service._on_triage_result(gen, _escalated_payload())
  917. assert service.last_triage is not None
  918. assert "brief" not in service.last_triage # no prior brief to retain
  919. assert [e.get("stage") for e in _triage_events(emitted)] == ["signals"]
  920. assert calls == []
  921. assert [j.name for j in service._inference._queue] == ["chat"]
  922. assert service._brief_outstanding is False
  923. assert len(triage.gate_calls) == 1
  924. def test_gated_out_turn_retains_previous_brief():
  925. """A gated-out settled turn keeps the last accepted brief in the panel."""
  926. service, emitted, clock, triage, lane = _triage_service(
  927. triage=FakeTriage(gate=False), brief_fn=lambda prompt: "RAW"
  928. )
  929. service.toggle_chat()
  930. signals = _escalated_payload()
  931. service._last_brief_signals = signals
  932. token = _seed_brief(service, "Unknown: first")
  933. service._run_brief_update(0, signals, service._now(), token)
  934. assert service.last_triage is not None
  935. assert service.last_triage["brief"] == "RAW"
  936. emitted.clear()
  937. service.handle_event(_transcript(clock, "small talk"))
  938. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  939. service.tick()
  940. _, _, _, gen = lane.submits[0]
  941. service._on_triage_result(gen, _escalated_payload())
  942. assert service.last_triage is not None
  943. assert service.last_triage["brief"] == "RAW"
  944. assert "brief" not in service._last_brief_signals # raw signals stay raw
  945. staged = [e for e in _triage_events(emitted) if e.get("stage") == "signals"]
  946. assert len(staged) == 1
  947. assert staged[0]["triage"] == service.last_triage
  948. assert staged[0]["triage"]["brief"] == "RAW"
  949. assert len(triage.gate_calls) == 1
  950. def test_gated_out_turn_retains_brief_when_extract_disabled():
  951. """`extract_enabled = false` skips the dispatch but still retains the brief."""
  952. service, emitted, clock, _, lane = _triage_service(
  953. triage=FakeTriage(gate=False), brief_fn=lambda prompt: "RAW"
  954. )
  955. service.toggle_chat()
  956. signals = _escalated_payload()
  957. service._last_brief_signals = signals
  958. token = _seed_brief(service, "Unknown: first")
  959. service._run_brief_update(0, signals, service._now(), token)
  960. assert service.last_triage is not None
  961. assert service.last_triage["brief"] == "RAW"
  962. service.cfg.triage.extract_enabled = False
  963. emitted.clear()
  964. service.handle_event(_transcript(clock, "small talk"))
  965. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  966. service.tick()
  967. _, _, _, gen = lane.submits[0]
  968. service._on_triage_result(gen, _escalated_payload())
  969. assert service.last_triage is not None
  970. assert service.last_triage["brief"] == "RAW"
  971. assert [j.name for j in service._inference._queue] == ["chat"]
  972. staged = [e for e in _triage_events(emitted) if e.get("stage") == "signals"]
  973. assert staged[0]["triage"]["brief"] == "RAW"
  974. def test_gated_out_turn_retains_brief_without_brief_fn():
  975. """No brief_fn means no dispatch, but a retained brief is still carried."""
  976. service, emitted, clock, _, lane = _triage_service(triage=FakeTriage(gate=False))
  977. service.toggle_chat()
  978. service.last_triage = {**_escalated_payload(), "brief": "KEEP"}
  979. emitted.clear()
  980. service.handle_event(_transcript(clock, "small talk"))
  981. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  982. service.tick()
  983. _, _, _, gen = lane.submits[0]
  984. service._on_triage_result(gen, _escalated_payload())
  985. assert service.last_triage["brief"] == "KEEP"
  986. staged = [e for e in _triage_events(emitted) if e.get("stage") == "signals"]
  987. assert staged[0]["triage"]["brief"] == "KEEP"
  988. def test_later_accepted_update_replaces_retained_brief():
  989. """A later accepted update overwrites the retained brief text."""
  990. texts = iter(["OLD", "NEW"])
  991. service, emitted, _, _, _ = _triage_service(brief_fn=lambda prompt: next(texts))
  992. service.toggle_chat()
  993. signals = _escalated_payload()
  994. service._last_brief_signals = signals
  995. token = _seed_brief(service, "Unknown: first")
  996. service._run_brief_update(0, signals, service._now(), token)
  997. assert service.last_triage is not None
  998. assert service.last_triage["brief"] == "OLD"
  999. token = _seed_brief(service, "Unknown: second")
  1000. service._run_brief_update(0, signals, service._now(), token)
  1001. assert service.last_triage is not None
  1002. assert service.last_triage["brief"] == "NEW"
  1003. contents = [e for e in _triage_events(emitted) if e.get("stage") == "content"]
  1004. assert contents[-1]["triage"]["brief"] == "NEW"
  1005. service.clear()
  1006. assert service.last_triage is None
  1007. def test_no_brief_when_disabled_in_config():
  1008. calls: list[str] = []
  1009. service, _, clock, _, lane = _triage_service(
  1010. triage=FakeTriage(escalate=True),
  1011. brief_fn=lambda prompt: calls.append(prompt) or "RAW",
  1012. )
  1013. service.cfg.triage.extract_enabled = False
  1014. service.toggle_chat()
  1015. service.handle_event(_transcript(clock, "churn risk"))
  1016. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  1017. service.tick()
  1018. _, _, _, gen = lane.submits[0]
  1019. service._on_triage_result(gen, _escalated_payload())
  1020. assert service.last_triage is not None
  1021. assert service.last_triage["escalated"] is True
  1022. assert calls == []
  1023. assert [j.name for j in service._inference._queue] == ["chat"]
  1024. def test_no_brief_without_brief_fn():
  1025. service, _, clock, _, lane = _triage_service(triage=FakeTriage(escalate=True))
  1026. service.toggle_chat()
  1027. service.handle_event(_transcript(clock, "churn risk"))
  1028. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  1029. service.tick()
  1030. _, _, _, gen = lane.submits[0]
  1031. service._on_triage_result(gen, _escalated_payload())
  1032. assert service.last_triage is not None
  1033. assert [j.name for j in service._inference._queue] == ["chat"]
  1034. assert service._brief_outstanding is False
  1035. def test_brief_refused_when_queue_full():
  1036. """A refused submit leaves deltas buffered and the outstanding flag clear."""
  1037. service, emitted, clock, _, lane = _triage_service(
  1038. triage=FakeTriage(escalate=True), brief_fn=lambda prompt: "RAW"
  1039. )
  1040. service._inference = InferenceQueue(size=2)
  1041. service.toggle_chat()
  1042. service.handle_event(_transcript(clock, "churn risk"))
  1043. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  1044. service.tick()
  1045. assert service._inference.depth() == 1
  1046. _, _, _, gen = lane.submits[0]
  1047. service._on_triage_result(gen, _escalated_payload())
  1048. assert service._inference.depth() == 1
  1049. assert service._inference._queue[0].name == "chat"
  1050. assert service.last_triage is not None
  1051. assert service.last_triage["escalated"] is True
  1052. assert [e.get("stage") for e in _triage_events(emitted)] == ["signals"]
  1053. assert service._pending_brief == ["Unknown: churn risk"]
  1054. assert service._brief_outstanding is False
  1055. def test_second_result_while_outstanding_is_refused():
  1056. """At most one brief job is outstanding: the second turn only stores signals."""
  1057. service, emitted, clock, _, lane = _triage_service(brief_fn=lambda prompt: "RAW")
  1058. service.toggle_chat()
  1059. service.handle_event(_transcript(clock, "first"))
  1060. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  1061. service.tick()
  1062. _, _, _, gen0 = lane.submits[0]
  1063. service._on_triage_result(gen0, _escalated_payload())
  1064. assert [j.name for j in service._inference._queue] == ["chat", "brief-update"]
  1065. service.handle_event(_transcript(clock, "second"))
  1066. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  1067. service.tick()
  1068. _, _, _, gen1 = lane.submits[1]
  1069. service._on_triage_result(gen1, _escalated_payload())
  1070. jobs = [j for j in service._inference._queue if j.name == "brief-update"]
  1071. assert len(jobs) == 1
  1072. assert [e.get("stage") for e in _triage_events(emitted)] == ["signals", "signals"]
  1073. assert service._brief_outstanding is True
  1074. assert service._pending_brief == ["Unknown: first", "Unknown: second"]
  1075. def _seed_brief(service, *deltas):
  1076. service._pending_brief = list(deltas)
  1077. service._brief_outstanding = True
  1078. return service._brief_token
  1079. def test_brief_merges_content_and_writes_file():
  1080. brief_file = FakeBriefFile()
  1081. service, emitted, _, triage, _ = _triage_service(
  1082. brief_fn=lambda prompt: "the brief", brief_file=brief_file
  1083. )
  1084. service.toggle_chat()
  1085. signals = _escalated_payload()
  1086. service._last_brief_signals = signals
  1087. token = _seed_brief(service, "Unknown: hello")
  1088. ts = service._now()
  1089. service._run_brief_update(0, signals, ts, token)
  1090. contents = [e for e in _triage_events(emitted) if e.get("stage") == "content"]
  1091. assert len(contents) == 1
  1092. assert contents[0]["triage"] == {**signals, "brief": "the brief"}
  1093. assert service.last_triage == contents[0]["triage"]
  1094. assert triage.prompt_calls == [(("Unknown: hello",), signals)]
  1095. assert brief_file.writes == ["the brief"]
  1096. assert service._pending_brief == []
  1097. assert service._brief_outstanding is False
  1098. def test_empty_brief_requeues_deltas():
  1099. """A `""` reply keeps signals, re-buffers the deltas, and clears the flag."""
  1100. service, emitted, _, _, _ = _triage_service(brief_fn=lambda prompt: "")
  1101. service.toggle_chat()
  1102. signals = _escalated_payload()
  1103. service.last_triage = signals
  1104. service._last_brief_signals = signals
  1105. token = _seed_brief(service, "Unknown: hello")
  1106. ts = service._now()
  1107. service._run_brief_update(0, signals, ts, token)
  1108. assert [e for e in _triage_events(emitted) if e.get("stage") == "content"] == []
  1109. assert service.last_triage == signals
  1110. assert "brief" not in service.last_triage
  1111. assert service._pending_brief == ["Unknown: hello"]
  1112. assert service._brief_outstanding is False
  1113. def test_brief_error_requeues_and_clears_flag():
  1114. """A raising brief_fn leaves the flag clear and the deltas buffered."""
  1115. def boom(prompt):
  1116. raise RuntimeError("llm down")
  1117. service, emitted, _, _, _ = _triage_service(brief_fn=boom)
  1118. service.toggle_chat()
  1119. token = _seed_brief(service, "Unknown: hello")
  1120. ts = service._now()
  1121. service._run_brief_update(0, _escalated_payload(), ts, token)
  1122. assert _triage_events(emitted) == []
  1123. assert service.last_triage is None
  1124. assert service._pending_brief == ["Unknown: hello"]
  1125. assert service._brief_outstanding is False
  1126. def test_brief_empty_buffer_returns_early():
  1127. """An empty buffer returns early: no call, no event, flag cleared."""
  1128. calls: list[str] = []
  1129. service, emitted, _, _, _ = _triage_service(
  1130. brief_fn=lambda prompt: calls.append(prompt) or "RAW"
  1131. )
  1132. service.toggle_chat()
  1133. service._brief_outstanding = True
  1134. token = service._brief_token
  1135. ts = service._now()
  1136. assert service._pending_brief == []
  1137. service._run_brief_update(0, _escalated_payload(), ts, token)
  1138. assert calls == []
  1139. assert _triage_events(emitted) == []
  1140. assert service._brief_outstanding is False
  1141. def test_brief_suppressed_after_reset():
  1142. service, emitted, _, _, _ = _triage_service(brief_fn=lambda prompt: "RAW")
  1143. service.toggle_chat()
  1144. service._pending_brief = ["Unknown: hello"]
  1145. service._reset_triage()
  1146. emitted.clear()
  1147. service._run_brief_update(0, _escalated_payload(), service._now(), 0)
  1148. assert _triage_events(emitted) == []
  1149. assert service.last_triage is None
  1150. assert service._pending_brief == ["Unknown: hello"]
  1151. def test_brief_works_after_leaving_chat():
  1152. seen = []
  1153. service, emitted, _, _, _ = _triage_service(
  1154. brief_fn=lambda prompt: seen.append(prompt) or "RAW"
  1155. )
  1156. service.toggle_chat()
  1157. assert service.modes.exit_chat() is True
  1158. token = _seed_brief(service, "Unknown: hello")
  1159. signals = _escalated_payload()
  1160. service._last_brief_signals = signals
  1161. service._run_brief_update(0, signals, service._now(), token)
  1162. assert seen != []
  1163. assert [e.get("stage") for e in _triage_events(emitted)] == ["content"]
  1164. assert service.last_triage is not None
  1165. assert service.last_triage["brief"] == "RAW"
  1166. def test_deltas_arriving_during_call_survive_and_flush():
  1167. """Deltas appended mid-call are not consumed; the finally flushes them."""
  1168. service, emitted, clock, _, _ = _triage_service()
  1169. service.toggle_chat()
  1170. signals = _escalated_payload()
  1171. service._last_brief_signals = signals
  1172. token = _seed_brief(service, "Unknown: first")
  1173. appended: list[int] = []
  1174. def _brief(prompt):
  1175. if not appended:
  1176. appended.append(1)
  1177. service.handle_event(_transcript(clock, "during call"))
  1178. return "first brief"
  1179. service._brief_fn = _brief
  1180. service._run_brief_update(0, signals, clock(), token)
  1181. contents = [e for e in _triage_events(emitted) if e.get("stage") == "content"]
  1182. assert len(contents) == 1
  1183. assert contents[0]["triage"]["brief"] == "first brief"
  1184. flushed = [j for j in service._inference._queue if j.name == "brief-update"]
  1185. assert len(flushed) == 1
  1186. assert service._brief_outstanding is True
  1187. assert service._pending_brief == ["Unknown: during call"]
  1188. flushed[0].run()
  1189. contents = [e for e in _triage_events(emitted) if e.get("stage") == "content"]
  1190. assert len(contents) == 2
  1191. assert contents[1]["triage"]["brief"] == "first brief"
  1192. assert service._pending_brief == []
  1193. assert service._brief_outstanding is False
  1194. def test_in_flight_brief_after_clear_emits_and_writes_nothing():
  1195. """Stale in-flight job: no event, no file write, no requeue, flag untouched."""
  1196. brief_file = FakeBriefFile()
  1197. service, emitted, clock, _, lane = _triage_service(
  1198. brief_fn=lambda prompt: "RAW", brief_file=brief_file
  1199. )
  1200. service.toggle_chat()
  1201. service.handle_event(_transcript(clock, "hello"))
  1202. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  1203. service.tick()
  1204. _, _, _, gen = lane.submits[0]
  1205. service._on_triage_result(gen, _escalated_payload())
  1206. job = [j for j in service._inference._queue if j.name == "brief-update"][0]
  1207. assert service._brief_outstanding is True
  1208. service.clear()
  1209. assert service._brief_outstanding is False
  1210. token_after_clear = service._brief_token
  1211. emitted.clear()
  1212. job.run()
  1213. assert [e for e in _triage_events(emitted)] == []
  1214. assert brief_file.writes == []
  1215. assert service._pending_brief == []
  1216. assert service.last_triage is None
  1217. assert service._brief_token == token_after_clear
  1218. assert service._brief_outstanding is False
  1219. def test_clear_resets_triage():
  1220. resets: list[int] = []
  1221. chats: list[int] = []
  1222. brief_file = FakeBriefFile()
  1223. service, emitted, clock, _, lane = _triage_service(
  1224. triage=FakeTriage(escalate=True),
  1225. brief_fn=lambda prompt: "RAW",
  1226. brief_file=brief_file,
  1227. brief_reset=lambda: resets.append(1),
  1228. chat_reset=lambda: chats.append(1),
  1229. )
  1230. service.toggle_chat()
  1231. service.handle_event(_transcript(clock, "churn"))
  1232. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  1233. service.tick()
  1234. _, _, _, gen = lane.submits[0]
  1235. service._on_triage_result(gen, _escalated_payload())
  1236. assert service._inference.depth() == 2
  1237. assert service._pending_brief == ["Unknown: churn"]
  1238. assert service._brief_outstanding is True
  1239. token_before = service._brief_token
  1240. assert service.clear() is True
  1241. assert service._triage_generation == 1
  1242. assert service.last_triage is None
  1243. assert service._last_triage_window == ()
  1244. assert service.triage_history == []
  1245. assert service._pending_brief == []
  1246. assert service._brief_token == token_before + 1
  1247. assert service._brief_outstanding is False
  1248. assert service._last_brief_signals is None
  1249. assert resets == [1]
  1250. assert brief_file.clears == 1
  1251. assert chats == [1]
  1252. assert lane.drops == 1
  1253. assert service._inference.depth() == 0
  1254. assert list(service._inference._queue) == []
  1255. cleared = [e for e in _triage_events(emitted) if e.get("stage") == "cleared"]
  1256. assert len(cleared) == 1
  1257. assert cleared[0]["triage"] is None
  1258. assert {"type": "cleared"} in emitted
  1259. signals_before = len(
  1260. [e for e in _triage_events(emitted) if e.get("stage") == "signals"]
  1261. )
  1262. service._on_triage_result(gen, _escalated_payload())
  1263. assert service.last_triage is None
  1264. assert (
  1265. len([e for e in _triage_events(emitted) if e.get("stage") == "signals"])
  1266. == signals_before
  1267. )
  1268. submits_before = len(lane.submits)
  1269. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  1270. service.tick()
  1271. assert len(lane.submits) == submits_before
  1272. def test_exit_chat_does_not_reset_triage():
  1273. chats: list[int] = []
  1274. bresets: list[int] = []
  1275. brief_file = FakeBriefFile()
  1276. service, emitted, clock, _, lane = _triage_service(
  1277. brief_fn=lambda prompt: "RAW",
  1278. chat_reset=lambda: chats.append(1),
  1279. brief_reset=lambda: bresets.append(1),
  1280. brief_file=brief_file,
  1281. )
  1282. service.toggle_chat()
  1283. service.handle_event(_transcript(clock, "hello"))
  1284. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  1285. service.tick()
  1286. assert len(lane.submits) == 1
  1287. _, _, _, gen = lane.submits[0]
  1288. service._on_triage_result(gen, _escalated_payload())
  1289. assert service.last_triage is not None
  1290. assert service._triage_generation == 0
  1291. assert service.toggle_chat() is True
  1292. assert service.modes.mode.value == "idle"
  1293. assert service._triage_generation == 0
  1294. assert service.last_triage is not None
  1295. assert service._last_triage_window == ("hello",)
  1296. assert service.triage_history == ["hello"]
  1297. assert service._pending_brief == ["Unknown: hello"]
  1298. assert service._last_brief_signals is not None
  1299. assert service._brief_outstanding is True
  1300. assert lane.drops == 0
  1301. cleared = [e for e in _triage_events(emitted) if e.get("stage") == "cleared"]
  1302. assert cleared == []
  1303. assert chats == [1]
  1304. assert bresets == []
  1305. assert brief_file.clears == 0
  1306. def test_toggle_chat_enter_does_not_touch_triage():
  1307. """Entering chat resets only the chat buffers; the brief engine is independent."""
  1308. bresets: list[int] = []
  1309. brief_file = FakeBriefFile()
  1310. service, emitted, clock, _, lane = _triage_service(
  1311. brief_fn=lambda prompt: "RAW",
  1312. brief_reset=lambda: bresets.append(1),
  1313. brief_file=brief_file,
  1314. )
  1315. service.handle_event(_transcript(clock, "hello"))
  1316. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  1317. service.tick()
  1318. _, _, _, gen = lane.submits[0]
  1319. service._on_triage_result(gen, _escalated_payload())
  1320. triage_before = service.last_triage
  1321. pending_before = list(service._pending_brief)
  1322. assert service.toggle_chat() is True
  1323. assert service.modes.mode.value == "chat"
  1324. assert service._triage_generation == 0
  1325. assert service.last_triage is triage_before
  1326. assert service._last_triage_window == ("hello",)
  1327. assert service.triage_history == ["hello"]
  1328. assert service._pending_brief == pending_before
  1329. assert service._last_brief_signals is not None
  1330. assert service._brief_outstanding is True
  1331. assert lane.drops == 0
  1332. assert bresets == []
  1333. assert brief_file.clears == 0
  1334. cleared = [e for e in _triage_events(emitted) if e.get("stage") == "cleared"]
  1335. assert cleared == []
  1336. def test_clear_without_triage_emits_no_triage_event():
  1337. service, emitted, _ = _service()
  1338. brief_file = FakeBriefFile()
  1339. bresets: list[int] = []
  1340. service._brief_file = brief_file
  1341. service._brief_reset = lambda: bresets.append(1)
  1342. service.clear()
  1343. assert {"type": "cleared"} in emitted
  1344. assert _triage_events(emitted) == []
  1345. assert brief_file.clears == 1
  1346. assert bresets == []
  1347. def test_stale_brief_after_clear_does_not_clear_newer_dispatch_flag():
  1348. """A stale in-flight job must not clear a newer dispatch's outstanding flag."""
  1349. brief_file = FakeBriefFile()
  1350. service, emitted, clock, _, lane = _triage_service(
  1351. brief_fn=lambda prompt: "RAW", brief_file=brief_file
  1352. )
  1353. service.toggle_chat()
  1354. service.handle_event(_transcript(clock, "hello"))
  1355. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  1356. service.tick()
  1357. _, _, _, gen = lane.submits[0]
  1358. service._on_triage_result(gen, _escalated_payload())
  1359. stale_job = [j for j in service._inference._queue if j.name == "brief-update"][0]
  1360. assert service._brief_outstanding is True
  1361. service.clear()
  1362. # A fresh turn dispatches a new brief AFTER clear bumped the token.
  1363. service.handle_event(_transcript(clock, "fresh"))
  1364. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  1365. service.tick()
  1366. _, _, _, gen2 = lane.submits[1]
  1367. service._on_triage_result(gen2, _escalated_payload())
  1368. assert service._brief_outstanding is True
  1369. newer_token = service._brief_token
  1370. pending_before = list(service._pending_brief)
  1371. triage_before = service.last_triage
  1372. emitted.clear()
  1373. stale_job.run()
  1374. assert _triage_events(emitted) == []
  1375. assert brief_file.writes == []
  1376. assert service._pending_brief == pending_before
  1377. assert service._brief_outstanding is True
  1378. assert service._brief_token == newer_token
  1379. assert service.last_triage is triage_before
  1380. def test_clear_resets_chat_latch():
  1381. service, emitted, _ = _service()
  1382. service.toggle_chat()
  1383. service._chat_queue_full = True
  1384. service._pending_chat = ["stuck text"]
  1385. service.clear()
  1386. assert service._chat_queue_full is False
  1387. assert service._pending_chat == []
  1388. assert {"type": "cleared"} in emitted
  1389. def test_triage_end_to_end_signals_content_cleared():
  1390. """Two settled turns collapse into ONE brief job (single-outstanding guard).
  1391. The second `_on_triage_result` is refused as `"outstanding"`, so the queue
  1392. holds one `brief-update` that consumes both deltas and emits one `content`.
  1393. The panel keeps the FIRST turn's signals until the next settled turn (lag).
  1394. """
  1395. prompts: list[str] = []
  1396. service, emitted, clock, triage, lane = _triage_service(
  1397. brief_fn=lambda prompt: prompts.append(prompt) or "the brief"
  1398. )
  1399. service.toggle_chat()
  1400. service.handle_event(_transcript(clock, "first thought"))
  1401. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  1402. service.tick()
  1403. assert len(lane.submits) == 1
  1404. _, _, _, gen0 = lane.submits[0]
  1405. service._on_triage_result(
  1406. gen0, {"order": ["urgency"], "items": {}, "escalated": False, "input_tokens": 1}
  1407. )
  1408. assert [e.get("stage") for e in _triage_events(emitted)] == ["signals"]
  1409. assert prompts == []
  1410. assert service.last_triage is not None
  1411. assert service.last_triage["escalated"] is False
  1412. assert [j.name for j in service._inference._queue] == ["chat", "brief-update"]
  1413. triage._escalate = True
  1414. service.handle_event(_transcript(clock, "we might churn"))
  1415. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  1416. service.tick()
  1417. assert len(lane.submits) == 2
  1418. _, _, _, gen1 = lane.submits[1]
  1419. service._on_triage_result(gen1, _escalated_payload())
  1420. assert [e.get("stage") for e in _triage_events(emitted)] == ["signals", "signals"]
  1421. assert [j.name for j in service._inference._queue] == [
  1422. "chat",
  1423. "brief-update",
  1424. "chat",
  1425. ]
  1426. for job in [j for j in service._inference._queue if j.name == "brief-update"]:
  1427. job.run()
  1428. contents = [e for e in _triage_events(emitted) if e.get("stage") == "content"]
  1429. assert len(contents) == 1
  1430. assert len(prompts) == 1
  1431. deltas, _ = triage.prompt_calls[0]
  1432. assert deltas == ("Unknown: first thought", "Unknown: we might churn")
  1433. assert contents[0]["triage"]["escalated"] is False
  1434. assert contents[0]["triage"]["brief"] == "the brief"
  1435. assert service.last_triage == contents[0]["triage"]
  1436. assert service.status()["triage"] == contents[0]["triage"]
  1437. service.clear()
  1438. cleared = [e for e in _triage_events(emitted) if e.get("stage") == "cleared"]
  1439. assert len(cleared) == 1
  1440. assert cleared[0]["triage"] is None
  1441. assert service.last_triage is None
  1442. service._on_triage_result(gen1, _escalated_payload())
  1443. assert [e.get("stage") for e in _triage_events(emitted)] == [
  1444. "signals",
  1445. "signals",
  1446. "content",
  1447. "cleared",
  1448. ]
  1449. assert service.toggle_chat() is True
  1450. service.handle_event(_transcript(clock, "idle thought"))
  1451. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  1452. service.tick()
  1453. assert len(lane.submits) == 3
  1454. assert lane.submits[2][0].endswith("- idle thought")
  1455. def test_tick_emits_status_on_triage_state_change():
  1456. service, emitted, _, triage, _ = _triage_service(
  1457. triage=FakeTriage(state_pair=("loading", "warming up"))
  1458. )
  1459. service.tick()
  1460. statuses = [e for e in emitted if e["type"] == "status"]
  1461. assert len(statuses) == 1
  1462. assert statuses[0]["triage_state"] == "loading"
  1463. assert statuses[0]["triage_reason"] == "warming up"
  1464. assert "triage" in statuses[0]
  1465. triage._state_pair = ("ok", "")
  1466. service.tick()
  1467. statuses = [e for e in emitted if e["type"] == "status"]
  1468. assert len(statuses) == 2
  1469. assert statuses[1]["triage_state"] == "ok"
  1470. assert statuses[1]["triage_reason"] == ""
  1471. assert "triage" in statuses[1]
  1472. service.tick()
  1473. assert len([e for e in emitted if e["type"] == "status"]) == 2
  1474. def test_no_status_emitted_when_triage_disabled():
  1475. service, emitted, _ = _service()
  1476. service.tick()
  1477. service.tick()
  1478. assert [e for e in emitted if e["type"] == "status"] == []
  1479. def test_tick_heals_triage_panel_after_lane_ready():
  1480. import time as _time
  1481. from pathlib import Path
  1482. from stt_daemon.assistant.laya_lane import LayaLane
  1483. from stt_daemon.assistant.triage import TriageAnalyzer
  1484. from stt_daemon.tui.state import ViewState
  1485. class _FakeRouter:
  1486. def preload(self, names):
  1487. return self
  1488. def predict(self, state, questions, model=None, lang=None, **kwargs):
  1489. if "_warmup" in questions:
  1490. return {"model": model, "answers": {}, "usage": {}, "routing": {}}
  1491. return {
  1492. "model": model,
  1493. "answers": {
  1494. "frustration": {
  1495. "noul": 0.1,
  1496. "confidence": 0.9,
  1497. "answer_confidence": 0.9,
  1498. },
  1499. "urgency": {
  1500. "choice": "low",
  1501. "confidence": 0.9,
  1502. "answer_confidence": 0.9,
  1503. },
  1504. },
  1505. "usage": {"input_tokens": 5},
  1506. }
  1507. def _factory(**kwargs):
  1508. return _FakeRouter()
  1509. cfg = Config()
  1510. cfg.assistant.turn_gap_s = 0.5
  1511. cfg.triage.questions_file = str(
  1512. Path(__file__).resolve().parent.parent / "questions.example.json"
  1513. )
  1514. clock = Clock()
  1515. emitted: list[dict] = []
  1516. def emit(type_, **fields):
  1517. emitted.append({"type": type_, **fields})
  1518. analyzer = TriageAnalyzer(cfg.triage)
  1519. assert analyzer.questions, "example questions must load"
  1520. holder: dict = {}
  1521. lane = LayaLane(
  1522. cfg.triage,
  1523. agent_factory=_factory,
  1524. on_result=lambda gen, payload: holder["svc"]._on_triage_result(gen, payload),
  1525. on_state=lambda state, reason: analyzer.refresh(state, reason),
  1526. )
  1527. service = AssistantService(
  1528. cfg,
  1529. FakeSubscriber(),
  1530. emit=emit,
  1531. time_fn=clock,
  1532. triage=analyzer,
  1533. laya_lane=lane,
  1534. chat_fn=_ok_reply,
  1535. )
  1536. holder["svc"] = service
  1537. try:
  1538. lane.start()
  1539. deadline = _time.monotonic() + 5.0
  1540. while not lane.ready() and _time.monotonic() < deadline:
  1541. _time.sleep(0.005)
  1542. assert lane.ready(), "lane did not become ready"
  1543. assert analyzer.state() == ("ok", "")
  1544. service.tick()
  1545. statuses = [e for e in emitted if e["type"] == "status"]
  1546. assert statuses, "tick emitted no status after lane ready"
  1547. assert statuses[-1]["triage_state"] == "ok"
  1548. service.handle_event(_transcript(clock, "hello"))
  1549. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  1550. service.tick()
  1551. deadline = _time.monotonic() + 5.0
  1552. while service.last_triage is None and _time.monotonic() < deadline:
  1553. _time.sleep(0.005)
  1554. assert service.last_triage is not None, "no triage signals from lane"
  1555. view = ViewState()
  1556. for event in emitted:
  1557. view.ingest(event)
  1558. assert view.triage_state == "ok"
  1559. lines = view.triage_lines()
  1560. assert lines
  1561. assert not any("unavailable" in line for line in lines)
  1562. assert not any("loading" in line for line in lines)
  1563. finally:
  1564. lane.stop()
  1565. def _dump_brief(prompt, on_io=None):
  1566. """Brief fake that mimics LlmClient.chat's on_io phases."""
  1567. if on_io is not None:
  1568. on_io({"phase": "request", "url": "http://llm/v1", "body": {"prompt": prompt}})
  1569. on_io({"phase": "response", "payload": {"content": "parsed"}, "error": None})
  1570. return "BRIEF"
  1571. def _run_triage_flow(service, emitted, clock, lane, payload):
  1572. service.toggle_chat()
  1573. service.handle_event(_transcript(clock, "hello"))
  1574. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  1575. service.tick()
  1576. _, _, _, gen = lane.submits[0]
  1577. service._on_triage_result(gen, payload)
  1578. return gen
  1579. def _dump_files(tmp_path):
  1580. return list(tmp_path.rglob("*.json"))
  1581. def test_dump_writes_full_laya_and_llm_io(tmp_path):
  1582. service, emitted, clock, triage, lane = _triage_service(brief_fn=_dump_brief)
  1583. service._triage_dump = TriageDumper(True, directory=str(tmp_path))
  1584. service.cfg.triage.dump_io = True
  1585. _run_triage_flow(service, emitted, clock, lane, _escalated_payload())
  1586. jobs = [j for j in service._inference._queue if j.name == "brief-update"]
  1587. assert len(jobs) == 1
  1588. jobs[0].run()
  1589. files = _dump_files(tmp_path)
  1590. assert len(files) == 1
  1591. assert re.fullmatch(r"\d{6}-\d{3}\.json", files[0].name)
  1592. data = json.loads(files[0].read_text(encoding="utf-8"))
  1593. assert data["ts"] == clock()
  1594. assert isinstance(data["iso"], str) and data["iso"]
  1595. assert data["laya"]["request"]["state"] == "- hello"
  1596. assert data["laya"]["request"]["questions"] == triage.questions
  1597. assert data["laya"]["request"]["model"] == "multilingual"
  1598. assert data["laya"]["request"]["max_len"] == 1024
  1599. assert data["laya"]["response"] == _escalated_payload()
  1600. assert data["laya"]["error"] is None
  1601. assert data["llm"]["request"]["url"] == "http://llm/v1"
  1602. assert data["llm"]["request"]["body"] == {"prompt": "BRIEF-PROMPT"}
  1603. assert data["llm"]["response"] == {"content": "parsed"}
  1604. assert data["llm"]["error"] is None
  1605. assert service._triage_dump._pending == {}
  1606. def test_dump_laya_error_writes_laya_only_and_keeps_deltas(tmp_path):
  1607. """A Laya predict failure finalizes the Laya half with `llm: null`.
  1608. Nothing is dispatched, so no LLM half is ever recorded and the buffered
  1609. deltas survive for the next settled turn.
  1610. """
  1611. service, emitted, clock, _, lane = _triage_service(brief_fn=_dump_brief)
  1612. service._triage_dump = TriageDumper(True, directory=str(tmp_path))
  1613. service.cfg.triage.dump_io = True
  1614. _run_triage_flow(service, emitted, clock, lane, None)
  1615. assert [j.name for j in service._inference._queue] == ["chat"]
  1616. assert service._pending_brief == ["Unknown: hello"]
  1617. files = _dump_files(tmp_path)
  1618. assert len(files) == 1
  1619. data = json.loads(files[0].read_text(encoding="utf-8"))
  1620. assert data["laya"]["response"] is None
  1621. assert data["laya"]["error"] == "predict failed"
  1622. assert data["llm"] is None
  1623. assert service._triage_dump._pending == {}
  1624. def test_dump_without_brief_has_laya_only(tmp_path):
  1625. service, emitted, clock, _, lane = _triage_service(brief_fn=_dump_brief)
  1626. service._triage_dump = TriageDumper(True, directory=str(tmp_path))
  1627. service.cfg.triage.dump_io = True
  1628. service.cfg.triage.extract_enabled = False
  1629. _run_triage_flow(service, emitted, clock, lane, _escalated_payload())
  1630. files = _dump_files(tmp_path)
  1631. assert len(files) == 1
  1632. data = json.loads(files[0].read_text(encoding="utf-8"))
  1633. assert data["laya"]["response"] == _escalated_payload()
  1634. assert data["llm"] is None
  1635. assert service._triage_dump._pending == {}
  1636. def test_dump_queue_full_has_laya_only(tmp_path):
  1637. service, emitted, clock, _, lane = _triage_service(brief_fn=_dump_brief)
  1638. service._triage_dump = TriageDumper(True, directory=str(tmp_path))
  1639. service.cfg.triage.dump_io = True
  1640. service._inference = InferenceQueue(size=2)
  1641. _run_triage_flow(service, emitted, clock, lane, _escalated_payload())
  1642. assert service._inference.depth() == 1
  1643. assert [j.name for j in service._inference._queue] == ["chat"]
  1644. assert service._pending_brief == ["Unknown: hello"]
  1645. files = _dump_files(tmp_path)
  1646. assert len(files) == 1
  1647. data = json.loads(files[0].read_text(encoding="utf-8"))
  1648. assert data["laya"]["response"] == _escalated_payload()
  1649. assert data["llm"] is None
  1650. assert service._triage_dump._pending == {}
  1651. def test_dump_disabled_writes_nothing(tmp_path):
  1652. service, emitted, clock, _, lane = _triage_service(
  1653. brief_fn=lambda prompt: "RAW"
  1654. )
  1655. assert service._triage_dump.enabled is False
  1656. service._triage_dump = TriageDumper(False, directory=str(tmp_path))
  1657. _run_triage_flow(service, emitted, clock, lane, _escalated_payload())
  1658. jobs = [j for j in service._inference._queue if j.name == "brief-update"]
  1659. assert len(jobs) == 1
  1660. jobs[0].run()
  1661. assert _dump_files(tmp_path) == []
  1662. def test_dump_stale_result_discards_without_file(tmp_path):
  1663. service, emitted, clock, triage, lane = _triage_service(brief_fn=_dump_brief)
  1664. service._triage_dump = TriageDumper(True, directory=str(tmp_path))
  1665. service.cfg.triage.dump_io = True
  1666. service.toggle_chat()
  1667. service.handle_event(_transcript(clock, "hello"))
  1668. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  1669. service.tick()
  1670. _, _, _, gen = lane.submits[0]
  1671. real_normalize = triage.normalize
  1672. def stale_normalize(payload):
  1673. # Simulate a clear landing between the first check/begin and the re-check.
  1674. service._triage_generation += 1
  1675. return real_normalize(payload)
  1676. triage.normalize = stale_normalize
  1677. service._on_triage_result(gen, _escalated_payload())
  1678. assert _dump_files(tmp_path) == []
  1679. assert service._triage_dump._pending == {}
  1680. def test_dump_stale_brief_discards_without_file(tmp_path):
  1681. service, _, clock, _, _ = _triage_service(brief_fn=_dump_brief)
  1682. service._triage_dump = TriageDumper(True, directory=str(tmp_path))
  1683. service.cfg.triage.dump_io = True
  1684. ts = clock()
  1685. service._triage_dump.begin(ts, laya={"request": {}, "response": {}, "error": None})
  1686. service._pending_brief = ["Unknown: hello"]
  1687. service._triage_generation += 1 # stale before the brief even starts
  1688. service._run_brief_update(0, _escalated_payload(), ts, service._brief_token)
  1689. assert _dump_files(tmp_path) == []
  1690. assert service._triage_dump._pending == {}
  1691. assert service._pending_brief == ["Unknown: hello"]
  1692. def test_dump_brief_cleared_mid_flight_writes_nothing(tmp_path):
  1693. service, _, clock, _, _ = _triage_service(brief_fn=_dump_brief)
  1694. service._triage_dump = TriageDumper(True, directory=str(tmp_path))
  1695. service.cfg.triage.dump_io = True
  1696. def stale_brief(prompt, on_io=None):
  1697. # Simulate a clear landing mid-LLM-call (after the request phase fired).
  1698. service._triage_generation += 1
  1699. if on_io is not None:
  1700. on_io({"phase": "request", "url": "http://llm/v1", "body": {}})
  1701. on_io({"phase": "response", "payload": {"c": 1}, "error": None})
  1702. return "RAW"
  1703. service._brief_fn = stale_brief
  1704. service._pending_brief = ["Unknown: hello"]
  1705. service._brief_outstanding = True
  1706. token = service._brief_token
  1707. ts = clock()
  1708. service._triage_dump.begin(ts, laya={"request": {}, "response": {}, "error": None})
  1709. service._run_brief_update(0, _escalated_payload(), ts, token)
  1710. assert _dump_files(tmp_path) == []
  1711. assert service._triage_dump._pending == {}
  1712. assert service._pending_brief == []
  1713. assert service._brief_outstanding is False
  1714. def test_dump_gated_out_writes_laya_only_and_no_pending(tmp_path):
  1715. """A turn the gate leaves out writes `llm: null` and leaks no pending record."""
  1716. service, emitted, clock, triage, lane = _triage_service(
  1717. triage=FakeTriage(escalate=True, gate=False), brief_fn=_dump_brief
  1718. )
  1719. service._triage_dump = TriageDumper(True, directory=str(tmp_path))
  1720. service.cfg.triage.dump_io = True
  1721. _run_triage_flow(service, emitted, clock, lane, _escalated_payload())
  1722. assert [j.name for j in service._inference._queue] == ["chat"]
  1723. assert len(triage.gate_calls) == 1
  1724. files = _dump_files(tmp_path)
  1725. assert len(files) == 1
  1726. data = json.loads(files[0].read_text(encoding="utf-8"))
  1727. assert data["laya"]["response"] == _escalated_payload()
  1728. assert data["llm"] is None
  1729. assert service._triage_dump._pending == {}
  1730. def test_dump_coalesced_update_writes_laya_only_then_llm_only_flush(tmp_path):
  1731. """A coalesced turn writes a Laya-only record; the later flush a separate llm-only one."""
  1732. service, emitted, clock, _, lane = _triage_service(brief_fn=_dump_brief)
  1733. service._triage_dump = TriageDumper(True, directory=str(tmp_path))
  1734. service.cfg.triage.dump_io = True
  1735. service.toggle_chat()
  1736. service.handle_event(_transcript(clock, "first"))
  1737. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  1738. service.tick()
  1739. _, _, _, gen0 = lane.submits[0]
  1740. service._on_triage_result(gen0, _escalated_payload())
  1741. service.handle_event(_transcript(clock, "second"))
  1742. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  1743. service.tick()
  1744. _, _, _, gen1 = lane.submits[1]
  1745. service._on_triage_result(gen1, _escalated_payload())
  1746. assert service._brief_outstanding is True
  1747. appended: list[int] = []
  1748. def _brief(prompt, on_io=None):
  1749. if not appended:
  1750. appended.append(1)
  1751. service.handle_event(_transcript(clock, "during call"))
  1752. if on_io is not None:
  1753. on_io({"phase": "request", "url": "http://llm/v1", "body": {"prompt": prompt}})
  1754. on_io({"phase": "response", "payload": {"content": "parsed"}, "error": None})
  1755. return "BRIEF"
  1756. service._brief_fn = _brief
  1757. clock.advance(1.0)
  1758. job = [j for j in service._inference._queue if j.name == "brief-update"][0]
  1759. service._inference._queue.remove(job)
  1760. job.run()
  1761. flushed = [j for j in service._inference._queue if j.name == "brief-update"]
  1762. assert len(flushed) == 1
  1763. flushed[0].run()
  1764. assert service._triage_dump._pending == {}
  1765. records = [
  1766. json.loads(path.read_text(encoding="utf-8")) for path in _dump_files(tmp_path)
  1767. ]
  1768. assert len(records) == 3
  1769. coalesced = [r for r in records if r["laya"] is not None and r["llm"] is None]
  1770. flushed_records = [r for r in records if r["laya"] is None and r["llm"] is not None]
  1771. both = [r for r in records if r["laya"] is not None and r["llm"] is not None]
  1772. assert len(coalesced) == 1
  1773. assert len(flushed_records) == 1
  1774. assert len(both) == 1
  1775. assert coalesced[0]["ts"] != flushed_records[0]["ts"]
  1776. assert flushed_records[0]["llm"]["request"]["body"] == {"prompt": "BRIEF-PROMPT"}
  1777. def test_chat_client_failure_emits_llm_error_and_service_survives():
  1778. """Adversarial (a): a chat client raising on `chat` surfaces as an `llm_error`
  1779. event and the service keeps functioning afterwards."""
  1780. from stt_daemon.assistant.llm import ConversationEngine, LlmError
  1781. class BoomClient:
  1782. def chat(self, messages, max_tokens=None, timeout_s=None, **kwargs):
  1783. raise LlmError("boom")
  1784. engine = ConversationEngine(Config().llm, BoomClient(), system_prompt="SYS")
  1785. service, emitted, clock = _service()
  1786. service.chat_fn = engine.send
  1787. assert service.toggle_chat() is True
  1788. service._run_chat("hello")
  1789. errors = [e for e in emitted if e["type"] == "error" and e.get("code") == "llm_error"]
  1790. assert errors and "boom" in errors[-1]["message"]
  1791. assert service.toggle_chat() is True
  1792. assert service.modes.mode.value == "idle"
  1793. # ---------------------------------------------------------------------------
  1794. # Conversation session adoption (SESSION/TRANSCRIPT session_dir).
  1795. # ---------------------------------------------------------------------------
  1796. def _session_event(clock, session_dir):
  1797. event = _ev(events.SESSION, clock)
  1798. event["session_id"] = session_dir.rsplit("/", 1)[-1]
  1799. event["session_dir"] = session_dir
  1800. return event
  1801. def _ring(service, clock, *items):
  1802. """Feed a daemon-seeded replay window: status -> items -> ring_end."""
  1803. service.handle_event(_ev(events.STATUS, clock))
  1804. for item in items:
  1805. service.handle_event(item)
  1806. service.handle_event(_ev(events.RING_END, clock))
  1807. def _cleared(emitted):
  1808. return [e for e in _triage_events(emitted) if e.get("stage") == "cleared"]
  1809. def test_status_includes_session_dir_without_brief_file():
  1810. service, _, clock = _service()
  1811. assert service.status()["session_dir"] is None
  1812. service.handle_event(_session_event(clock, "transcripts/2026-09-30-12-47-29"))
  1813. assert service.status()["session_dir"] == "transcripts/2026-09-30-12-47-29"
  1814. def test_live_session_event_sets_session_and_records_directory():
  1815. brief_file = FakeBriefFile()
  1816. service, _, clock, _, _ = _triage_service(brief_file=brief_file)
  1817. session = "transcripts/2026-09-30-12-47-29"
  1818. service.handle_event(_session_event(clock, session))
  1819. assert service.status()["session_dir"] == session
  1820. assert brief_file.directories == [session]
  1821. assert service._triage_generation == 0
  1822. def test_live_transcript_session_sets_session_without_wiping_utterance():
  1823. brief_file = FakeBriefFile()
  1824. service, _, clock, _, _ = _triage_service(brief_file=brief_file)
  1825. session = "transcripts/s1"
  1826. service.handle_event(_transcript(clock, "hello", session_dir=session))
  1827. assert service.status()["session_dir"] == session
  1828. assert brief_file.directories == [session]
  1829. assert service.triage_history == ["hello"]
  1830. assert service._pending_brief == ["Unknown: hello"]
  1831. assert service._triage_generation == 0
  1832. def test_brief_write_lands_under_session_dir(tmp_path):
  1833. from stt_daemon.assistant.brief_file import BriefFile
  1834. brief_file = BriefFile(True)
  1835. service, _, clock, _, _ = _triage_service(brief_file=brief_file)
  1836. session = str(tmp_path / "transcripts" / "s1")
  1837. service.handle_event(_transcript(clock, "hello", session_dir=session))
  1838. brief_file.write("the brief")
  1839. path = tmp_path / "transcripts" / "s1" / "brief.md"
  1840. assert path.read_text(encoding="utf-8") == "the brief"
  1841. def test_live_session_change_resets_triage_and_keeps_chat():
  1842. brief_file = FakeBriefFile()
  1843. resets: list[int] = []
  1844. service, emitted, clock, _, lane = _triage_service(
  1845. brief_file=brief_file, brief_reset=lambda: resets.append(1)
  1846. )
  1847. service.toggle_chat()
  1848. service.handle_event(_transcript(clock, "hello"))
  1849. service.handle_event(_session_event(clock, "transcripts/a"))
  1850. service.last_triage = {"signals": 1}
  1851. service._pending_brief = ["stale"]
  1852. emitted.clear()
  1853. service.handle_event(_session_event(clock, "transcripts/b"))
  1854. assert service.status()["session_dir"] == "transcripts/b"
  1855. assert service.last_triage is None
  1856. assert service._pending_brief == []
  1857. assert service._triage_generation == 1
  1858. assert service.chat_history == ["Unknown: hello"]
  1859. assert resets == [1]
  1860. assert lane.drops == 1
  1861. assert brief_file.directories == ["transcripts/a", "transcripts/b"]
  1862. assert len(_cleared(emitted)) == 1
  1863. def test_sessionless_transcript_does_not_reset():
  1864. service, _, clock, _, _ = _triage_service()
  1865. service.handle_event(_session_event(clock, "transcripts/a"))
  1866. service.last_triage = {"signals": 1}
  1867. service.handle_event(_transcript(clock, "hello"))
  1868. assert service._triage_generation == 0
  1869. assert service.last_triage == {"signals": 1}
  1870. assert service.status()["session_dir"] == "transcripts/a"
  1871. def test_same_dir_readoption_does_not_reset():
  1872. brief_file = FakeBriefFile()
  1873. service, _, clock, _, _ = _triage_service(brief_file=brief_file)
  1874. session = "transcripts/a"
  1875. service.handle_event(_session_event(clock, session))
  1876. service.last_triage = {"signals": 1}
  1877. service.handle_event(_transcript(clock, "again", session_dir=session))
  1878. assert service._triage_generation == 0
  1879. assert service.last_triage == {"signals": 1}
  1880. assert brief_file.directories == [session]
  1881. def test_session_change_without_brief_file_does_not_raise():
  1882. service, _, clock, _, _ = _triage_service(brief_file=None)
  1883. service.handle_event(_session_event(clock, "transcripts/a"))
  1884. service.handle_event(_session_event(clock, "transcripts/b"))
  1885. assert service.status()["session_dir"] == "transcripts/b"
  1886. assert service._triage_generation == 1
  1887. def test_replay_single_session_adopts_without_reset():
  1888. brief_file = FakeBriefFile()
  1889. service, emitted, clock, _, _ = _triage_service(brief_file=brief_file)
  1890. session = "transcripts/a"
  1891. _ring(service, clock, _transcript(clock, "hello", session_dir=session))
  1892. assert service.status()["session_dir"] == session
  1893. assert brief_file.directories == [session]
  1894. assert service._triage_generation == 0
  1895. assert _cleared(emitted) == []
  1896. assert service.triage_history == ["hello"]
  1897. def test_replay_two_sessions_commits_newest_and_resets_once():
  1898. brief_file = FakeBriefFile()
  1899. service, emitted, clock, _, _ = _triage_service(brief_file=brief_file)
  1900. a, b = "transcripts/a", "transcripts/b"
  1901. _ring(
  1902. service,
  1903. clock,
  1904. _session_event(clock, a),
  1905. _transcript(clock, "old turn", session_dir=a),
  1906. _session_event(clock, b),
  1907. _transcript(clock, "new turn", session_dir=b),
  1908. )
  1909. assert service.status()["session_dir"] == b
  1910. assert brief_file.directories == [b]
  1911. assert service._triage_generation == 1
  1912. assert service.last_triage is None
  1913. assert service._pending_brief == []
  1914. assert len(_cleared(emitted)) == 1
  1915. def test_reconnect_tailing_current_session_is_noop():
  1916. brief_file = FakeBriefFile()
  1917. service, emitted, clock, _, _ = _triage_service(brief_file=brief_file)
  1918. session = "transcripts/a"
  1919. service.handle_event(_session_event(clock, session))
  1920. service.last_triage = {"signals": 1}
  1921. emitted.clear()
  1922. _ring(service, clock, _transcript(clock, "replayed", session_dir=session))
  1923. assert service.status()["session_dir"] == session
  1924. assert brief_file.directories == [session]
  1925. assert service._triage_generation == 0
  1926. assert service.last_triage == {"signals": 1}
  1927. assert _cleared(emitted) == []
  1928. def test_reconnect_older_to_current_resets_once_without_rewind():
  1929. brief_file = FakeBriefFile()
  1930. service, emitted, clock, _, _ = _triage_service(brief_file=brief_file)
  1931. a, b = "transcripts/a", "transcripts/b"
  1932. service.handle_event(_session_event(clock, a))
  1933. service.last_triage = {"signals": 1}
  1934. emitted.clear()
  1935. _ring(
  1936. service,
  1937. clock,
  1938. _session_event(clock, a),
  1939. _transcript(clock, "old", session_dir=a),
  1940. _session_event(clock, b),
  1941. _transcript(clock, "new", session_dir=b),
  1942. )
  1943. assert service.status()["session_dir"] == b
  1944. assert brief_file.directories == [a, b]
  1945. assert service._triage_generation == 1
  1946. assert service.last_triage is None
  1947. assert len(_cleared(emitted)) == 1
  1948. def test_reconnect_only_newer_session_resets_once():
  1949. brief_file = FakeBriefFile()
  1950. service, _, clock, _, _ = _triage_service(brief_file=brief_file)
  1951. a, b = "transcripts/a", "transcripts/b"
  1952. service.handle_event(_session_event(clock, a))
  1953. service.last_triage = {"signals": 1}
  1954. _ring(service, clock, _transcript(clock, "new", session_dir=b))
  1955. assert service.status()["session_dir"] == b
  1956. assert service._triage_generation == 1
  1957. assert service.last_triage is None
  1958. assert brief_file.directories == [a, b]
  1959. def test_reconnect_span_older_current_clears_buffered_older_turns():
  1960. """A RING_END whose ring spanned an older session resets even when the
  1961. newest session already matches the adopted directory (no re-set_directory)."""
  1962. brief_file = FakeBriefFile()
  1963. service, emitted, clock, _, _ = _triage_service(brief_file=brief_file)
  1964. a, b = "transcripts/a", "transcripts/b"
  1965. _ring(service, clock, _session_event(clock, a))
  1966. assert service._triage_generation == 0
  1967. service.handle_event(_transcript(clock, "old turn", session_dir=a))
  1968. assert service._pending_brief == ["Unknown: old turn"]
  1969. service.handle_event(_session_event(clock, b))
  1970. assert service._triage_generation == 1
  1971. service.handle_event(_transcript(clock, "new turn", session_dir=b))
  1972. assert service._pending_brief == ["Unknown: new turn"]
  1973. emitted.clear()
  1974. _ring(
  1975. service,
  1976. clock,
  1977. _session_event(clock, a),
  1978. _transcript(clock, "old turn", session_dir=a),
  1979. _session_event(clock, b),
  1980. _transcript(clock, "new turn", session_dir=b),
  1981. )
  1982. assert service.status()["session_dir"] == b
  1983. assert brief_file.directories == [a, b]
  1984. assert service._pending_brief == []
  1985. assert service._triage_generation == 2
  1986. assert len(_cleared(emitted)) == 1
  1987. def test_daemon_restart_new_session_resets_once():
  1988. brief_file = FakeBriefFile()
  1989. service, _, clock, _, _ = _triage_service(brief_file=brief_file)
  1990. service.handle_event(_session_event(clock, "transcripts/a"))
  1991. service.last_triage = {"signals": 1}
  1992. service.handle_event(_session_event(clock, "transcripts/b"))
  1993. assert service.status()["session_dir"] == "transcripts/b"
  1994. assert service._triage_generation == 1
  1995. assert service.last_triage is None
  1996. assert brief_file.directories == ["transcripts/a", "transcripts/b"]