test_assistant_service.py 73 KB

12345678910111213141516171819202122232425262728293031323334353637383940414243444546474849505152535455565758596061626364656667686970717273747576777879808182838485868788899091929394959697989910010110210310410510610710810911011111211311411511611711811912012112212312412512612712812913013113213313413513613713813914014114214314414514614714814915015115215315415515615715815916016116216316416516616716816917017117217317417517617717817918018118218318418518618718818919019119219319419519619719819920020120220320420520620720820921021121221321421521621721821922022122222322422522622722822923023123223323423523623723823924024124224324424524624724824925025125225325425525625725825926026126226326426526626726826927027127227327427527627727827928028128228328428528628728828929029129229329429529629729829930030130230330430530630730830931031131231331431531631731831932032132232332432532632732832933033133233333433533633733833934034134234334434534634734834935035135235335435535635735835936036136236336436536636736836937037137237337437537637737837938038138238338438538638738838939039139239339439539639739839940040140240340440540640740840941041141241341441541641741841942042142242342442542642742842943043143243343443543643743843944044144244344444544644744844945045145245345445545645745845946046146246346446546646746846947047147247347447547647747847948048148248348448548648748848949049149249349449549649749849950050150250350450550650750850951051151251351451551651751851952052152252352452552652752852953053153253353453553653753853954054154254354454554654754854955055155255355455555655755855956056156256356456556656756856957057157257357457557657757857958058158258358458558658758858959059159259359459559659759859960060160260360460560660760860961061161261361461561661761861962062162262362462562662762862963063163263363463563663763863964064164264364464564664764864965065165265365465565665765865966066166266366466566666766866967067167267367467567667767867968068168268368468568668768868969069169269369469569669769869970070170270370470570670770870971071171271371471571671771871972072172272372472572672772872973073173273373473573673773873974074174274374474574674774874975075175275375475575675775875976076176276376476576676776876977077177277377477577677777877978078178278378478578678778878979079179279379479579679779879980080180280380480580680780880981081181281381481581681781881982082182282382482582682782882983083183283383483583683783883984084184284384484584684784884985085185285385485585685785885986086186286386486586686786886987087187287387487587687787887988088188288388488588688788888989089189289389489589689789889990090190290390490590690790890991091191291391491591691791891992092192292392492592692792892993093193293393493593693793893994094194294394494594694794894995095195295395495595695795895996096196296396496596696796896997097197297397497597697797897998098198298398498598698798898999099199299399499599699799899910001001100210031004100510061007100810091010101110121013101410151016101710181019102010211022102310241025102610271028102910301031103210331034103510361037103810391040104110421043104410451046104710481049105010511052105310541055105610571058105910601061106210631064106510661067106810691070107110721073107410751076107710781079108010811082108310841085108610871088108910901091109210931094109510961097109810991100110111021103110411051106110711081109111011111112111311141115111611171118111911201121112211231124112511261127112811291130113111321133113411351136113711381139114011411142114311441145114611471148114911501151115211531154115511561157115811591160116111621163116411651166116711681169117011711172117311741175117611771178117911801181118211831184118511861187118811891190119111921193119411951196119711981199120012011202120312041205120612071208120912101211121212131214121512161217121812191220122112221223122412251226122712281229123012311232123312341235123612371238123912401241124212431244124512461247124812491250125112521253125412551256125712581259126012611262126312641265126612671268126912701271127212731274127512761277127812791280128112821283128412851286128712881289129012911292129312941295129612971298129913001301130213031304130513061307130813091310131113121313131413151316131713181319132013211322132313241325132613271328132913301331133213331334133513361337133813391340134113421343134413451346134713481349135013511352135313541355135613571358135913601361136213631364136513661367136813691370137113721373137413751376137713781379138013811382138313841385138613871388138913901391139213931394139513961397139813991400140114021403140414051406140714081409141014111412141314141415141614171418141914201421142214231424142514261427142814291430143114321433143414351436143714381439144014411442144314441445144614471448144914501451145214531454145514561457145814591460146114621463146414651466146714681469147014711472147314741475147614771478147914801481148214831484148514861487148814891490149114921493149414951496149714981499150015011502150315041505150615071508150915101511151215131514151515161517151815191520152115221523152415251526152715281529153015311532153315341535153615371538153915401541154215431544154515461547154815491550155115521553155415551556155715581559156015611562156315641565156615671568156915701571157215731574157515761577157815791580158115821583158415851586158715881589159015911592159315941595159615971598159916001601160216031604160516061607160816091610161116121613161416151616161716181619162016211622162316241625162616271628162916301631163216331634163516361637163816391640164116421643164416451646164716481649165016511652165316541655165616571658165916601661166216631664166516661667166816691670167116721673167416751676167716781679168016811682168316841685168616871688168916901691169216931694169516961697169816991700170117021703170417051706170717081709171017111712171317141715171617171718171917201721172217231724172517261727172817291730173117321733173417351736173717381739174017411742174317441745174617471748174917501751175217531754175517561757175817591760176117621763176417651766176717681769177017711772177317741775177617771778177917801781178217831784178517861787178817891790179117921793179417951796179717981799180018011802180318041805180618071808180918101811181218131814181518161817181818191820182118221823182418251826182718281829183018311832183318341835183618371838183918401841184218431844184518461847184818491850185118521853185418551856185718581859186018611862186318641865186618671868186918701871187218731874187518761877187818791880188118821883188418851886188718881889189018911892189318941895189618971898189919001901190219031904190519061907190819091910191119121913191419151916191719181919192019211922192319241925192619271928192919301931193219331934193519361937193819391940194119421943194419451946194719481949195019511952195319541955195619571958195919601961196219631964196519661967196819691970197119721973197419751976197719781979198019811982198319841985198619871988198919901991199219931994199519961997199819992000200120022003200420052006200720082009201020112012201320142015201620172018201920202021202220232024202520262027202820292030203120322033203420352036203720382039204020412042204320442045204620472048204920502051205220532054205520562057205820592060206120622063206420652066206720682069207020712072207320742075207620772078207920802081208220832084208520862087208820892090209120922093209420952096209720982099210021012102210321042105210621072108210921102111211221132114211521162117211821192120212121222123212421252126212721282129213021312132213321342135213621372138213921402141214221432144214521462147214821492150215121522153215421552156215721582159216021612162216321642165216621672168216921702171217221732174217521762177217821792180218121822183218421852186218721882189219021912192219321942195219621972198
  1. """Tests for the assistant service (Phase 2) using synthetic event streams."""
  2. import itertools
  3. import json
  4. import re
  5. import threading
  6. import time
  7. from typing import Any
  8. from stt_daemon import events
  9. from stt_daemon.assistant.inference import InferenceJob, InferenceQueue
  10. from stt_daemon.assistant.service import EXECUTE_BUSY, AssistantService
  11. from stt_daemon.assistant.triage_dump import TriageDumper
  12. from stt_daemon.config import Config
  13. _sequence = itertools.count(1)
  14. class Clock:
  15. def __init__(self, start=1000.0):
  16. self.t = float(start)
  17. def __call__(self):
  18. return self.t
  19. def advance(self, dt):
  20. self.t += float(dt)
  21. class FakeSubscriber:
  22. def events(self):
  23. return iter(())
  24. def close(self):
  25. pass
  26. def _service():
  27. cfg = Config()
  28. clock = Clock()
  29. emitted: list[dict] = []
  30. def emit(type_, **fields):
  31. emitted.append({"type": type_, **fields})
  32. service = AssistantService(cfg, FakeSubscriber(), emit=emit, time_fn=clock)
  33. return service, emitted, clock
  34. def _ev(type_, clock, **fields):
  35. event = {"v": 1, "type": type_, "seq": next(_sequence), "ts": clock()}
  36. event.update(fields)
  37. return event
  38. def _transcript(clock, text, ts=None):
  39. return {
  40. "v": 1,
  41. "type": events.TRANSCRIPT,
  42. "seq": next(_sequence),
  43. "ts": clock() if ts is None else ts,
  44. "text": text,
  45. }
  46. def test_ready_requires_matching_segment_done():
  47. service, _, clock = _service()
  48. service.handle_event(_ev(events.SPEECH_START, clock))
  49. assert service.ready() is False
  50. service.handle_event(_ev(events.SPEECH_STOP, clock, seg_id=1))
  51. assert service.ready() is False # awaiting segment 1
  52. service.handle_event(_ev(events.SEGMENT_DONE, clock, seg_id=1, emitted=True))
  53. assert service.ready() is True
  54. def test_stale_segment_done_does_not_satisfy_later_turn():
  55. service, _, clock = _service()
  56. service.handle_event(_ev(events.SPEECH_STOP, clock, seg_id=1))
  57. service.handle_event(_ev(events.SPEECH_START, clock))
  58. service.handle_event(_ev(events.SPEECH_STOP, clock, seg_id=2))
  59. service.handle_event(_ev(events.SEGMENT_DONE, clock, seg_id=1, emitted=True))
  60. assert service.ready() is False # still awaiting segment 2
  61. service.handle_event(_ev(events.SEGMENT_DONE, clock, seg_id=2, emitted=True))
  62. assert service.ready() is True
  63. def test_gated_segment_done_clears_readiness():
  64. service, _, clock = _service()
  65. service.handle_event(_ev(events.SPEECH_STOP, clock, seg_id=3))
  66. service.handle_event(_ev(events.SEGMENT_DONE, clock, seg_id=3, emitted=False))
  67. assert service.ready() is True
  68. def test_speech_stop_without_seg_id_clears_readiness():
  69. """A discarded turn closes with speech_stop but no seg_id; readiness must recover."""
  70. service, _, clock = _service()
  71. service.handle_event(_ev(events.SPEECH_START, clock))
  72. assert service.ready() is False
  73. service.handle_event(_ev(events.SPEECH_STOP, clock)) # discarded: no seg_id
  74. assert service.speech_open is False
  75. assert service.awaited_seg_id is None
  76. assert service.ready() is True
  77. def test_status_resets_stale_speech_state_on_reconnect():
  78. service, _, clock = _service()
  79. service.handle_event(_ev(events.SPEECH_START, clock))
  80. assert service.speech_open is True
  81. service.handle_event(_ev(events.STATUS, clock, capture="x", segments_done=0))
  82. assert service.speech_open is False
  83. assert service.awaited_seg_id is None
  84. assert service.ready() is True
  85. def test_command_buffer_uses_arm_timestamp():
  86. service, _, clock = _service()
  87. clock.advance(10)
  88. assert service.arm() is True
  89. arm_ts = service.arm_ts
  90. assert arm_ts is not None
  91. # Replayed transcript from before arming is ignored.
  92. service.handle_event(_transcript(clock, "old", ts=arm_ts - 5))
  93. assert service.command_text == ""
  94. service.handle_event(_transcript(clock, "what time is it"))
  95. assert service.command_text == "what time is it"
  96. def test_mutual_exclusion_between_command_and_chat():
  97. service, _, _ = _service()
  98. assert service.toggle_chat() is True
  99. assert service.arm() is False # cannot arm in chat
  100. assert service.toggle_chat() is True # back to idle
  101. assert service.arm() is True
  102. assert service.toggle_chat() is False # cannot chat while armed
  103. def test_arm_timeout_disarms_and_emits_error():
  104. service, emitted, clock = _service()
  105. service.arm()
  106. clock.advance(service.cfg.assistant.command_arm_timeout_s + 0.1)
  107. service.tick()
  108. assert service.modes.mode.value == "idle"
  109. assert service.command_text == ""
  110. assert any(e["type"] == "error" and e["code"] == "arm_timeout" for e in emitted)
  111. def test_long_speech_does_not_disarm():
  112. service, emitted, clock = _service()
  113. service.arm()
  114. service.handle_event(_ev(events.SPEECH_START, clock))
  115. clock.advance(service.cfg.assistant.command_arm_timeout_s + 30.0)
  116. service.tick()
  117. assert service.modes.mode.value == "command_armed"
  118. assert not any(e["type"] == "error" for e in emitted)
  119. def test_captured_command_survives_arm_timeout():
  120. service, emitted, clock = _service()
  121. service.arm()
  122. service.handle_event(_transcript(clock, "what time is it"))
  123. service.handle_event(_ev(events.SPEECH_STOP, clock, seg_id=1))
  124. service.handle_event(_ev(events.SEGMENT_DONE, clock, seg_id=1, emitted=True))
  125. clock.advance(service.cfg.assistant.command_arm_timeout_s + 30.0)
  126. service.tick()
  127. assert service.modes.mode.value == "command_armed"
  128. assert service.command_text == "what time is it"
  129. assert not any(e["type"] == "error" for e in emitted)
  130. def test_stt_stall_cancels_armed_command():
  131. service, emitted, clock = _service()
  132. service.handle_event(_ev(events.HEARTBEAT, clock, worker_stall_s=0.0))
  133. service.arm()
  134. clock.advance(service.cfg.assistant.stall_timeout_ms / 1000.0 + 0.5)
  135. service.tick()
  136. assert service.modes.mode.value == "idle"
  137. assert any(e["type"] == "error" and e["code"] == "stt_stall" for e in emitted)
  138. def test_worker_stall_marks_stt_degraded():
  139. service, _, clock = _service()
  140. long_stall = service.cfg.assistant.worker_stall_ms / 1000.0 + 1.0
  141. service.handle_event(_ev(events.HEARTBEAT, clock, worker_stall_s=long_stall))
  142. assert service.stt_ok() is False
  143. assert service.ready() is False
  144. def test_chat_idle_timeout_exits_chat():
  145. service, _, clock = _service()
  146. assert service.toggle_chat() is True
  147. clock.advance(service.cfg.assistant.chat_idle_timeout_s + 0.1)
  148. service.tick()
  149. assert service.modes.mode.value == "idle"
  150. def test_chat_exit_phrase_exits_chat():
  151. service, _, clock = _service()
  152. assert service.toggle_chat() is True
  153. service.handle_event(_transcript(clock, "That's all."))
  154. assert service.modes.mode.value == "idle"
  155. assert service.chat_history == []
  156. def test_viewer_detached_exits_chat_and_forgets_history():
  157. service, _, clock = _service()
  158. assert service.toggle_chat() is True
  159. service.handle_event(_transcript(clock, "hello"))
  160. assert service.viewer_detached() is True
  161. assert service.modes.mode.value == "idle"
  162. assert service.chat_history == []
  163. def test_viewer_detached_is_noop_outside_chat():
  164. service, _, _ = _service()
  165. assert service.viewer_detached() is False
  166. assert service.modes.mode.value == "idle"
  167. def test_exit_chat_invokes_chat_reset():
  168. cfg = Config()
  169. resets: list[int] = []
  170. service = AssistantService(
  171. cfg, FakeSubscriber(), time_fn=Clock(), chat_reset=lambda: resets.append(1)
  172. )
  173. service.toggle_chat()
  174. service.viewer_detached()
  175. assert resets == [1]
  176. def test_chat_accumulates_turns():
  177. service, _, clock = _service()
  178. service.toggle_chat()
  179. for text in ("hello there", "how are you"):
  180. service.handle_event(_transcript(clock, text))
  181. assert service.chat_history == ["Unknown: hello there", "Unknown: how are you"]
  182. def test_execute_requires_readiness():
  183. service, _, clock = _service()
  184. service.arm()
  185. service.handle_event(_transcript(clock, "do it"))
  186. service.handle_event(_ev(events.SPEECH_START, clock))
  187. assert service.execute() is None # speech still open
  188. assert service.modes.mode.value == "command_armed"
  189. service.handle_event(_ev(events.SPEECH_STOP, clock, seg_id=1))
  190. assert service.execute() is None # awaiting segment 1
  191. service.handle_event(_ev(events.SEGMENT_DONE, clock, seg_id=1, emitted=True))
  192. assert service.execute() == "do it"
  193. assert service.modes.mode.value == "executing"
  194. assert service.finish() is True
  195. assert service.modes.mode.value == "idle"
  196. def test_execute_reports_busy_when_queue_rejects():
  197. service, emitted, clock = _service()
  198. # A zero-capacity lane rejects the priority command job on submit.
  199. service._inference = InferenceQueue(size=0)
  200. service.executor = object()
  201. service.arm()
  202. service.handle_event(_transcript(clock, "do it"))
  203. service.handle_event(_ev(events.SPEECH_STOP, clock, seg_id=1))
  204. service.handle_event(_ev(events.SEGMENT_DONE, clock, seg_id=1, emitted=True))
  205. assert service.execute() is EXECUTE_BUSY
  206. assert service.modes.mode.value == "idle"
  207. assert not any(e.get("code") == "busy" for e in emitted)
  208. def test_turn_ended_requires_quiet_gap():
  209. service, _, clock = _service()
  210. service.handle_event(_ev(events.SPEECH_STOP, clock, seg_id=1))
  211. service.handle_event(_ev(events.SEGMENT_DONE, clock, seg_id=1, emitted=True))
  212. assert service.ready() is True
  213. assert service.turn_ended() is False
  214. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  215. assert service.turn_ended() is True
  216. def test_emits_mode_and_command_text():
  217. service, emitted, clock = _service()
  218. service.arm()
  219. assert {"type": "mode", "mode": "command_armed"} in emitted
  220. service.handle_event(_transcript(clock, "hi"))
  221. assert any(e["type"] == "command_text" and e["text"] == "hi" for e in emitted)
  222. def test_cancel_clears_command_buffer():
  223. service, _, clock = _service()
  224. service.arm()
  225. service.handle_event(_transcript(clock, "hi"))
  226. assert service.cancel() is True
  227. assert service.modes.mode.value == "idle"
  228. assert service.command_text == ""
  229. assert service.arm_ts is None
  230. def test_pending_chat_is_not_lost_across_threads():
  231. """Transcripts appended on the reader thread while the ticker dispatches
  232. must all reach the model: the join-and-clear in _dispatch_chat is atomic,
  233. and the user bubble is emitted by the worker in _run_chat."""
  234. cfg = Config()
  235. cfg.assistant.turn_gap_s = 0.01
  236. dispatched: list[str] = []
  237. lock = threading.Lock()
  238. def emit(type_, **fields):
  239. if type_ == "chat_message" and fields.get("role") == "user":
  240. with lock:
  241. dispatched.append(fields["text"])
  242. service = AssistantService(cfg, FakeSubscriber(), emit=emit, chat_fn=lambda text: "ok")
  243. service.toggle_chat()
  244. service.start()
  245. try:
  246. total = 200
  247. producer = threading.Thread(
  248. target=lambda: [
  249. service.handle_event(
  250. {
  251. "v": 1,
  252. "type": events.TRANSCRIPT,
  253. "seq": i,
  254. "ts": time.time(),
  255. "text": f"w{i}",
  256. }
  257. )
  258. for i in range(total)
  259. ],
  260. daemon=True,
  261. )
  262. producer.start()
  263. deadline = time.time() + 10.0
  264. while time.time() < deadline:
  265. service.tick()
  266. with lock:
  267. words = sum(len(text.split()) for text in dispatched)
  268. done = words == 2 * total
  269. if not producer.is_alive() and done:
  270. break
  271. time.sleep(0.002)
  272. producer.join(timeout=5)
  273. with lock:
  274. words = sum(len(text.split()) for text in dispatched)
  275. assert words == 2 * total
  276. finally:
  277. service.stop()
  278. def _full_queue_service():
  279. service, emitted, clock = _service()
  280. service.toggle_chat()
  281. service._inference = InferenceQueue(size=1)
  282. service._inference.submit(
  283. InferenceJob(name="blocker", run=lambda: None, evictable=False)
  284. )
  285. return service, emitted, clock
  286. def test_chat_refusal_rebuffers_and_emits_queue_full_once():
  287. """A refused chat submit re-buffers under lock and emits queue_full on flip."""
  288. service, emitted, _ = _full_queue_service()
  289. service._pending_chat = ["hello world"]
  290. service._dispatch_chat()
  291. assert service._pending_chat == ["hello world"]
  292. assert service._chat_queue_full is True
  293. errors = [e for e in emitted if e["type"] == "error" and e.get("code") == "queue_full"]
  294. assert len(errors) == 1
  295. assert [e for e in emitted if e["type"] == "chat_message"] == []
  296. service._dispatch_chat()
  297. assert service._pending_chat == ["hello world"]
  298. errors = [e for e in emitted if e["type"] == "error" and e.get("code") == "queue_full"]
  299. assert len(errors) == 1
  300. def test_chat_dispatch_success_clears_latch_without_user_bubble():
  301. """Success clears the latch; the user bubble comes from _run_chat, not dispatch."""
  302. service, emitted, _ = _full_queue_service()
  303. service._pending_chat = ["hello world"]
  304. service._chat_queue_full = True
  305. service._inference.drop(lambda j: True)
  306. service._dispatch_chat()
  307. assert service._pending_chat == []
  308. assert service._chat_queue_full is False
  309. assert [e for e in emitted if e["type"] == "chat_message"] == []
  310. def test_run_chat_emits_user_first_then_reply():
  311. service, emitted, _ = _service()
  312. service.chat_fn = lambda text: "reply!"
  313. service._run_chat("hello")
  314. assert emitted == [
  315. {"type": "chat_message", "role": "user", "text": "hello"},
  316. {"type": "chat_message", "role": "assistant", "text": "reply!"},
  317. ]
  318. def test_chat_notify_emits_compaction_note():
  319. service, emitted, _ = _service()
  320. service.chat_notify("compacted", turns=4)
  321. assert {
  322. "type": "chat_message",
  323. "role": "note",
  324. "text": "Compacted 4 earlier turns into a summary.",
  325. } in emitted
  326. def test_chat_notify_emits_truncated_error():
  327. service, emitted, _ = _service()
  328. service.chat_notify("truncated", message="cut off")
  329. assert {"type": "error", "code": "truncated", "message": "cut off"} in emitted
  330. def test_clear_empties_chat_history():
  331. service, emitted, clock = _service()
  332. service.toggle_chat()
  333. for text in ("hello", "how are you"):
  334. service.handle_event(_transcript(clock, text))
  335. assert service.chat_history == ["Unknown: hello", "Unknown: how are you"]
  336. assert len(service._pending_chat) == 2
  337. assert service.clear() is True
  338. assert service.chat_history == []
  339. assert service._pending_chat == []
  340. assert {"type": "cleared"} in emitted
  341. def test_clear_invokes_chat_reset():
  342. cfg = Config()
  343. resets: list[int] = []
  344. service = AssistantService(
  345. cfg, FakeSubscriber(), time_fn=Clock(), chat_reset=lambda: resets.append(1)
  346. )
  347. service.toggle_chat()
  348. service.clear()
  349. assert resets == [1]
  350. def test_clear_does_not_change_mode():
  351. service, _, clock = _service()
  352. service.toggle_chat()
  353. assert service.modes.mode.value == "chat"
  354. service.clear()
  355. assert service.modes.mode.value == "chat"
  356. def test_clear_always_returns_true():
  357. service, _, _ = _service()
  358. assert service.clear() is True
  359. service.toggle_chat()
  360. service.handle_event(_ev(events.TRANSCRIPT, Clock(), text="test"))
  361. assert service.clear() is True
  362. def test_heartbeat_emits_inference_depth_and_in_flight():
  363. """Calling tick() emits heartbeat with inference_depth (int) and inference_in_flight (bool)."""
  364. service, emitted, clock = _service()
  365. service.tick()
  366. heartbeats = [e for e in emitted if e["type"] == "heartbeat"]
  367. assert len(heartbeats) == 1
  368. heartbeat = heartbeats[0]
  369. assert "inference_depth" in heartbeat
  370. assert isinstance(heartbeat["inference_depth"], int)
  371. assert "inference_in_flight" in heartbeat
  372. assert isinstance(heartbeat["inference_in_flight"], bool)
  373. def test_status_contains_inference_depth_and_in_flight():
  374. """status() snapshot contains inference_depth (int) and inference_in_flight (bool)."""
  375. service, _, _ = _service()
  376. status = service.status()
  377. assert "inference_depth" in status
  378. assert isinstance(status["inference_depth"], int)
  379. assert "inference_in_flight" in status
  380. assert isinstance(status["inference_in_flight"], bool)
  381. _AUTO = object()
  382. class FakeTriage:
  383. def __init__(
  384. self,
  385. questions=_AUTO,
  386. state_pair=("ok", ""),
  387. escalate=False,
  388. parsed=_AUTO,
  389. normalized=_AUTO,
  390. gate=True,
  391. ):
  392. if questions is _AUTO:
  393. questions = {"urgency": {"type": "noul", "instructions": "how urgent"}}
  394. self._questions = questions
  395. self._state_pair = state_pair
  396. self._escalate = escalate
  397. self._parsed = parsed
  398. self._normalized = normalized
  399. self._gate = gate
  400. self.build_state_calls: list[tuple] = []
  401. self.normalize_calls: list = []
  402. self.prompt_calls: list[tuple] = []
  403. self.gate_calls: list = []
  404. @property
  405. def questions(self):
  406. return self._questions
  407. def state(self):
  408. return self._state_pair
  409. def build_state(self, window):
  410. self.build_state_calls.append(tuple(window))
  411. return "\n".join("- " + str(item) for item in (window or []))
  412. def normalize(self, payload):
  413. self.normalize_calls.append(payload)
  414. if self._normalized is not _AUTO:
  415. return self._normalized
  416. if not isinstance(payload, dict):
  417. return {}
  418. signals = {"order": [], "items": {}, "escalated": False, "input_tokens": 0}
  419. signals.update(payload)
  420. if self._escalate:
  421. signals["escalated"] = True
  422. return signals
  423. def build_brief_prompt(self, deltas, signals):
  424. self.prompt_calls.append(
  425. (tuple(deltas), dict(signals) if isinstance(signals, dict) else signals)
  426. )
  427. return "BRIEF-PROMPT"
  428. def parse_brief(self, text):
  429. if self._parsed is _AUTO:
  430. return text if text else None
  431. return self._parsed
  432. def should_update_brief(self, signals):
  433. self.gate_calls.append(signals)
  434. return self._gate
  435. class FakeBriefFile:
  436. """Recording stand-in for BriefFile (write/clear never raise)."""
  437. def __init__(self):
  438. self.writes: list[str] = []
  439. self.clears = 0
  440. def write(self, text):
  441. self.writes.append(text)
  442. def clear(self):
  443. self.clears += 1
  444. class FakeLane:
  445. def __init__(self, ready=True):
  446. self._ready = ready
  447. self.submits: list[tuple] = []
  448. self.drops = 0
  449. self.predict_gate = threading.Event()
  450. def ready(self):
  451. return self._ready
  452. def state(self):
  453. return ("ok", "") if self._ready else ("loading", "")
  454. def submit(self, state, questions, lang, generation):
  455. self.submits.append((state, questions, lang, generation))
  456. return True
  457. def drop_pending(self):
  458. self.drops += 1
  459. def _ok_reply(text):
  460. return "ok"
  461. def _triage_service(
  462. triage=None,
  463. lane=None,
  464. brief_fn=None,
  465. chat_fn: Any = _AUTO,
  466. brief_file=None,
  467. brief_reset=None,
  468. chat_reset=None,
  469. ):
  470. cfg = Config()
  471. cfg.assistant.turn_gap_s = 0.5
  472. clock = Clock()
  473. emitted: list[dict] = []
  474. def emit(type_, **fields):
  475. emitted.append({"type": type_, **fields})
  476. if triage is None:
  477. triage = FakeTriage()
  478. if lane is None:
  479. lane = FakeLane()
  480. if chat_fn is _AUTO:
  481. chat_fn = _ok_reply
  482. service = AssistantService(
  483. cfg,
  484. FakeSubscriber(),
  485. emit=emit,
  486. time_fn=clock,
  487. triage=triage,
  488. laya_lane=lane,
  489. brief_fn=brief_fn,
  490. brief_reset=brief_reset,
  491. brief_file=brief_file,
  492. chat_fn=chat_fn,
  493. chat_reset=chat_reset,
  494. )
  495. return service, emitted, clock, triage, lane
  496. def _triage_events(emitted):
  497. return [e for e in emitted if e["type"] == "triage"]
  498. def _escalated_payload():
  499. return {"order": [], "items": {}, "escalated": True, "input_tokens": 3}
  500. def test_triage_status_disabled_when_no_analyzer():
  501. service, _, _ = _service()
  502. status = service.status()
  503. assert status["triage_state"] == "disabled"
  504. assert status["triage_reason"] == ""
  505. assert status["triage"] is None
  506. def test_triage_status_reflects_analyzer():
  507. service, _, _, _, _ = _triage_service(
  508. triage=FakeTriage(state_pair=("loading", "warming up"))
  509. )
  510. status = service.status()
  511. assert status["triage_state"] == "loading"
  512. assert status["triage_reason"] == "warming up"
  513. assert status["triage"] is None
  514. def test_status_contains_questions_from_analyzer():
  515. questions = {
  516. "urgency": {"type": "noul", "instructions": "how urgent"},
  517. "sentiment": {"type": "score", "instructions": "tone", "criteria": ["low", "high"]},
  518. }
  519. service, _, _, triage, _ = _triage_service(triage=FakeTriage(questions=questions))
  520. status = service.status()
  521. assert status["questions"] == questions
  522. assert status["questions"] is triage.questions
  523. def test_status_questions_none_without_analyzer():
  524. service, _, _ = _service()
  525. assert service.status()["questions"] is None
  526. def test_status_event_carries_questions():
  527. service, emitted, _, triage, _ = _triage_service()
  528. service.tick()
  529. statuses = [e for e in emitted if e["type"] == "status"]
  530. assert len(statuses) == 1
  531. assert statuses[0]["questions"] is triage.questions
  532. def test_triage_captures_transcript_lang():
  533. service, _, clock, _, _ = _triage_service()
  534. assert service._last_transcript_lang is None
  535. event = _transcript(clock, "hola")
  536. event["lang"] = "es"
  537. service.handle_event(event)
  538. assert service._last_transcript_lang == "es"
  539. service.handle_event(_transcript(clock, "hello"))
  540. assert service._last_transcript_lang is None
  541. def test_maybe_triage_passes_lang_to_lane():
  542. service, _, clock, _, lane = _triage_service()
  543. event = _transcript(clock, "hola")
  544. event["lang"] = "es"
  545. service.handle_event(event)
  546. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  547. service.tick()
  548. assert len(lane.submits) == 1
  549. _, _, lang, _ = lane.submits[0]
  550. assert lang == "es"
  551. def test_maybe_triage_runs_in_idle_mode():
  552. service, _, clock, triage, lane = _triage_service()
  553. service.handle_event(_transcript(clock, "hello"))
  554. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  555. service.tick()
  556. assert len(lane.submits) == 1
  557. state, questions, lang, gen = lane.submits[0]
  558. assert state == "- hello"
  559. assert questions is triage.questions
  560. assert lang is None
  561. assert gen == 0
  562. assert triage.build_state_calls == [("hello",)]
  563. assert service.triage_history == ["hello"]
  564. def test_maybe_triage_uses_transcript_buffer_not_chat_history():
  565. service, _, clock, triage, lane = _triage_service(chat_fn=None)
  566. service.chat_history = ["stale chat only"]
  567. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  568. service.tick()
  569. assert lane.submits == []
  570. assert triage.build_state_calls == []
  571. service.handle_event(_transcript(clock, "hello"))
  572. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  573. service.tick()
  574. assert len(lane.submits) == 1
  575. assert triage.build_state_calls == [("hello",)]
  576. def test_maybe_triage_requires_settled_turn():
  577. service, _, clock, _, lane = _triage_service()
  578. service.handle_event(_transcript(clock, "hello"))
  579. service.tick()
  580. assert lane.submits == []
  581. def test_maybe_triage_skips_unready_lane():
  582. service, _, clock, _, lane = _triage_service(lane=FakeLane(ready=False))
  583. service.handle_event(_transcript(clock, "hello"))
  584. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  585. service.tick()
  586. assert lane.submits == []
  587. def test_maybe_triage_skips_without_questions():
  588. service, _, clock, triage, lane = _triage_service(
  589. triage=FakeTriage(questions=None)
  590. )
  591. service.handle_event(_transcript(clock, "hello"))
  592. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  593. service.tick()
  594. assert lane.submits == []
  595. assert triage.build_state_calls == []
  596. def test_maybe_triage_dedupes_identical_window():
  597. service, _, clock, triage, lane = _triage_service()
  598. service.handle_event(_transcript(clock, "hello"))
  599. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  600. service.tick()
  601. assert len(lane.submits) == 1
  602. state, questions, lang, gen = lane.submits[0]
  603. assert state == "- hello"
  604. assert questions is triage.questions
  605. assert lang is None
  606. assert gen == 0
  607. service.tick()
  608. service.tick()
  609. assert len(lane.submits) == 1
  610. service.handle_event(_transcript(clock, "second"))
  611. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  612. service.tick()
  613. assert len(lane.submits) == 2
  614. assert lane.submits[1][0] == "- hello\n- second"
  615. def test_second_transcript_produces_second_submit():
  616. service, _, clock, _, lane = _triage_service()
  617. service.handle_event(_transcript(clock, "first"))
  618. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  619. service.tick()
  620. assert len(lane.submits) == 1
  621. service.handle_event(_transcript(clock, "second"))
  622. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  623. service.tick()
  624. assert len(lane.submits) == 2
  625. assert lane.submits[1][0] == "- first\n- second"
  626. def test_tick_under_50ms_with_blocked_lane():
  627. service, _, clock, _, lane = _triage_service()
  628. assert not lane.predict_gate.is_set()
  629. service.toggle_chat()
  630. service.handle_event(_transcript(clock, "hello"))
  631. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  632. start = time.perf_counter()
  633. service.tick()
  634. elapsed = time.perf_counter() - start
  635. assert len(lane.submits) == 1
  636. assert elapsed < 0.05
  637. def test_on_triage_result_emits_signals():
  638. service, emitted, clock, _, lane = _triage_service()
  639. service.toggle_chat()
  640. service.handle_event(_transcript(clock, "hello"))
  641. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  642. service.tick()
  643. _, _, _, gen = lane.submits[0]
  644. payload = {
  645. "order": ["urgency"],
  646. "items": {"urgency": {"kind": "noul"}},
  647. "escalated": False,
  648. "input_tokens": 12,
  649. }
  650. service._on_triage_result(gen, payload)
  651. staged = _triage_events(emitted)
  652. assert len(staged) == 1
  653. assert staged[0]["stage"] == "signals"
  654. assert staged[0]["triage"] == service.last_triage
  655. assert staged[0]["triage"]["escalated"] is False
  656. assert staged[0]["triage"]["input_tokens"] == 12
  657. assert service.status()["triage"] == service.last_triage
  658. def test_triage_events_carry_the_server_timestamp():
  659. service, emitted, clock, _, lane = _triage_service(brief_fn=lambda prompt: "RAW")
  660. service.toggle_chat()
  661. service.handle_event(_transcript(clock, "hello"))
  662. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  663. service.tick()
  664. _, _, _, gen = lane.submits[0]
  665. expected_ts = clock()
  666. service._on_triage_result(gen, _escalated_payload())
  667. signals = [e for e in _triage_events(emitted) if e.get("stage") == "signals"]
  668. assert len(signals) == 1
  669. assert isinstance(signals[0]["ts"], (int, float))
  670. assert signals[0]["ts"] == expected_ts
  671. job = [j for j in service._inference._queue if j.name == "brief-update"][0]
  672. job.run()
  673. contents = [e for e in _triage_events(emitted) if e.get("stage") == "content"]
  674. assert len(contents) == 1
  675. assert isinstance(contents[0]["ts"], (int, float))
  676. assert contents[0]["ts"] == expected_ts # content reuses the signals timestamp
  677. def test_on_triage_result_suppresses_stale_generation():
  678. service, emitted, clock, _, lane = _triage_service()
  679. service.toggle_chat()
  680. service.handle_event(_transcript(clock, "hello"))
  681. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  682. service.tick()
  683. _, _, _, gen = lane.submits[0]
  684. service.clear()
  685. service._on_triage_result(gen, _escalated_payload())
  686. assert service.last_triage is None
  687. assert [e for e in _triage_events(emitted) if e.get("stage") == "signals"] == []
  688. service.handle_event(_transcript(clock, "hello"))
  689. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  690. service.tick()
  691. assert len(lane.submits) == 2
  692. def test_pending_brief_capped_by_char_budget():
  693. """The buffer keeps the newest deltas within budget, dropping the oldest."""
  694. service, _, clock, _, _ = _triage_service(brief_fn=lambda prompt: "RAW")
  695. service.cfg.triage.brief_pending_char_budget = 30
  696. service.handle_event(_transcript(clock, "aaa"))
  697. service.handle_event(_transcript(clock, "bbbb"))
  698. assert service._pending_brief == ["Unknown: aaa", "Unknown: bbbb"]
  699. service.handle_event(_transcript(clock, "ccccc"))
  700. assert service._pending_brief == ["Unknown: bbbb", "Unknown: ccccc"]
  701. assert service.triage_history == ["aaa", "bbbb", "ccccc"]
  702. def test_pending_brief_untouched_without_triage():
  703. service, _, clock = _service()
  704. service.handle_event(_transcript(clock, "hello"))
  705. assert service._pending_brief == []
  706. assert service.triage_history == ["hello"]
  707. def test_on_triage_result_accepts_non_chat_mode():
  708. service, emitted, clock, _, lane = _triage_service()
  709. service.handle_event(_transcript(clock, "hello"))
  710. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  711. service.tick()
  712. _, _, _, gen = lane.submits[0]
  713. window = service._last_triage_window
  714. service._on_triage_result(gen, _escalated_payload())
  715. assert service.last_triage is not None
  716. assert service._last_triage_window == window
  717. assert [e.get("stage") for e in _triage_events(emitted)] == ["signals"]
  718. def test_on_triage_result_ignores_none_payload():
  719. service, emitted, clock, _, lane = _triage_service()
  720. service.toggle_chat()
  721. service.handle_event(_transcript(clock, "hello"))
  722. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  723. service.tick()
  724. _, _, _, gen = lane.submits[0]
  725. service._on_triage_result(gen, None)
  726. assert service.last_triage is None
  727. assert _triage_events(emitted) == []
  728. def test_none_payload_dispatches_nothing_and_keeps_deltas():
  729. """A Laya predict failure never dispatches: no job, no events, deltas stay."""
  730. calls: list[str] = []
  731. service, emitted, clock, _, lane = _triage_service(
  732. brief_fn=lambda prompt: calls.append(prompt) or "RAW"
  733. )
  734. service.toggle_chat()
  735. service.handle_event(_transcript(clock, "hello"))
  736. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  737. service.tick()
  738. _, _, _, gen = lane.submits[0]
  739. assert service._pending_brief == ["Unknown: hello"]
  740. service._on_triage_result(gen, None)
  741. assert service.last_triage is None
  742. assert [e.get("stage") for e in _triage_events(emitted)] == []
  743. assert [j.name for j in service._inference._queue] == ["chat"]
  744. assert calls == []
  745. assert service._pending_brief == ["Unknown: hello"]
  746. assert service._brief_outstanding is False
  747. def test_none_payload_without_brief_fn_enqueues_nothing():
  748. service, emitted, clock, _, lane = _triage_service()
  749. service.toggle_chat()
  750. service.handle_event(_transcript(clock, "hello"))
  751. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  752. service.tick()
  753. _, _, _, gen = lane.submits[0]
  754. service._on_triage_result(gen, None)
  755. assert service.last_triage is None
  756. assert _triage_events(emitted) == []
  757. assert [j.name for j in service._inference._queue] == ["chat"]
  758. assert service._pending_brief == ["Unknown: hello"]
  759. def test_on_triage_result_ignores_empty_signals():
  760. service, emitted, clock, _, lane = _triage_service(
  761. triage=FakeTriage(normalized={})
  762. )
  763. service.toggle_chat()
  764. service.handle_event(_transcript(clock, "hello"))
  765. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  766. service.tick()
  767. _, _, _, gen = lane.submits[0]
  768. service._on_triage_result(gen, _escalated_payload())
  769. assert service.last_triage is None
  770. assert _triage_events(emitted) == []
  771. def test_substantive_turn_dispatches_one_brief_job():
  772. """A substantive settled turn calls the gate once and queues one brief job."""
  773. service, emitted, clock, triage, lane = _triage_service(
  774. triage=FakeTriage(escalate=True), brief_fn=lambda prompt: "RAW"
  775. )
  776. service.toggle_chat()
  777. service.handle_event(_transcript(clock, "we might churn"))
  778. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  779. service.tick()
  780. _, _, _, gen = lane.submits[0]
  781. service._on_triage_result(
  782. gen, {"order": [], "items": {}, "escalated": False, "input_tokens": 0}
  783. )
  784. assert service.last_triage is not None
  785. assert service.last_triage["escalated"] is True
  786. assert service._last_brief_signals == service.last_triage
  787. assert service._inference.depth() == 2
  788. assert [j.name for j in service._inference._queue] == ["chat", "brief-update"]
  789. assert [e.get("stage") for e in _triage_events(emitted)] == ["signals"]
  790. assert len(triage.gate_calls) == 1
  791. assert service._brief_outstanding is True
  792. assert service._brief_token == 1
  793. def test_brief_dispatches_without_escalation():
  794. service, _, clock, _, lane = _triage_service(brief_fn=lambda prompt: "RAW")
  795. service.toggle_chat()
  796. service.handle_event(_transcript(clock, "all calm"))
  797. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  798. service.tick()
  799. _, _, _, gen = lane.submits[0]
  800. service._on_triage_result(
  801. gen, {"order": [], "items": {}, "escalated": False, "input_tokens": 0}
  802. )
  803. assert service.last_triage is not None
  804. assert service._inference.depth() == 2
  805. assert [j.name for j in service._inference._queue] == ["chat", "brief-update"]
  806. def test_gated_out_turn_skips_brief():
  807. """A gated-out turn stores signals but never calls brief_fn."""
  808. calls: list[str] = []
  809. service, emitted, clock, triage, lane = _triage_service(
  810. triage=FakeTriage(gate=False),
  811. brief_fn=lambda prompt: calls.append(prompt) or "RAW",
  812. )
  813. service.toggle_chat()
  814. service.handle_event(_transcript(clock, "small talk"))
  815. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  816. service.tick()
  817. _, _, _, gen = lane.submits[0]
  818. service._on_triage_result(gen, _escalated_payload())
  819. assert service.last_triage is not None
  820. assert "brief" not in service.last_triage # no prior brief to retain
  821. assert [e.get("stage") for e in _triage_events(emitted)] == ["signals"]
  822. assert calls == []
  823. assert [j.name for j in service._inference._queue] == ["chat"]
  824. assert service._brief_outstanding is False
  825. assert len(triage.gate_calls) == 1
  826. def test_gated_out_turn_retains_previous_brief():
  827. """A gated-out settled turn keeps the last accepted brief in the panel."""
  828. service, emitted, clock, triage, lane = _triage_service(
  829. triage=FakeTriage(gate=False), brief_fn=lambda prompt: "RAW"
  830. )
  831. service.toggle_chat()
  832. signals = _escalated_payload()
  833. service._last_brief_signals = signals
  834. token = _seed_brief(service, "Unknown: first")
  835. service._run_brief_update(0, signals, service._now(), token)
  836. assert service.last_triage is not None
  837. assert service.last_triage["brief"] == "RAW"
  838. emitted.clear()
  839. service.handle_event(_transcript(clock, "small talk"))
  840. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  841. service.tick()
  842. _, _, _, gen = lane.submits[0]
  843. service._on_triage_result(gen, _escalated_payload())
  844. assert service.last_triage is not None
  845. assert service.last_triage["brief"] == "RAW"
  846. assert "brief" not in service._last_brief_signals # raw signals stay raw
  847. staged = [e for e in _triage_events(emitted) if e.get("stage") == "signals"]
  848. assert len(staged) == 1
  849. assert staged[0]["triage"] == service.last_triage
  850. assert staged[0]["triage"]["brief"] == "RAW"
  851. assert len(triage.gate_calls) == 1
  852. def test_gated_out_turn_retains_brief_when_extract_disabled():
  853. """`extract_enabled = false` skips the dispatch but still retains the brief."""
  854. service, emitted, clock, _, lane = _triage_service(
  855. triage=FakeTriage(gate=False), brief_fn=lambda prompt: "RAW"
  856. )
  857. service.toggle_chat()
  858. signals = _escalated_payload()
  859. service._last_brief_signals = signals
  860. token = _seed_brief(service, "Unknown: first")
  861. service._run_brief_update(0, signals, service._now(), token)
  862. assert service.last_triage is not None
  863. assert service.last_triage["brief"] == "RAW"
  864. service.cfg.triage.extract_enabled = False
  865. emitted.clear()
  866. service.handle_event(_transcript(clock, "small talk"))
  867. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  868. service.tick()
  869. _, _, _, gen = lane.submits[0]
  870. service._on_triage_result(gen, _escalated_payload())
  871. assert service.last_triage is not None
  872. assert service.last_triage["brief"] == "RAW"
  873. assert [j.name for j in service._inference._queue] == ["chat"]
  874. staged = [e for e in _triage_events(emitted) if e.get("stage") == "signals"]
  875. assert staged[0]["triage"]["brief"] == "RAW"
  876. def test_gated_out_turn_retains_brief_without_brief_fn():
  877. """No brief_fn means no dispatch, but a retained brief is still carried."""
  878. service, emitted, clock, _, lane = _triage_service(triage=FakeTriage(gate=False))
  879. service.toggle_chat()
  880. service.last_triage = {**_escalated_payload(), "brief": "KEEP"}
  881. emitted.clear()
  882. service.handle_event(_transcript(clock, "small talk"))
  883. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  884. service.tick()
  885. _, _, _, gen = lane.submits[0]
  886. service._on_triage_result(gen, _escalated_payload())
  887. assert service.last_triage["brief"] == "KEEP"
  888. staged = [e for e in _triage_events(emitted) if e.get("stage") == "signals"]
  889. assert staged[0]["triage"]["brief"] == "KEEP"
  890. def test_later_accepted_update_replaces_retained_brief():
  891. """A later accepted update overwrites the retained brief text."""
  892. texts = iter(["OLD", "NEW"])
  893. service, emitted, _, _, _ = _triage_service(brief_fn=lambda prompt: next(texts))
  894. service.toggle_chat()
  895. signals = _escalated_payload()
  896. service._last_brief_signals = signals
  897. token = _seed_brief(service, "Unknown: first")
  898. service._run_brief_update(0, signals, service._now(), token)
  899. assert service.last_triage is not None
  900. assert service.last_triage["brief"] == "OLD"
  901. token = _seed_brief(service, "Unknown: second")
  902. service._run_brief_update(0, signals, service._now(), token)
  903. assert service.last_triage is not None
  904. assert service.last_triage["brief"] == "NEW"
  905. contents = [e for e in _triage_events(emitted) if e.get("stage") == "content"]
  906. assert contents[-1]["triage"]["brief"] == "NEW"
  907. service.clear()
  908. assert service.last_triage is None
  909. def test_no_brief_when_disabled_in_config():
  910. calls: list[str] = []
  911. service, _, clock, _, lane = _triage_service(
  912. triage=FakeTriage(escalate=True),
  913. brief_fn=lambda prompt: calls.append(prompt) or "RAW",
  914. )
  915. service.cfg.triage.extract_enabled = False
  916. service.toggle_chat()
  917. service.handle_event(_transcript(clock, "churn risk"))
  918. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  919. service.tick()
  920. _, _, _, gen = lane.submits[0]
  921. service._on_triage_result(gen, _escalated_payload())
  922. assert service.last_triage is not None
  923. assert service.last_triage["escalated"] is True
  924. assert calls == []
  925. assert [j.name for j in service._inference._queue] == ["chat"]
  926. def test_no_brief_without_brief_fn():
  927. service, _, clock, _, lane = _triage_service(triage=FakeTriage(escalate=True))
  928. service.toggle_chat()
  929. service.handle_event(_transcript(clock, "churn risk"))
  930. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  931. service.tick()
  932. _, _, _, gen = lane.submits[0]
  933. service._on_triage_result(gen, _escalated_payload())
  934. assert service.last_triage is not None
  935. assert [j.name for j in service._inference._queue] == ["chat"]
  936. assert service._brief_outstanding is False
  937. def test_brief_refused_when_queue_full():
  938. """A refused submit leaves deltas buffered and the outstanding flag clear."""
  939. service, emitted, clock, _, lane = _triage_service(
  940. triage=FakeTriage(escalate=True), brief_fn=lambda prompt: "RAW"
  941. )
  942. service._inference = InferenceQueue(size=2)
  943. service.toggle_chat()
  944. service.handle_event(_transcript(clock, "churn risk"))
  945. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  946. service.tick()
  947. assert service._inference.depth() == 1
  948. _, _, _, gen = lane.submits[0]
  949. service._on_triage_result(gen, _escalated_payload())
  950. assert service._inference.depth() == 1
  951. assert service._inference._queue[0].name == "chat"
  952. assert service.last_triage is not None
  953. assert service.last_triage["escalated"] is True
  954. assert [e.get("stage") for e in _triage_events(emitted)] == ["signals"]
  955. assert service._pending_brief == ["Unknown: churn risk"]
  956. assert service._brief_outstanding is False
  957. def test_second_result_while_outstanding_is_refused():
  958. """At most one brief job is outstanding: the second turn only stores signals."""
  959. service, emitted, clock, _, lane = _triage_service(brief_fn=lambda prompt: "RAW")
  960. service.toggle_chat()
  961. service.handle_event(_transcript(clock, "first"))
  962. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  963. service.tick()
  964. _, _, _, gen0 = lane.submits[0]
  965. service._on_triage_result(gen0, _escalated_payload())
  966. assert [j.name for j in service._inference._queue] == ["chat", "brief-update"]
  967. service.handle_event(_transcript(clock, "second"))
  968. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  969. service.tick()
  970. _, _, _, gen1 = lane.submits[1]
  971. service._on_triage_result(gen1, _escalated_payload())
  972. jobs = [j for j in service._inference._queue if j.name == "brief-update"]
  973. assert len(jobs) == 1
  974. assert [e.get("stage") for e in _triage_events(emitted)] == ["signals", "signals"]
  975. assert service._brief_outstanding is True
  976. assert service._pending_brief == ["Unknown: first", "Unknown: second"]
  977. def _seed_brief(service, *deltas):
  978. service._pending_brief = list(deltas)
  979. service._brief_outstanding = True
  980. return service._brief_token
  981. def test_brief_merges_content_and_writes_file():
  982. brief_file = FakeBriefFile()
  983. service, emitted, _, triage, _ = _triage_service(
  984. brief_fn=lambda prompt: "the brief", brief_file=brief_file
  985. )
  986. service.toggle_chat()
  987. signals = _escalated_payload()
  988. service._last_brief_signals = signals
  989. token = _seed_brief(service, "Unknown: hello")
  990. ts = service._now()
  991. service._run_brief_update(0, signals, ts, token)
  992. contents = [e for e in _triage_events(emitted) if e.get("stage") == "content"]
  993. assert len(contents) == 1
  994. assert contents[0]["triage"] == {**signals, "brief": "the brief"}
  995. assert service.last_triage == contents[0]["triage"]
  996. assert triage.prompt_calls == [(("Unknown: hello",), signals)]
  997. assert brief_file.writes == ["the brief"]
  998. assert service._pending_brief == []
  999. assert service._brief_outstanding is False
  1000. def test_empty_brief_requeues_deltas():
  1001. """A `""` reply keeps signals, re-buffers the deltas, and clears the flag."""
  1002. service, emitted, _, _, _ = _triage_service(brief_fn=lambda prompt: "")
  1003. service.toggle_chat()
  1004. signals = _escalated_payload()
  1005. service.last_triage = signals
  1006. service._last_brief_signals = signals
  1007. token = _seed_brief(service, "Unknown: hello")
  1008. ts = service._now()
  1009. service._run_brief_update(0, signals, ts, token)
  1010. assert [e for e in _triage_events(emitted) if e.get("stage") == "content"] == []
  1011. assert service.last_triage == signals
  1012. assert "brief" not in service.last_triage
  1013. assert service._pending_brief == ["Unknown: hello"]
  1014. assert service._brief_outstanding is False
  1015. def test_brief_error_requeues_and_clears_flag():
  1016. """A raising brief_fn leaves the flag clear and the deltas buffered."""
  1017. def boom(prompt):
  1018. raise RuntimeError("llm down")
  1019. service, emitted, _, _, _ = _triage_service(brief_fn=boom)
  1020. service.toggle_chat()
  1021. token = _seed_brief(service, "Unknown: hello")
  1022. ts = service._now()
  1023. service._run_brief_update(0, _escalated_payload(), ts, token)
  1024. assert _triage_events(emitted) == []
  1025. assert service.last_triage is None
  1026. assert service._pending_brief == ["Unknown: hello"]
  1027. assert service._brief_outstanding is False
  1028. def test_brief_empty_buffer_returns_early():
  1029. """An empty buffer returns early: no call, no event, flag cleared."""
  1030. calls: list[str] = []
  1031. service, emitted, _, _, _ = _triage_service(
  1032. brief_fn=lambda prompt: calls.append(prompt) or "RAW"
  1033. )
  1034. service.toggle_chat()
  1035. service._brief_outstanding = True
  1036. token = service._brief_token
  1037. ts = service._now()
  1038. assert service._pending_brief == []
  1039. service._run_brief_update(0, _escalated_payload(), ts, token)
  1040. assert calls == []
  1041. assert _triage_events(emitted) == []
  1042. assert service._brief_outstanding is False
  1043. def test_brief_suppressed_after_reset():
  1044. service, emitted, _, _, _ = _triage_service(brief_fn=lambda prompt: "RAW")
  1045. service.toggle_chat()
  1046. service._pending_brief = ["Unknown: hello"]
  1047. service._reset_triage()
  1048. emitted.clear()
  1049. service._run_brief_update(0, _escalated_payload(), service._now(), 0)
  1050. assert _triage_events(emitted) == []
  1051. assert service.last_triage is None
  1052. assert service._pending_brief == ["Unknown: hello"]
  1053. def test_brief_works_after_leaving_chat():
  1054. seen = []
  1055. service, emitted, _, _, _ = _triage_service(
  1056. brief_fn=lambda prompt: seen.append(prompt) or "RAW"
  1057. )
  1058. service.toggle_chat()
  1059. assert service.modes.exit_chat() is True
  1060. token = _seed_brief(service, "Unknown: hello")
  1061. signals = _escalated_payload()
  1062. service._last_brief_signals = signals
  1063. service._run_brief_update(0, signals, service._now(), token)
  1064. assert seen != []
  1065. assert [e.get("stage") for e in _triage_events(emitted)] == ["content"]
  1066. assert service.last_triage is not None
  1067. assert service.last_triage["brief"] == "RAW"
  1068. def test_deltas_arriving_during_call_survive_and_flush():
  1069. """Deltas appended mid-call are not consumed; the finally flushes them."""
  1070. service, emitted, clock, _, _ = _triage_service()
  1071. service.toggle_chat()
  1072. signals = _escalated_payload()
  1073. service._last_brief_signals = signals
  1074. token = _seed_brief(service, "Unknown: first")
  1075. appended: list[int] = []
  1076. def _brief(prompt):
  1077. if not appended:
  1078. appended.append(1)
  1079. service.handle_event(_transcript(clock, "during call"))
  1080. return "first brief"
  1081. service._brief_fn = _brief
  1082. service._run_brief_update(0, signals, clock(), token)
  1083. contents = [e for e in _triage_events(emitted) if e.get("stage") == "content"]
  1084. assert len(contents) == 1
  1085. assert contents[0]["triage"]["brief"] == "first brief"
  1086. flushed = [j for j in service._inference._queue if j.name == "brief-update"]
  1087. assert len(flushed) == 1
  1088. assert service._brief_outstanding is True
  1089. assert service._pending_brief == ["Unknown: during call"]
  1090. flushed[0].run()
  1091. contents = [e for e in _triage_events(emitted) if e.get("stage") == "content"]
  1092. assert len(contents) == 2
  1093. assert contents[1]["triage"]["brief"] == "first brief"
  1094. assert service._pending_brief == []
  1095. assert service._brief_outstanding is False
  1096. def test_in_flight_brief_after_clear_emits_and_writes_nothing():
  1097. """Stale in-flight job: no event, no file write, no requeue, flag untouched."""
  1098. brief_file = FakeBriefFile()
  1099. service, emitted, clock, _, lane = _triage_service(
  1100. brief_fn=lambda prompt: "RAW", brief_file=brief_file
  1101. )
  1102. service.toggle_chat()
  1103. service.handle_event(_transcript(clock, "hello"))
  1104. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  1105. service.tick()
  1106. _, _, _, gen = lane.submits[0]
  1107. service._on_triage_result(gen, _escalated_payload())
  1108. job = [j for j in service._inference._queue if j.name == "brief-update"][0]
  1109. assert service._brief_outstanding is True
  1110. service.clear()
  1111. assert service._brief_outstanding is False
  1112. token_after_clear = service._brief_token
  1113. emitted.clear()
  1114. job.run()
  1115. assert [e for e in _triage_events(emitted)] == []
  1116. assert brief_file.writes == []
  1117. assert service._pending_brief == []
  1118. assert service.last_triage is None
  1119. assert service._brief_token == token_after_clear
  1120. assert service._brief_outstanding is False
  1121. def test_clear_resets_triage():
  1122. resets: list[int] = []
  1123. chats: list[int] = []
  1124. brief_file = FakeBriefFile()
  1125. service, emitted, clock, _, lane = _triage_service(
  1126. triage=FakeTriage(escalate=True),
  1127. brief_fn=lambda prompt: "RAW",
  1128. brief_file=brief_file,
  1129. brief_reset=lambda: resets.append(1),
  1130. chat_reset=lambda: chats.append(1),
  1131. )
  1132. service.toggle_chat()
  1133. service.handle_event(_transcript(clock, "churn"))
  1134. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  1135. service.tick()
  1136. _, _, _, gen = lane.submits[0]
  1137. service._on_triage_result(gen, _escalated_payload())
  1138. assert service._inference.depth() == 2
  1139. assert service._pending_brief == ["Unknown: churn"]
  1140. assert service._brief_outstanding is True
  1141. token_before = service._brief_token
  1142. assert service.clear() is True
  1143. assert service._triage_generation == 1
  1144. assert service.last_triage is None
  1145. assert service._last_triage_window == ()
  1146. assert service.triage_history == []
  1147. assert service._pending_brief == []
  1148. assert service._brief_token == token_before + 1
  1149. assert service._brief_outstanding is False
  1150. assert service._last_brief_signals is None
  1151. assert resets == [1]
  1152. assert brief_file.clears == 1
  1153. assert chats == [1]
  1154. assert lane.drops == 1
  1155. assert service._inference.depth() == 0
  1156. assert list(service._inference._queue) == []
  1157. cleared = [e for e in _triage_events(emitted) if e.get("stage") == "cleared"]
  1158. assert len(cleared) == 1
  1159. assert cleared[0]["triage"] is None
  1160. assert {"type": "cleared"} in emitted
  1161. signals_before = len(
  1162. [e for e in _triage_events(emitted) if e.get("stage") == "signals"]
  1163. )
  1164. service._on_triage_result(gen, _escalated_payload())
  1165. assert service.last_triage is None
  1166. assert (
  1167. len([e for e in _triage_events(emitted) if e.get("stage") == "signals"])
  1168. == signals_before
  1169. )
  1170. submits_before = len(lane.submits)
  1171. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  1172. service.tick()
  1173. assert len(lane.submits) == submits_before
  1174. def test_exit_chat_does_not_reset_triage():
  1175. chats: list[int] = []
  1176. bresets: list[int] = []
  1177. brief_file = FakeBriefFile()
  1178. service, emitted, clock, _, lane = _triage_service(
  1179. brief_fn=lambda prompt: "RAW",
  1180. chat_reset=lambda: chats.append(1),
  1181. brief_reset=lambda: bresets.append(1),
  1182. brief_file=brief_file,
  1183. )
  1184. service.toggle_chat()
  1185. service.handle_event(_transcript(clock, "hello"))
  1186. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  1187. service.tick()
  1188. assert len(lane.submits) == 1
  1189. _, _, _, gen = lane.submits[0]
  1190. service._on_triage_result(gen, _escalated_payload())
  1191. assert service.last_triage is not None
  1192. assert service._triage_generation == 0
  1193. assert service.toggle_chat() is True
  1194. assert service.modes.mode.value == "idle"
  1195. assert service._triage_generation == 0
  1196. assert service.last_triage is not None
  1197. assert service._last_triage_window == ("hello",)
  1198. assert service.triage_history == ["hello"]
  1199. assert service._pending_brief == ["Unknown: hello"]
  1200. assert service._last_brief_signals is not None
  1201. assert service._brief_outstanding is True
  1202. assert lane.drops == 0
  1203. cleared = [e for e in _triage_events(emitted) if e.get("stage") == "cleared"]
  1204. assert cleared == []
  1205. assert chats == [1]
  1206. assert bresets == []
  1207. assert brief_file.clears == 0
  1208. def test_toggle_chat_enter_does_not_touch_triage():
  1209. """Entering chat resets only the chat buffers; the brief engine is independent."""
  1210. bresets: list[int] = []
  1211. brief_file = FakeBriefFile()
  1212. service, emitted, clock, _, lane = _triage_service(
  1213. brief_fn=lambda prompt: "RAW",
  1214. brief_reset=lambda: bresets.append(1),
  1215. brief_file=brief_file,
  1216. )
  1217. service.handle_event(_transcript(clock, "hello"))
  1218. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  1219. service.tick()
  1220. _, _, _, gen = lane.submits[0]
  1221. service._on_triage_result(gen, _escalated_payload())
  1222. triage_before = service.last_triage
  1223. pending_before = list(service._pending_brief)
  1224. assert service.toggle_chat() is True
  1225. assert service.modes.mode.value == "chat"
  1226. assert service._triage_generation == 0
  1227. assert service.last_triage is triage_before
  1228. assert service._last_triage_window == ("hello",)
  1229. assert service.triage_history == ["hello"]
  1230. assert service._pending_brief == pending_before
  1231. assert service._last_brief_signals is not None
  1232. assert service._brief_outstanding is True
  1233. assert lane.drops == 0
  1234. assert bresets == []
  1235. assert brief_file.clears == 0
  1236. cleared = [e for e in _triage_events(emitted) if e.get("stage") == "cleared"]
  1237. assert cleared == []
  1238. def test_clear_without_triage_emits_no_triage_event():
  1239. service, emitted, _ = _service()
  1240. brief_file = FakeBriefFile()
  1241. bresets: list[int] = []
  1242. service._brief_file = brief_file
  1243. service._brief_reset = lambda: bresets.append(1)
  1244. service.clear()
  1245. assert {"type": "cleared"} in emitted
  1246. assert _triage_events(emitted) == []
  1247. assert brief_file.clears == 1
  1248. assert bresets == []
  1249. def test_stale_brief_after_clear_does_not_clear_newer_dispatch_flag():
  1250. """A stale in-flight job must not clear a newer dispatch's outstanding flag."""
  1251. brief_file = FakeBriefFile()
  1252. service, emitted, clock, _, lane = _triage_service(
  1253. brief_fn=lambda prompt: "RAW", brief_file=brief_file
  1254. )
  1255. service.toggle_chat()
  1256. service.handle_event(_transcript(clock, "hello"))
  1257. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  1258. service.tick()
  1259. _, _, _, gen = lane.submits[0]
  1260. service._on_triage_result(gen, _escalated_payload())
  1261. stale_job = [j for j in service._inference._queue if j.name == "brief-update"][0]
  1262. assert service._brief_outstanding is True
  1263. service.clear()
  1264. # A fresh turn dispatches a new brief AFTER clear bumped the token.
  1265. service.handle_event(_transcript(clock, "fresh"))
  1266. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  1267. service.tick()
  1268. _, _, _, gen2 = lane.submits[1]
  1269. service._on_triage_result(gen2, _escalated_payload())
  1270. assert service._brief_outstanding is True
  1271. newer_token = service._brief_token
  1272. pending_before = list(service._pending_brief)
  1273. triage_before = service.last_triage
  1274. emitted.clear()
  1275. stale_job.run()
  1276. assert _triage_events(emitted) == []
  1277. assert brief_file.writes == []
  1278. assert service._pending_brief == pending_before
  1279. assert service._brief_outstanding is True
  1280. assert service._brief_token == newer_token
  1281. assert service.last_triage is triage_before
  1282. def test_clear_resets_chat_latch():
  1283. service, emitted, _ = _service()
  1284. service.toggle_chat()
  1285. service._chat_queue_full = True
  1286. service._pending_chat = ["stuck text"]
  1287. service.clear()
  1288. assert service._chat_queue_full is False
  1289. assert service._pending_chat == []
  1290. assert {"type": "cleared"} in emitted
  1291. def test_triage_end_to_end_signals_content_cleared():
  1292. """Two settled turns collapse into ONE brief job (single-outstanding guard).
  1293. The second `_on_triage_result` is refused as `"outstanding"`, so the queue
  1294. holds one `brief-update` that consumes both deltas and emits one `content`.
  1295. The panel keeps the FIRST turn's signals until the next settled turn (lag).
  1296. """
  1297. prompts: list[str] = []
  1298. service, emitted, clock, triage, lane = _triage_service(
  1299. brief_fn=lambda prompt: prompts.append(prompt) or "the brief"
  1300. )
  1301. service.toggle_chat()
  1302. service.handle_event(_transcript(clock, "first thought"))
  1303. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  1304. service.tick()
  1305. assert len(lane.submits) == 1
  1306. _, _, _, gen0 = lane.submits[0]
  1307. service._on_triage_result(
  1308. gen0, {"order": ["urgency"], "items": {}, "escalated": False, "input_tokens": 1}
  1309. )
  1310. assert [e.get("stage") for e in _triage_events(emitted)] == ["signals"]
  1311. assert prompts == []
  1312. assert service.last_triage is not None
  1313. assert service.last_triage["escalated"] is False
  1314. assert [j.name for j in service._inference._queue] == ["chat", "brief-update"]
  1315. triage._escalate = True
  1316. service.handle_event(_transcript(clock, "we might churn"))
  1317. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  1318. service.tick()
  1319. assert len(lane.submits) == 2
  1320. _, _, _, gen1 = lane.submits[1]
  1321. service._on_triage_result(gen1, _escalated_payload())
  1322. assert [e.get("stage") for e in _triage_events(emitted)] == ["signals", "signals"]
  1323. assert [j.name for j in service._inference._queue] == [
  1324. "chat",
  1325. "brief-update",
  1326. "chat",
  1327. ]
  1328. for job in [j for j in service._inference._queue if j.name == "brief-update"]:
  1329. job.run()
  1330. contents = [e for e in _triage_events(emitted) if e.get("stage") == "content"]
  1331. assert len(contents) == 1
  1332. assert len(prompts) == 1
  1333. deltas, _ = triage.prompt_calls[0]
  1334. assert deltas == ("Unknown: first thought", "Unknown: we might churn")
  1335. assert contents[0]["triage"]["escalated"] is False
  1336. assert contents[0]["triage"]["brief"] == "the brief"
  1337. assert service.last_triage == contents[0]["triage"]
  1338. assert service.status()["triage"] == contents[0]["triage"]
  1339. service.clear()
  1340. cleared = [e for e in _triage_events(emitted) if e.get("stage") == "cleared"]
  1341. assert len(cleared) == 1
  1342. assert cleared[0]["triage"] is None
  1343. assert service.last_triage is None
  1344. service._on_triage_result(gen1, _escalated_payload())
  1345. assert [e.get("stage") for e in _triage_events(emitted)] == [
  1346. "signals",
  1347. "signals",
  1348. "content",
  1349. "cleared",
  1350. ]
  1351. assert service.toggle_chat() is True
  1352. service.handle_event(_transcript(clock, "idle thought"))
  1353. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  1354. service.tick()
  1355. assert len(lane.submits) == 3
  1356. assert lane.submits[2][0].endswith("- idle thought")
  1357. def test_tick_emits_status_on_triage_state_change():
  1358. service, emitted, _, triage, _ = _triage_service(
  1359. triage=FakeTriage(state_pair=("loading", "warming up"))
  1360. )
  1361. service.tick()
  1362. statuses = [e for e in emitted if e["type"] == "status"]
  1363. assert len(statuses) == 1
  1364. assert statuses[0]["triage_state"] == "loading"
  1365. assert statuses[0]["triage_reason"] == "warming up"
  1366. assert "triage" in statuses[0]
  1367. triage._state_pair = ("ok", "")
  1368. service.tick()
  1369. statuses = [e for e in emitted if e["type"] == "status"]
  1370. assert len(statuses) == 2
  1371. assert statuses[1]["triage_state"] == "ok"
  1372. assert statuses[1]["triage_reason"] == ""
  1373. assert "triage" in statuses[1]
  1374. service.tick()
  1375. assert len([e for e in emitted if e["type"] == "status"]) == 2
  1376. def test_no_status_emitted_when_triage_disabled():
  1377. service, emitted, _ = _service()
  1378. service.tick()
  1379. service.tick()
  1380. assert [e for e in emitted if e["type"] == "status"] == []
  1381. def test_tick_heals_triage_panel_after_lane_ready():
  1382. import time as _time
  1383. from pathlib import Path
  1384. from stt_daemon.assistant.laya_lane import LayaLane
  1385. from stt_daemon.assistant.triage import TriageAnalyzer
  1386. from stt_daemon.tui.state import ViewState
  1387. class _FakeRouter:
  1388. def preload(self, names):
  1389. return self
  1390. def predict(self, state, questions, model=None, lang=None, **kwargs):
  1391. if "_warmup" in questions:
  1392. return {"model": model, "answers": {}, "usage": {}, "routing": {}}
  1393. return {
  1394. "model": model,
  1395. "answers": {
  1396. "frustration": {
  1397. "noul": 0.1,
  1398. "confidence": 0.9,
  1399. "answer_confidence": 0.9,
  1400. },
  1401. "urgency": {
  1402. "choice": "low",
  1403. "confidence": 0.9,
  1404. "answer_confidence": 0.9,
  1405. },
  1406. },
  1407. "usage": {"input_tokens": 5},
  1408. }
  1409. def _factory(**kwargs):
  1410. return _FakeRouter()
  1411. cfg = Config()
  1412. cfg.assistant.turn_gap_s = 0.5
  1413. cfg.triage.questions_file = str(
  1414. Path(__file__).resolve().parent.parent / "questions.example.json"
  1415. )
  1416. clock = Clock()
  1417. emitted: list[dict] = []
  1418. def emit(type_, **fields):
  1419. emitted.append({"type": type_, **fields})
  1420. analyzer = TriageAnalyzer(cfg.triage)
  1421. assert analyzer.questions, "example questions must load"
  1422. holder: dict = {}
  1423. lane = LayaLane(
  1424. cfg.triage,
  1425. agent_factory=_factory,
  1426. on_result=lambda gen, payload: holder["svc"]._on_triage_result(gen, payload),
  1427. on_state=lambda state, reason: analyzer.refresh(state, reason),
  1428. )
  1429. service = AssistantService(
  1430. cfg,
  1431. FakeSubscriber(),
  1432. emit=emit,
  1433. time_fn=clock,
  1434. triage=analyzer,
  1435. laya_lane=lane,
  1436. chat_fn=_ok_reply,
  1437. )
  1438. holder["svc"] = service
  1439. try:
  1440. lane.start()
  1441. deadline = _time.monotonic() + 5.0
  1442. while not lane.ready() and _time.monotonic() < deadline:
  1443. _time.sleep(0.005)
  1444. assert lane.ready(), "lane did not become ready"
  1445. assert analyzer.state() == ("ok", "")
  1446. service.tick()
  1447. statuses = [e for e in emitted if e["type"] == "status"]
  1448. assert statuses, "tick emitted no status after lane ready"
  1449. assert statuses[-1]["triage_state"] == "ok"
  1450. service.handle_event(_transcript(clock, "hello"))
  1451. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  1452. service.tick()
  1453. deadline = _time.monotonic() + 5.0
  1454. while service.last_triage is None and _time.monotonic() < deadline:
  1455. _time.sleep(0.005)
  1456. assert service.last_triage is not None, "no triage signals from lane"
  1457. view = ViewState()
  1458. for event in emitted:
  1459. view.ingest(event)
  1460. assert view.triage_state == "ok"
  1461. lines = view.triage_lines()
  1462. assert lines
  1463. assert not any("unavailable" in line for line in lines)
  1464. assert not any("loading" in line for line in lines)
  1465. finally:
  1466. lane.stop()
  1467. def _dump_brief(prompt, on_io=None):
  1468. """Brief fake that mimics LlmClient.chat's on_io phases."""
  1469. if on_io is not None:
  1470. on_io({"phase": "request", "url": "http://llm/v1", "body": {"prompt": prompt}})
  1471. on_io({"phase": "response", "payload": {"content": "parsed"}, "error": None})
  1472. return "BRIEF"
  1473. def _run_triage_flow(service, emitted, clock, lane, payload):
  1474. service.toggle_chat()
  1475. service.handle_event(_transcript(clock, "hello"))
  1476. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  1477. service.tick()
  1478. _, _, _, gen = lane.submits[0]
  1479. service._on_triage_result(gen, payload)
  1480. return gen
  1481. def _dump_files(tmp_path):
  1482. return list(tmp_path.rglob("*.json"))
  1483. def test_dump_writes_full_laya_and_llm_io(tmp_path):
  1484. service, emitted, clock, triage, lane = _triage_service(brief_fn=_dump_brief)
  1485. service._triage_dump = TriageDumper(True, directory=str(tmp_path))
  1486. service.cfg.triage.dump_io = True
  1487. _run_triage_flow(service, emitted, clock, lane, _escalated_payload())
  1488. jobs = [j for j in service._inference._queue if j.name == "brief-update"]
  1489. assert len(jobs) == 1
  1490. jobs[0].run()
  1491. files = _dump_files(tmp_path)
  1492. assert len(files) == 1
  1493. assert re.fullmatch(r"\d{6}-\d{3}\.json", files[0].name)
  1494. data = json.loads(files[0].read_text(encoding="utf-8"))
  1495. assert data["ts"] == clock()
  1496. assert isinstance(data["iso"], str) and data["iso"]
  1497. assert data["laya"]["request"]["state"] == "- hello"
  1498. assert data["laya"]["request"]["questions"] == triage.questions
  1499. assert data["laya"]["request"]["model"] == "multilingual"
  1500. assert data["laya"]["request"]["max_len"] == 1024
  1501. assert data["laya"]["response"] == _escalated_payload()
  1502. assert data["laya"]["error"] is None
  1503. assert data["llm"]["request"]["url"] == "http://llm/v1"
  1504. assert data["llm"]["request"]["body"] == {"prompt": "BRIEF-PROMPT"}
  1505. assert data["llm"]["response"] == {"content": "parsed"}
  1506. assert data["llm"]["error"] is None
  1507. assert service._triage_dump._pending == {}
  1508. def test_dump_laya_error_writes_laya_only_and_keeps_deltas(tmp_path):
  1509. """A Laya predict failure finalizes the Laya half with `llm: null`.
  1510. Nothing is dispatched, so no LLM half is ever recorded and the buffered
  1511. deltas survive for the next settled turn.
  1512. """
  1513. service, emitted, clock, _, lane = _triage_service(brief_fn=_dump_brief)
  1514. service._triage_dump = TriageDumper(True, directory=str(tmp_path))
  1515. service.cfg.triage.dump_io = True
  1516. _run_triage_flow(service, emitted, clock, lane, None)
  1517. assert [j.name for j in service._inference._queue] == ["chat"]
  1518. assert service._pending_brief == ["Unknown: hello"]
  1519. files = _dump_files(tmp_path)
  1520. assert len(files) == 1
  1521. data = json.loads(files[0].read_text(encoding="utf-8"))
  1522. assert data["laya"]["response"] is None
  1523. assert data["laya"]["error"] == "predict failed"
  1524. assert data["llm"] is None
  1525. assert service._triage_dump._pending == {}
  1526. def test_dump_without_brief_has_laya_only(tmp_path):
  1527. service, emitted, clock, _, lane = _triage_service(brief_fn=_dump_brief)
  1528. service._triage_dump = TriageDumper(True, directory=str(tmp_path))
  1529. service.cfg.triage.dump_io = True
  1530. service.cfg.triage.extract_enabled = False
  1531. _run_triage_flow(service, emitted, clock, lane, _escalated_payload())
  1532. files = _dump_files(tmp_path)
  1533. assert len(files) == 1
  1534. data = json.loads(files[0].read_text(encoding="utf-8"))
  1535. assert data["laya"]["response"] == _escalated_payload()
  1536. assert data["llm"] is None
  1537. assert service._triage_dump._pending == {}
  1538. def test_dump_queue_full_has_laya_only(tmp_path):
  1539. service, emitted, clock, _, lane = _triage_service(brief_fn=_dump_brief)
  1540. service._triage_dump = TriageDumper(True, directory=str(tmp_path))
  1541. service.cfg.triage.dump_io = True
  1542. service._inference = InferenceQueue(size=2)
  1543. _run_triage_flow(service, emitted, clock, lane, _escalated_payload())
  1544. assert service._inference.depth() == 1
  1545. assert [j.name for j in service._inference._queue] == ["chat"]
  1546. assert service._pending_brief == ["Unknown: hello"]
  1547. files = _dump_files(tmp_path)
  1548. assert len(files) == 1
  1549. data = json.loads(files[0].read_text(encoding="utf-8"))
  1550. assert data["laya"]["response"] == _escalated_payload()
  1551. assert data["llm"] is None
  1552. assert service._triage_dump._pending == {}
  1553. def test_dump_disabled_writes_nothing(tmp_path):
  1554. service, emitted, clock, _, lane = _triage_service(
  1555. brief_fn=lambda prompt: "RAW"
  1556. )
  1557. assert service._triage_dump.enabled is False
  1558. service._triage_dump = TriageDumper(False, directory=str(tmp_path))
  1559. _run_triage_flow(service, emitted, clock, lane, _escalated_payload())
  1560. jobs = [j for j in service._inference._queue if j.name == "brief-update"]
  1561. assert len(jobs) == 1
  1562. jobs[0].run()
  1563. assert _dump_files(tmp_path) == []
  1564. def test_dump_stale_result_discards_without_file(tmp_path):
  1565. service, emitted, clock, triage, lane = _triage_service(brief_fn=_dump_brief)
  1566. service._triage_dump = TriageDumper(True, directory=str(tmp_path))
  1567. service.cfg.triage.dump_io = True
  1568. service.toggle_chat()
  1569. service.handle_event(_transcript(clock, "hello"))
  1570. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  1571. service.tick()
  1572. _, _, _, gen = lane.submits[0]
  1573. real_normalize = triage.normalize
  1574. def stale_normalize(payload):
  1575. # Simulate a clear landing between the first check/begin and the re-check.
  1576. service._triage_generation += 1
  1577. return real_normalize(payload)
  1578. triage.normalize = stale_normalize
  1579. service._on_triage_result(gen, _escalated_payload())
  1580. assert _dump_files(tmp_path) == []
  1581. assert service._triage_dump._pending == {}
  1582. def test_dump_stale_brief_discards_without_file(tmp_path):
  1583. service, _, clock, _, _ = _triage_service(brief_fn=_dump_brief)
  1584. service._triage_dump = TriageDumper(True, directory=str(tmp_path))
  1585. service.cfg.triage.dump_io = True
  1586. ts = clock()
  1587. service._triage_dump.begin(ts, laya={"request": {}, "response": {}, "error": None})
  1588. service._pending_brief = ["Unknown: hello"]
  1589. service._triage_generation += 1 # stale before the brief even starts
  1590. service._run_brief_update(0, _escalated_payload(), ts, service._brief_token)
  1591. assert _dump_files(tmp_path) == []
  1592. assert service._triage_dump._pending == {}
  1593. assert service._pending_brief == ["Unknown: hello"]
  1594. def test_dump_brief_cleared_mid_flight_writes_nothing(tmp_path):
  1595. service, _, clock, _, _ = _triage_service(brief_fn=_dump_brief)
  1596. service._triage_dump = TriageDumper(True, directory=str(tmp_path))
  1597. service.cfg.triage.dump_io = True
  1598. def stale_brief(prompt, on_io=None):
  1599. # Simulate a clear landing mid-LLM-call (after the request phase fired).
  1600. service._triage_generation += 1
  1601. if on_io is not None:
  1602. on_io({"phase": "request", "url": "http://llm/v1", "body": {}})
  1603. on_io({"phase": "response", "payload": {"c": 1}, "error": None})
  1604. return "RAW"
  1605. service._brief_fn = stale_brief
  1606. service._pending_brief = ["Unknown: hello"]
  1607. service._brief_outstanding = True
  1608. token = service._brief_token
  1609. ts = clock()
  1610. service._triage_dump.begin(ts, laya={"request": {}, "response": {}, "error": None})
  1611. service._run_brief_update(0, _escalated_payload(), ts, token)
  1612. assert _dump_files(tmp_path) == []
  1613. assert service._triage_dump._pending == {}
  1614. assert service._pending_brief == []
  1615. assert service._brief_outstanding is False
  1616. def test_dump_gated_out_writes_laya_only_and_no_pending(tmp_path):
  1617. """A turn the gate leaves out writes `llm: null` and leaks no pending record."""
  1618. service, emitted, clock, triage, lane = _triage_service(
  1619. triage=FakeTriage(escalate=True, gate=False), brief_fn=_dump_brief
  1620. )
  1621. service._triage_dump = TriageDumper(True, directory=str(tmp_path))
  1622. service.cfg.triage.dump_io = True
  1623. _run_triage_flow(service, emitted, clock, lane, _escalated_payload())
  1624. assert [j.name for j in service._inference._queue] == ["chat"]
  1625. assert len(triage.gate_calls) == 1
  1626. files = _dump_files(tmp_path)
  1627. assert len(files) == 1
  1628. data = json.loads(files[0].read_text(encoding="utf-8"))
  1629. assert data["laya"]["response"] == _escalated_payload()
  1630. assert data["llm"] is None
  1631. assert service._triage_dump._pending == {}
  1632. def test_dump_coalesced_update_writes_laya_only_then_llm_only_flush(tmp_path):
  1633. """A coalesced turn writes a Laya-only record; the later flush a separate llm-only one."""
  1634. service, emitted, clock, _, lane = _triage_service(brief_fn=_dump_brief)
  1635. service._triage_dump = TriageDumper(True, directory=str(tmp_path))
  1636. service.cfg.triage.dump_io = True
  1637. service.toggle_chat()
  1638. service.handle_event(_transcript(clock, "first"))
  1639. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  1640. service.tick()
  1641. _, _, _, gen0 = lane.submits[0]
  1642. service._on_triage_result(gen0, _escalated_payload())
  1643. service.handle_event(_transcript(clock, "second"))
  1644. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  1645. service.tick()
  1646. _, _, _, gen1 = lane.submits[1]
  1647. service._on_triage_result(gen1, _escalated_payload())
  1648. assert service._brief_outstanding is True
  1649. appended: list[int] = []
  1650. def _brief(prompt, on_io=None):
  1651. if not appended:
  1652. appended.append(1)
  1653. service.handle_event(_transcript(clock, "during call"))
  1654. if on_io is not None:
  1655. on_io({"phase": "request", "url": "http://llm/v1", "body": {"prompt": prompt}})
  1656. on_io({"phase": "response", "payload": {"content": "parsed"}, "error": None})
  1657. return "BRIEF"
  1658. service._brief_fn = _brief
  1659. clock.advance(1.0)
  1660. job = [j for j in service._inference._queue if j.name == "brief-update"][0]
  1661. service._inference._queue.remove(job)
  1662. job.run()
  1663. flushed = [j for j in service._inference._queue if j.name == "brief-update"]
  1664. assert len(flushed) == 1
  1665. flushed[0].run()
  1666. assert service._triage_dump._pending == {}
  1667. records = [
  1668. json.loads(path.read_text(encoding="utf-8")) for path in _dump_files(tmp_path)
  1669. ]
  1670. assert len(records) == 3
  1671. coalesced = [r for r in records if r["laya"] is not None and r["llm"] is None]
  1672. flushed_records = [r for r in records if r["laya"] is None and r["llm"] is not None]
  1673. both = [r for r in records if r["laya"] is not None and r["llm"] is not None]
  1674. assert len(coalesced) == 1
  1675. assert len(flushed_records) == 1
  1676. assert len(both) == 1
  1677. assert coalesced[0]["ts"] != flushed_records[0]["ts"]
  1678. assert flushed_records[0]["llm"]["request"]["body"] == {"prompt": "BRIEF-PROMPT"}
  1679. def test_chat_client_failure_emits_llm_error_and_service_survives():
  1680. """Adversarial (a): a chat client raising on `chat` surfaces as an `llm_error`
  1681. event and the service keeps functioning afterwards."""
  1682. from stt_daemon.assistant.llm import ConversationEngine, LlmError
  1683. class BoomClient:
  1684. def chat(self, messages, max_tokens=None, timeout_s=None, **kwargs):
  1685. raise LlmError("boom")
  1686. engine = ConversationEngine(Config().llm, BoomClient(), system_prompt="SYS")
  1687. service, emitted, clock = _service()
  1688. service.chat_fn = engine.send
  1689. assert service.toggle_chat() is True
  1690. service._run_chat("hello")
  1691. errors = [e for e in emitted if e["type"] == "error" and e.get("code") == "llm_error"]
  1692. assert errors and "boom" in errors[-1]["message"]
  1693. assert service.toggle_chat() is True
  1694. assert service.modes.mode.value == "idle"