test_assistant_service.py 91 KB

1234567891011121314151617181920212223242526272829303132333435363738394041424344454647484950515253545556575859606162636465666768697071727374757677787980818283848586878889909192939495969798991001011021031041051061071081091101111121131141151161171181191201211221231241251261271281291301311321331341351361371381391401411421431441451461471481491501511521531541551561571581591601611621631641651661671681691701711721731741751761771781791801811821831841851861871881891901911921931941951961971981992002012022032042052062072082092102112122132142152162172182192202212222232242252262272282292302312322332342352362372382392402412422432442452462472482492502512522532542552562572582592602612622632642652662672682692702712722732742752762772782792802812822832842852862872882892902912922932942952962972982993003013023033043053063073083093103113123133143153163173183193203213223233243253263273283293303313323333343353363373383393403413423433443453463473483493503513523533543553563573583593603613623633643653663673683693703713723733743753763773783793803813823833843853863873883893903913923933943953963973983994004014024034044054064074084094104114124134144154164174184194204214224234244254264274284294304314324334344354364374384394404414424434444454464474484494504514524534544554564574584594604614624634644654664674684694704714724734744754764774784794804814824834844854864874884894904914924934944954964974984995005015025035045055065075085095105115125135145155165175185195205215225235245255265275285295305315325335345355365375385395405415425435445455465475485495505515525535545555565575585595605615625635645655665675685695705715725735745755765775785795805815825835845855865875885895905915925935945955965975985996006016026036046056066076086096106116126136146156166176186196206216226236246256266276286296306316326336346356366376386396406416426436446456466476486496506516526536546556566576586596606616626636646656666676686696706716726736746756766776786796806816826836846856866876886896906916926936946956966976986997007017027037047057067077087097107117127137147157167177187197207217227237247257267277287297307317327337347357367377387397407417427437447457467477487497507517527537547557567577587597607617627637647657667677687697707717727737747757767777787797807817827837847857867877887897907917927937947957967977987998008018028038048058068078088098108118128138148158168178188198208218228238248258268278288298308318328338348358368378388398408418428438448458468478488498508518528538548558568578588598608618628638648658668678688698708718728738748758768778788798808818828838848858868878888898908918928938948958968978988999009019029039049059069079089099109119129139149159169179189199209219229239249259269279289299309319329339349359369379389399409419429439449459469479489499509519529539549559569579589599609619629639649659669679689699709719729739749759769779789799809819829839849859869879889899909919929939949959969979989991000100110021003100410051006100710081009101010111012101310141015101610171018101910201021102210231024102510261027102810291030103110321033103410351036103710381039104010411042104310441045104610471048104910501051105210531054105510561057105810591060106110621063106410651066106710681069107010711072107310741075107610771078107910801081108210831084108510861087108810891090109110921093109410951096109710981099110011011102110311041105110611071108110911101111111211131114111511161117111811191120112111221123112411251126112711281129113011311132113311341135113611371138113911401141114211431144114511461147114811491150115111521153115411551156115711581159116011611162116311641165116611671168116911701171117211731174117511761177117811791180118111821183118411851186118711881189119011911192119311941195119611971198119912001201120212031204120512061207120812091210121112121213121412151216121712181219122012211222122312241225122612271228122912301231123212331234123512361237123812391240124112421243124412451246124712481249125012511252125312541255125612571258125912601261126212631264126512661267126812691270127112721273127412751276127712781279128012811282128312841285128612871288128912901291129212931294129512961297129812991300130113021303130413051306130713081309131013111312131313141315131613171318131913201321132213231324132513261327132813291330133113321333133413351336133713381339134013411342134313441345134613471348134913501351135213531354135513561357135813591360136113621363136413651366136713681369137013711372137313741375137613771378137913801381138213831384138513861387138813891390139113921393139413951396139713981399140014011402140314041405140614071408140914101411141214131414141514161417141814191420142114221423142414251426142714281429143014311432143314341435143614371438143914401441144214431444144514461447144814491450145114521453145414551456145714581459146014611462146314641465146614671468146914701471147214731474147514761477147814791480148114821483148414851486148714881489149014911492149314941495149614971498149915001501150215031504150515061507150815091510151115121513151415151516151715181519152015211522152315241525152615271528152915301531153215331534153515361537153815391540154115421543154415451546154715481549155015511552155315541555155615571558155915601561156215631564156515661567156815691570157115721573157415751576157715781579158015811582158315841585158615871588158915901591159215931594159515961597159815991600160116021603160416051606160716081609161016111612161316141615161616171618161916201621162216231624162516261627162816291630163116321633163416351636163716381639164016411642164316441645164616471648164916501651165216531654165516561657165816591660166116621663166416651666166716681669167016711672167316741675167616771678167916801681168216831684168516861687168816891690169116921693169416951696169716981699170017011702170317041705170617071708170917101711171217131714171517161717171817191720172117221723172417251726172717281729173017311732173317341735173617371738173917401741174217431744174517461747174817491750175117521753175417551756175717581759176017611762176317641765176617671768176917701771177217731774177517761777177817791780178117821783178417851786178717881789179017911792179317941795179617971798179918001801180218031804180518061807180818091810181118121813181418151816181718181819182018211822182318241825182618271828182918301831183218331834183518361837183818391840184118421843184418451846184718481849185018511852185318541855185618571858185918601861186218631864186518661867186818691870187118721873187418751876187718781879188018811882188318841885188618871888188918901891189218931894189518961897189818991900190119021903190419051906190719081909191019111912191319141915191619171918191919201921192219231924192519261927192819291930193119321933193419351936193719381939194019411942194319441945194619471948194919501951195219531954195519561957195819591960196119621963196419651966196719681969197019711972197319741975197619771978197919801981198219831984198519861987198819891990199119921993199419951996199719981999200020012002200320042005200620072008200920102011201220132014201520162017201820192020202120222023202420252026202720282029203020312032203320342035203620372038203920402041204220432044204520462047204820492050205120522053205420552056205720582059206020612062206320642065206620672068206920702071207220732074207520762077207820792080208120822083208420852086208720882089209020912092209320942095209620972098209921002101210221032104210521062107210821092110211121122113211421152116211721182119212021212122212321242125212621272128212921302131213221332134213521362137213821392140214121422143214421452146214721482149215021512152215321542155215621572158215921602161216221632164216521662167216821692170217121722173217421752176217721782179218021812182218321842185218621872188218921902191219221932194219521962197219821992200220122022203220422052206220722082209221022112212221322142215221622172218221922202221222222232224222522262227222822292230223122322233223422352236223722382239224022412242224322442245224622472248224922502251225222532254225522562257225822592260226122622263226422652266226722682269227022712272227322742275227622772278227922802281228222832284228522862287228822892290229122922293229422952296229722982299230023012302230323042305230623072308230923102311231223132314231523162317231823192320232123222323232423252326232723282329233023312332233323342335233623372338233923402341234223432344234523462347234823492350235123522353235423552356235723582359236023612362236323642365236623672368236923702371237223732374237523762377237823792380238123822383238423852386238723882389239023912392239323942395239623972398239924002401240224032404240524062407240824092410241124122413241424152416241724182419242024212422242324242425242624272428242924302431243224332434243524362437243824392440244124422443244424452446244724482449245024512452245324542455245624572458245924602461246224632464246524662467246824692470247124722473247424752476247724782479248024812482248324842485248624872488248924902491249224932494249524962497249824992500250125022503250425052506250725082509251025112512251325142515251625172518251925202521252225232524252525262527252825292530253125322533253425352536253725382539254025412542254325442545254625472548254925502551255225532554255525562557255825592560256125622563256425652566256725682569257025712572257325742575257625772578257925802581258225832584258525862587258825892590259125922593259425952596259725982599260026012602260326042605260626072608260926102611261226132614261526162617261826192620262126222623262426252626262726282629263026312632263326342635263626372638263926402641264226432644264526462647264826492650265126522653265426552656265726582659266026612662266326642665266626672668266926702671267226732674267526762677267826792680268126822683268426852686268726882689269026912692269326942695269626972698269927002701270227032704270527062707270827092710271127122713271427152716
  1. """Tests for the assistant service (Phase 2) using synthetic event streams."""
  2. import itertools
  3. import json
  4. import re
  5. import threading
  6. import time
  7. from typing import Any
  8. from stt_daemon import events
  9. from stt_daemon.assistant.inference import InferenceJob, InferenceQueue
  10. from stt_daemon.assistant.service import EXECUTE_BUSY, AssistantService
  11. from stt_daemon.assistant.triage import TriageAnalyzer
  12. from stt_daemon.assistant.triage_dump import TriageDumper
  13. from stt_daemon.config import Config
  14. _sequence = itertools.count(1)
  15. # A real analyzer (pure, stdlib-only helpers) backing the fake's retention
  16. # guard so guard behaviour is exercised end to end.
  17. _real_analyzer = TriageAnalyzer(Config().triage)
  18. class Clock:
  19. def __init__(self, start=1000.0):
  20. self.t = float(start)
  21. def __call__(self):
  22. return self.t
  23. def advance(self, dt):
  24. self.t += float(dt)
  25. class FakeSubscriber:
  26. def events(self):
  27. return iter(())
  28. def close(self):
  29. pass
  30. def _service():
  31. cfg = Config()
  32. clock = Clock()
  33. emitted: list[dict] = []
  34. def emit(type_, **fields):
  35. emitted.append({"type": type_, **fields})
  36. service = AssistantService(cfg, FakeSubscriber(), emit=emit, time_fn=clock)
  37. return service, emitted, clock
  38. def _ev(type_, clock, **fields):
  39. event = {"v": 1, "type": type_, "seq": next(_sequence), "ts": clock()}
  40. event.update(fields)
  41. return event
  42. def _transcript(clock, text, ts=None, session_dir=None):
  43. event = {
  44. "v": 1,
  45. "type": events.TRANSCRIPT,
  46. "seq": next(_sequence),
  47. "ts": clock() if ts is None else ts,
  48. "text": text,
  49. }
  50. if session_dir is not None:
  51. event["session_dir"] = session_dir
  52. return event
  53. def test_ready_requires_matching_segment_done():
  54. service, _, clock = _service()
  55. service.handle_event(_ev(events.SPEECH_START, clock))
  56. assert service.ready() is False
  57. service.handle_event(_ev(events.SPEECH_STOP, clock, seg_id=1))
  58. assert service.ready() is False # awaiting segment 1
  59. service.handle_event(_ev(events.SEGMENT_DONE, clock, seg_id=1, emitted=True))
  60. assert service.ready() is True
  61. def test_stale_segment_done_does_not_satisfy_later_turn():
  62. service, _, clock = _service()
  63. service.handle_event(_ev(events.SPEECH_STOP, clock, seg_id=1))
  64. service.handle_event(_ev(events.SPEECH_START, clock))
  65. service.handle_event(_ev(events.SPEECH_STOP, clock, seg_id=2))
  66. service.handle_event(_ev(events.SEGMENT_DONE, clock, seg_id=1, emitted=True))
  67. assert service.ready() is False # still awaiting segment 2
  68. service.handle_event(_ev(events.SEGMENT_DONE, clock, seg_id=2, emitted=True))
  69. assert service.ready() is True
  70. def test_gated_segment_done_clears_readiness():
  71. service, _, clock = _service()
  72. service.handle_event(_ev(events.SPEECH_STOP, clock, seg_id=3))
  73. service.handle_event(_ev(events.SEGMENT_DONE, clock, seg_id=3, emitted=False))
  74. assert service.ready() is True
  75. def test_speech_stop_without_seg_id_clears_readiness():
  76. """A discarded turn closes with speech_stop but no seg_id; readiness must recover."""
  77. service, _, clock = _service()
  78. service.handle_event(_ev(events.SPEECH_START, clock))
  79. assert service.ready() is False
  80. service.handle_event(_ev(events.SPEECH_STOP, clock)) # discarded: no seg_id
  81. assert service.speech_open is False
  82. assert service.awaited_seg_id is None
  83. assert service.ready() is True
  84. def test_status_resets_stale_speech_state_on_reconnect():
  85. service, _, clock = _service()
  86. service.handle_event(_ev(events.SPEECH_START, clock))
  87. assert service.speech_open is True
  88. service.handle_event(_ev(events.STATUS, clock, capture="x", segments_done=0))
  89. assert service.speech_open is False
  90. assert service.awaited_seg_id is None
  91. assert service.ready() is True
  92. def test_command_buffer_uses_arm_timestamp():
  93. service, _, clock = _service()
  94. clock.advance(10)
  95. assert service.arm() is True
  96. arm_ts = service.arm_ts
  97. assert arm_ts is not None
  98. # Replayed transcript from before arming is ignored.
  99. service.handle_event(_transcript(clock, "old", ts=arm_ts - 5))
  100. assert service.command_text == ""
  101. service.handle_event(_transcript(clock, "what time is it"))
  102. assert service.command_text == "what time is it"
  103. def test_mutual_exclusion_between_command_and_chat():
  104. service, _, _ = _service()
  105. assert service.toggle_chat() is True
  106. assert service.arm() is False # cannot arm in chat
  107. assert service.toggle_chat() is True # back to idle
  108. assert service.arm() is True
  109. assert service.toggle_chat() is False # cannot chat while armed
  110. def test_arm_timeout_disarms_and_emits_error():
  111. service, emitted, clock = _service()
  112. service.arm()
  113. clock.advance(service.cfg.assistant.command_arm_timeout_s + 0.1)
  114. service.tick()
  115. assert service.modes.mode.value == "idle"
  116. assert service.command_text == ""
  117. assert any(e["type"] == "error" and e["code"] == "arm_timeout" for e in emitted)
  118. def test_long_speech_does_not_disarm():
  119. service, emitted, clock = _service()
  120. service.arm()
  121. service.handle_event(_ev(events.SPEECH_START, clock))
  122. clock.advance(service.cfg.assistant.command_arm_timeout_s + 30.0)
  123. service.tick()
  124. assert service.modes.mode.value == "command_armed"
  125. assert not any(e["type"] == "error" for e in emitted)
  126. def test_captured_command_survives_arm_timeout():
  127. service, emitted, clock = _service()
  128. service.arm()
  129. service.handle_event(_transcript(clock, "what time is it"))
  130. service.handle_event(_ev(events.SPEECH_STOP, clock, seg_id=1))
  131. service.handle_event(_ev(events.SEGMENT_DONE, clock, seg_id=1, emitted=True))
  132. clock.advance(service.cfg.assistant.command_arm_timeout_s + 30.0)
  133. service.tick()
  134. assert service.modes.mode.value == "command_armed"
  135. assert service.command_text == "what time is it"
  136. assert not any(e["type"] == "error" for e in emitted)
  137. def test_stt_stall_cancels_armed_command():
  138. service, emitted, clock = _service()
  139. service.handle_event(_ev(events.HEARTBEAT, clock, worker_stall_s=0.0))
  140. service.arm()
  141. clock.advance(service.cfg.assistant.stall_timeout_ms / 1000.0 + 0.5)
  142. service.tick()
  143. assert service.modes.mode.value == "idle"
  144. assert any(e["type"] == "error" and e["code"] == "stt_stall" for e in emitted)
  145. def test_worker_stall_marks_stt_degraded():
  146. service, _, clock = _service()
  147. long_stall = service.cfg.assistant.worker_stall_ms / 1000.0 + 1.0
  148. service.handle_event(_ev(events.HEARTBEAT, clock, worker_stall_s=long_stall))
  149. assert service.stt_ok() is False
  150. assert service.ready() is False
  151. def test_chat_idle_timeout_exits_chat():
  152. service, _, clock = _service()
  153. assert service.toggle_chat() is True
  154. clock.advance(service.cfg.assistant.chat_idle_timeout_s + 0.1)
  155. service.tick()
  156. assert service.modes.mode.value == "idle"
  157. def test_chat_exit_phrase_exits_chat():
  158. service, _, clock = _service()
  159. assert service.toggle_chat() is True
  160. service.handle_event(_transcript(clock, "That's all."))
  161. assert service.modes.mode.value == "idle"
  162. assert service.chat_history == []
  163. def test_viewer_detached_exits_chat_and_forgets_history():
  164. service, _, clock = _service()
  165. assert service.toggle_chat() is True
  166. service.handle_event(_transcript(clock, "hello"))
  167. assert service.viewer_detached() is True
  168. assert service.modes.mode.value == "idle"
  169. assert service.chat_history == []
  170. def test_viewer_detached_is_noop_outside_chat():
  171. service, _, _ = _service()
  172. assert service.viewer_detached() is False
  173. assert service.modes.mode.value == "idle"
  174. def test_exit_chat_invokes_chat_reset():
  175. cfg = Config()
  176. resets: list[int] = []
  177. service = AssistantService(
  178. cfg, FakeSubscriber(), time_fn=Clock(), chat_reset=lambda: resets.append(1)
  179. )
  180. service.toggle_chat()
  181. service.viewer_detached()
  182. assert resets == [1]
  183. def test_chat_accumulates_turns():
  184. service, _, clock = _service()
  185. service.toggle_chat()
  186. for text in ("hello there", "how are you"):
  187. service.handle_event(_transcript(clock, text))
  188. assert service.chat_history == ["Unknown: hello there", "Unknown: how are you"]
  189. def test_execute_requires_readiness():
  190. service, _, clock = _service()
  191. service.arm()
  192. service.handle_event(_transcript(clock, "do it"))
  193. service.handle_event(_ev(events.SPEECH_START, clock))
  194. assert service.execute() is None # speech still open
  195. assert service.modes.mode.value == "command_armed"
  196. service.handle_event(_ev(events.SPEECH_STOP, clock, seg_id=1))
  197. assert service.execute() is None # awaiting segment 1
  198. service.handle_event(_ev(events.SEGMENT_DONE, clock, seg_id=1, emitted=True))
  199. assert service.execute() == "do it"
  200. assert service.modes.mode.value == "executing"
  201. assert service.finish() is True
  202. assert service.modes.mode.value == "idle"
  203. def test_execute_reports_busy_when_queue_rejects():
  204. service, emitted, clock = _service()
  205. # A zero-capacity lane rejects the priority command job on submit.
  206. service._inference = InferenceQueue(size=0)
  207. service.executor = object()
  208. service.arm()
  209. service.handle_event(_transcript(clock, "do it"))
  210. service.handle_event(_ev(events.SPEECH_STOP, clock, seg_id=1))
  211. service.handle_event(_ev(events.SEGMENT_DONE, clock, seg_id=1, emitted=True))
  212. assert service.execute() is EXECUTE_BUSY
  213. assert service.modes.mode.value == "idle"
  214. assert not any(e.get("code") == "busy" for e in emitted)
  215. def test_turn_ended_requires_quiet_gap():
  216. service, _, clock = _service()
  217. service.handle_event(_ev(events.SPEECH_STOP, clock, seg_id=1))
  218. service.handle_event(_ev(events.SEGMENT_DONE, clock, seg_id=1, emitted=True))
  219. assert service.ready() is True
  220. assert service.turn_ended() is False
  221. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  222. assert service.turn_ended() is True
  223. def test_emits_mode_and_command_text():
  224. service, emitted, clock = _service()
  225. service.arm()
  226. assert {"type": "mode", "mode": "command_armed"} in emitted
  227. service.handle_event(_transcript(clock, "hi"))
  228. assert any(e["type"] == "command_text" and e["text"] == "hi" for e in emitted)
  229. def test_cancel_clears_command_buffer():
  230. service, _, clock = _service()
  231. service.arm()
  232. service.handle_event(_transcript(clock, "hi"))
  233. assert service.cancel() is True
  234. assert service.modes.mode.value == "idle"
  235. assert service.command_text == ""
  236. assert service.arm_ts is None
  237. def test_pending_chat_is_not_lost_across_threads():
  238. """Transcripts appended on the reader thread while the ticker dispatches
  239. must all reach the model: the join-and-clear in _dispatch_chat is atomic,
  240. and the user bubble is emitted by the worker in _run_chat."""
  241. cfg = Config()
  242. cfg.assistant.turn_gap_s = 0.01
  243. dispatched: list[str] = []
  244. lock = threading.Lock()
  245. def emit(type_, **fields):
  246. if type_ == "chat_message" and fields.get("role") == "user":
  247. with lock:
  248. dispatched.append(fields["text"])
  249. service = AssistantService(cfg, FakeSubscriber(), emit=emit, chat_fn=lambda text: "ok")
  250. service.toggle_chat()
  251. service.start()
  252. try:
  253. total = 200
  254. producer = threading.Thread(
  255. target=lambda: [
  256. service.handle_event(
  257. {
  258. "v": 1,
  259. "type": events.TRANSCRIPT,
  260. "seq": i,
  261. "ts": time.time(),
  262. "text": f"w{i}",
  263. }
  264. )
  265. for i in range(total)
  266. ],
  267. daemon=True,
  268. )
  269. producer.start()
  270. deadline = time.time() + 10.0
  271. while time.time() < deadline:
  272. service.tick()
  273. with lock:
  274. words = sum(len(text.split()) for text in dispatched)
  275. done = words == 2 * total
  276. if not producer.is_alive() and done:
  277. break
  278. time.sleep(0.002)
  279. producer.join(timeout=5)
  280. with lock:
  281. words = sum(len(text.split()) for text in dispatched)
  282. assert words == 2 * total
  283. finally:
  284. service.stop()
  285. def _full_queue_service():
  286. service, emitted, clock = _service()
  287. service.toggle_chat()
  288. service._inference = InferenceQueue(size=1)
  289. service._inference.submit(
  290. InferenceJob(name="blocker", run=lambda: None, evictable=False)
  291. )
  292. return service, emitted, clock
  293. def test_chat_refusal_rebuffers_and_emits_queue_full_once():
  294. """A refused chat submit re-buffers under lock and emits queue_full on flip."""
  295. service, emitted, _ = _full_queue_service()
  296. service._pending_chat = ["hello world"]
  297. service._dispatch_chat()
  298. assert service._pending_chat == ["hello world"]
  299. assert service._chat_queue_full is True
  300. errors = [e for e in emitted if e["type"] == "error" and e.get("code") == "queue_full"]
  301. assert len(errors) == 1
  302. assert [e for e in emitted if e["type"] == "chat_message"] == []
  303. service._dispatch_chat()
  304. assert service._pending_chat == ["hello world"]
  305. errors = [e for e in emitted if e["type"] == "error" and e.get("code") == "queue_full"]
  306. assert len(errors) == 1
  307. def test_chat_dispatch_success_clears_latch_without_user_bubble():
  308. """Success clears the latch; the user bubble comes from _run_chat, not dispatch."""
  309. service, emitted, _ = _full_queue_service()
  310. service._pending_chat = ["hello world"]
  311. service._chat_queue_full = True
  312. service._inference.drop(lambda j: True)
  313. service._dispatch_chat()
  314. assert service._pending_chat == []
  315. assert service._chat_queue_full is False
  316. assert [e for e in emitted if e["type"] == "chat_message"] == []
  317. def test_run_chat_emits_user_first_then_reply():
  318. service, emitted, _ = _service()
  319. service.chat_fn = lambda text: "reply!"
  320. service._run_chat("hello")
  321. assert emitted == [
  322. {"type": "chat_message", "role": "user", "text": "hello"},
  323. {"type": "chat_message", "role": "assistant", "text": "reply!"},
  324. ]
  325. def test_chat_notify_emits_compaction_note():
  326. service, emitted, _ = _service()
  327. service.chat_notify("compacted", turns=4)
  328. assert {
  329. "type": "chat_message",
  330. "role": "note",
  331. "text": "Compacted 4 earlier turns into a summary.",
  332. } in emitted
  333. def test_chat_notify_emits_truncated_error():
  334. service, emitted, _ = _service()
  335. service.chat_notify("truncated", message="cut off")
  336. assert {"type": "error", "code": "truncated", "message": "cut off"} in emitted
  337. def test_clear_empties_chat_history():
  338. service, emitted, clock = _service()
  339. service.toggle_chat()
  340. for text in ("hello", "how are you"):
  341. service.handle_event(_transcript(clock, text))
  342. assert service.chat_history == ["Unknown: hello", "Unknown: how are you"]
  343. assert len(service._pending_chat) == 2
  344. assert service.clear() is True
  345. assert service.chat_history == []
  346. assert service._pending_chat == []
  347. assert {"type": "cleared"} in emitted
  348. def test_clear_invokes_chat_reset():
  349. cfg = Config()
  350. resets: list[int] = []
  351. service = AssistantService(
  352. cfg, FakeSubscriber(), time_fn=Clock(), chat_reset=lambda: resets.append(1)
  353. )
  354. service.toggle_chat()
  355. service.clear()
  356. assert resets == [1]
  357. def test_clear_does_not_change_mode():
  358. service, _, clock = _service()
  359. service.toggle_chat()
  360. assert service.modes.mode.value == "chat"
  361. service.clear()
  362. assert service.modes.mode.value == "chat"
  363. def test_clear_always_returns_true():
  364. service, _, _ = _service()
  365. assert service.clear() is True
  366. service.toggle_chat()
  367. service.handle_event(_ev(events.TRANSCRIPT, Clock(), text="test"))
  368. assert service.clear() is True
  369. def test_heartbeat_emits_inference_depth_and_in_flight():
  370. """Calling tick() emits heartbeat with inference_depth (int) and inference_in_flight (bool)."""
  371. service, emitted, clock = _service()
  372. service.tick()
  373. heartbeats = [e for e in emitted if e["type"] == "heartbeat"]
  374. assert len(heartbeats) == 1
  375. heartbeat = heartbeats[0]
  376. assert "inference_depth" in heartbeat
  377. assert isinstance(heartbeat["inference_depth"], int)
  378. assert "inference_in_flight" in heartbeat
  379. assert isinstance(heartbeat["inference_in_flight"], bool)
  380. def test_status_contains_inference_depth_and_in_flight():
  381. """status() snapshot contains inference_depth (int) and inference_in_flight (bool)."""
  382. service, _, _ = _service()
  383. status = service.status()
  384. assert "inference_depth" in status
  385. assert isinstance(status["inference_depth"], int)
  386. assert "inference_in_flight" in status
  387. assert isinstance(status["inference_in_flight"], bool)
  388. _AUTO = object()
  389. class FakeTriage:
  390. def __init__(
  391. self,
  392. questions=_AUTO,
  393. state_pair=("ok", ""),
  394. escalate=False,
  395. parsed=_AUTO,
  396. normalized=_AUTO,
  397. gate=True,
  398. ):
  399. if questions is _AUTO:
  400. questions = {"urgency": {"type": "noul", "instructions": "how urgent"}}
  401. self._questions = questions
  402. self._state_pair = state_pair
  403. self._escalate = escalate
  404. self._parsed = parsed
  405. self._normalized = normalized
  406. self._gate = gate
  407. self.build_state_calls: list[tuple] = []
  408. self.normalize_calls: list = []
  409. self.prompt_calls: list[tuple] = []
  410. self.gate_calls: list = []
  411. @property
  412. def questions(self):
  413. return self._questions
  414. def state(self):
  415. return self._state_pair
  416. def build_state(self, window):
  417. self.build_state_calls.append(tuple(window))
  418. return "\n".join("- " + str(item) for item in (window or []))
  419. def normalize(self, payload):
  420. self.normalize_calls.append(payload)
  421. if self._normalized is not _AUTO:
  422. return self._normalized
  423. if not isinstance(payload, dict):
  424. return {}
  425. signals = {"order": [], "items": {}, "escalated": False, "input_tokens": 0}
  426. signals.update(payload)
  427. if self._escalate:
  428. signals["escalated"] = True
  429. return signals
  430. def build_brief_prompt(self, deltas, signals):
  431. self.prompt_calls.append(
  432. (tuple(deltas), dict(signals) if isinstance(signals, dict) else signals)
  433. )
  434. return "BRIEF-PROMPT"
  435. def build_ledger_prompt(self, narrative, ledger, deltas, signals):
  436. self.prompt_calls.append(
  437. (tuple(deltas), dict(signals) if isinstance(signals, dict) else signals)
  438. )
  439. ledger_text = "\n".join("- " + f for f in ledger) or "(none yet)"
  440. body = "\n".join("- " + d for d in deltas)
  441. return (
  442. f"CURRENT LEDGER:\n{ledger_text}\n\n"
  443. f"CURRENT BRIEF:\n{narrative or '(none yet)'}\n\n"
  444. f"NEW UTTERANCES:\n{body}"
  445. )
  446. def parse_ledger_reply(self, text, truncated=False):
  447. return _real_analyzer.parse_ledger_reply(text, truncated=truncated)
  448. def parse_facts(self, block):
  449. return _real_analyzer.parse_facts(block)
  450. def parse_brief(self, text):
  451. if self._parsed is _AUTO:
  452. return text if text else None
  453. return self._parsed
  454. def should_update_brief(self, signals):
  455. self.gate_calls.append(signals)
  456. return self._gate
  457. class FakeBriefFile:
  458. """Recording stand-in for BriefFile (write/clear/set_directory never raise)."""
  459. def __init__(self):
  460. self.writes: list[str] = []
  461. self.clears = 0
  462. self.directories: list[str] = []
  463. def set_directory(self, directory):
  464. self.directories.append(directory)
  465. def write(self, text):
  466. self.writes.append(text)
  467. def clear(self):
  468. self.clears += 1
  469. class FakeLane:
  470. def __init__(self, ready=True):
  471. self._ready = ready
  472. self.submits: list[tuple] = []
  473. self.drops = 0
  474. self.predict_gate = threading.Event()
  475. def ready(self):
  476. return self._ready
  477. def state(self):
  478. return ("ok", "") if self._ready else ("loading", "")
  479. def submit(self, state, questions, lang, generation):
  480. self.submits.append((state, questions, lang, generation))
  481. return True
  482. def drop_pending(self):
  483. self.drops += 1
  484. class FakeDebugSink:
  485. def __init__(self):
  486. self.events: list[tuple] = []
  487. def emit(self, type_, **fields):
  488. self.events.append((type_, fields))
  489. def _ok_reply(text):
  490. return "ok"
  491. def _brief_reply(narrative="", facts=None):
  492. """Build a ledger-format reply the analyzer's parser can consume."""
  493. body = "\n".join("- " + fact for fact in (facts or [])) or "none"
  494. return f"NEW FACTS:\n{body}\n\nBRIEF:\n{narrative}"
  495. def _triage_service(
  496. triage=None,
  497. lane=None,
  498. brief_fn=None,
  499. chat_fn: Any = _AUTO,
  500. brief_file=None,
  501. brief_reset=None,
  502. chat_reset=None,
  503. debug_sink=None,
  504. ):
  505. cfg = Config()
  506. cfg.assistant.turn_gap_s = 0.5
  507. clock = Clock()
  508. emitted: list[dict] = []
  509. def emit(type_, **fields):
  510. emitted.append({"type": type_, **fields})
  511. if triage is None:
  512. triage = FakeTriage()
  513. if lane is None:
  514. lane = FakeLane()
  515. if chat_fn is _AUTO:
  516. chat_fn = _ok_reply
  517. factory = (lambda: debug_sink) if debug_sink is not None else None
  518. service = AssistantService(
  519. cfg,
  520. FakeSubscriber(),
  521. emit=emit,
  522. time_fn=clock,
  523. triage=triage,
  524. laya_lane=lane,
  525. brief_fn=_wrap_brief_fn(brief_fn),
  526. brief_reset=brief_reset,
  527. brief_file=brief_file,
  528. chat_fn=chat_fn,
  529. chat_reset=chat_reset,
  530. debug_sink_factory=factory,
  531. )
  532. return service, emitted, clock, triage, lane
  533. def _wrap_brief_fn(brief_fn):
  534. """Adapt a simple `prompt -> text` stub to the engine's call signature.
  535. A plain string return is treated as the volatile narrative half of a
  536. ledger reply, so existing stubs keep reading naturally.
  537. """
  538. if brief_fn is None:
  539. return None
  540. def wrapped(prompt, on_io=None, finalize=None):
  541. kwargs = {}
  542. if on_io is not None:
  543. kwargs["on_io"] = on_io
  544. try:
  545. result = brief_fn(prompt, **kwargs)
  546. except TypeError:
  547. result = brief_fn(prompt)
  548. if finalize is not None:
  549. result = finalize(result, "stop")
  550. is_ledger = "BRIEF:" in result or "NEW FACTS:" in result
  551. if isinstance(result, str) and result and not is_ledger:
  552. result = _brief_reply(narrative=result)
  553. return result
  554. return wrapped
  555. def _triage_events(emitted):
  556. return [e for e in emitted if e["type"] == "triage"]
  557. def _escalated_payload():
  558. return {"order": [], "items": {}, "escalated": True, "input_tokens": 3}
  559. def test_triage_status_disabled_when_no_analyzer():
  560. service, _, _ = _service()
  561. status = service.status()
  562. assert status["triage_state"] == "disabled"
  563. assert status["triage_reason"] == ""
  564. assert status["triage"] is None
  565. def test_triage_status_reflects_analyzer():
  566. service, _, _, _, _ = _triage_service(
  567. triage=FakeTriage(state_pair=("loading", "warming up"))
  568. )
  569. status = service.status()
  570. assert status["triage_state"] == "loading"
  571. assert status["triage_reason"] == "warming up"
  572. assert status["triage"] is None
  573. def test_status_contains_questions_from_analyzer():
  574. questions = {
  575. "urgency": {"type": "noul", "instructions": "how urgent"},
  576. "sentiment": {"type": "score", "instructions": "tone", "criteria": ["low", "high"]},
  577. }
  578. service, _, _, triage, _ = _triage_service(triage=FakeTriage(questions=questions))
  579. status = service.status()
  580. assert status["questions"] == questions
  581. assert status["questions"] is triage.questions
  582. def test_status_questions_none_without_analyzer():
  583. service, _, _ = _service()
  584. assert service.status()["questions"] is None
  585. def test_status_event_carries_questions():
  586. service, emitted, _, triage, _ = _triage_service()
  587. service.tick()
  588. statuses = [e for e in emitted if e["type"] == "status"]
  589. assert len(statuses) == 1
  590. assert statuses[0]["questions"] is triage.questions
  591. def test_triage_captures_transcript_lang():
  592. service, _, clock, _, _ = _triage_service()
  593. assert service._last_transcript_lang is None
  594. event = _transcript(clock, "hola")
  595. event["lang"] = "es"
  596. service.handle_event(event)
  597. assert service._last_transcript_lang == "es"
  598. service.handle_event(_transcript(clock, "hello"))
  599. assert service._last_transcript_lang is None
  600. def test_maybe_triage_passes_lang_to_lane():
  601. service, _, clock, _, lane = _triage_service()
  602. event = _transcript(clock, "hola")
  603. event["lang"] = "es"
  604. service.handle_event(event)
  605. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  606. service.tick()
  607. assert len(lane.submits) == 1
  608. _, _, lang, _ = lane.submits[0]
  609. assert lang == "es"
  610. def test_maybe_triage_runs_in_idle_mode():
  611. service, _, clock, triage, lane = _triage_service()
  612. service.handle_event(_transcript(clock, "hello"))
  613. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  614. service.tick()
  615. assert len(lane.submits) == 1
  616. state, questions, lang, gen = lane.submits[0]
  617. assert state == "- hello"
  618. assert questions is triage.questions
  619. assert lang is None
  620. assert gen == 0
  621. assert triage.build_state_calls == [("hello",)]
  622. assert service.triage_history == ["hello"]
  623. def test_maybe_triage_uses_transcript_buffer_not_chat_history():
  624. service, _, clock, triage, lane = _triage_service(chat_fn=None)
  625. service.chat_history = ["stale chat only"]
  626. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  627. service.tick()
  628. assert lane.submits == []
  629. assert triage.build_state_calls == []
  630. service.handle_event(_transcript(clock, "hello"))
  631. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  632. service.tick()
  633. assert len(lane.submits) == 1
  634. assert triage.build_state_calls == [("hello",)]
  635. def test_maybe_triage_requires_settled_turn():
  636. service, _, clock, _, lane = _triage_service()
  637. service.handle_event(_transcript(clock, "hello"))
  638. service.tick()
  639. assert lane.submits == []
  640. def test_maybe_triage_periodic_fires_before_turn_settles():
  641. service, _, clock, _, lane = _triage_service()
  642. service.cfg.triage.periodic_s = 0.2
  643. service.handle_event(_transcript(clock, "hello"))
  644. assert service.turn_ended() is False
  645. clock.advance(0.25) # due (0.2) yet still quieter than turn_gap_s (0.5)
  646. service.tick()
  647. assert service.turn_ended() is False
  648. assert len(lane.submits) == 1
  649. assert lane.submits[0][0] == "- hello"
  650. def test_maybe_triage_periodic_disabled_ignores_accumulating_speech():
  651. service, _, clock, _, lane = _triage_service()
  652. service.cfg.triage.periodic_s = 0.0
  653. service.handle_event(_transcript(clock, "hello"))
  654. clock.advance(0.25)
  655. service.tick()
  656. assert service.turn_ended() is False
  657. assert lane.submits == []
  658. def test_maybe_triage_periodic_rearms_after_submit():
  659. service, _, clock, _, lane = _triage_service()
  660. service.cfg.triage.periodic_s = 0.2
  661. service.handle_event(_transcript(clock, "first"))
  662. clock.advance(0.25)
  663. service.tick()
  664. assert len(lane.submits) == 1
  665. service.tick()
  666. service.tick()
  667. assert len(lane.submits) == 1 # identical window, no new speech
  668. service.handle_event(_transcript(clock, "second"))
  669. clock.advance(0.25)
  670. service.tick()
  671. assert len(lane.submits) == 2
  672. assert lane.submits[1][0] == "- first\n- second"
  673. def test_triage_debug_emits_submit_and_result():
  674. sink = FakeDebugSink()
  675. service, _, clock, _, lane = _triage_service(debug_sink=sink)
  676. service.handle_event(_transcript(clock, "hello"))
  677. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  678. service.tick()
  679. submits = [event for event in sink.events if event[0] == "triage-submit"]
  680. assert submits == [
  681. ("triage-submit", {"trigger": "settled", "window": 1, "generation": 0})
  682. ]
  683. _, _, _, gen = lane.submits[0]
  684. service._on_triage_result(gen, _escalated_payload())
  685. results = [event for event in sink.events if event[0] == "triage-result"]
  686. assert len(results) == 1
  687. assert results[0][1]["escalated"] is True
  688. assert results[0][1]["generation"] == 0
  689. def test_triage_debug_marks_periodic_trigger():
  690. sink = FakeDebugSink()
  691. service, _, clock, _, lane = _triage_service(debug_sink=sink)
  692. service.cfg.triage.periodic_s = 0.2
  693. service.handle_event(_transcript(clock, "hello"))
  694. clock.advance(0.25)
  695. service.tick()
  696. submits = [event for event in sink.events if event[0] == "triage-submit"]
  697. assert submits[0][1]["trigger"] == "periodic"
  698. def test_triage_debug_emits_brief_dispatch():
  699. sink = FakeDebugSink()
  700. service, _, clock, _, lane = _triage_service(
  701. brief_fn=lambda prompt: "RAW", debug_sink=sink
  702. )
  703. service.handle_event(_transcript(clock, "hello"))
  704. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  705. service.tick()
  706. _, _, _, gen = lane.submits[0]
  707. service._on_triage_result(gen, _escalated_payload())
  708. brief = [event for event in sink.events if event[0] == "triage-brief"]
  709. assert brief == [("triage-brief", {"action": "dispatch", "generation": 0})]
  710. def test_triage_debug_emits_brief_gate_skip():
  711. sink = FakeDebugSink()
  712. service, _, clock, _, lane = _triage_service(
  713. triage=FakeTriage(gate=False), brief_fn=lambda prompt: "RAW", debug_sink=sink
  714. )
  715. service.handle_event(_transcript(clock, "hello"))
  716. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  717. service.tick()
  718. _, _, _, gen = lane.submits[0]
  719. service._on_triage_result(gen, _escalated_payload())
  720. brief = [event for event in sink.events if event[0] == "triage-brief"]
  721. assert brief == [
  722. ("triage-brief", {"action": "skip", "reason": "gate", "generation": 0})
  723. ]
  724. def test_maybe_triage_skips_unready_lane():
  725. service, _, clock, _, lane = _triage_service(lane=FakeLane(ready=False))
  726. service.handle_event(_transcript(clock, "hello"))
  727. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  728. service.tick()
  729. assert lane.submits == []
  730. def test_maybe_triage_skips_without_questions():
  731. service, _, clock, triage, lane = _triage_service(
  732. triage=FakeTriage(questions=None)
  733. )
  734. service.handle_event(_transcript(clock, "hello"))
  735. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  736. service.tick()
  737. assert lane.submits == []
  738. assert triage.build_state_calls == []
  739. def test_maybe_triage_dedupes_identical_window():
  740. service, _, clock, triage, lane = _triage_service()
  741. service.handle_event(_transcript(clock, "hello"))
  742. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  743. service.tick()
  744. assert len(lane.submits) == 1
  745. state, questions, lang, gen = lane.submits[0]
  746. assert state == "- hello"
  747. assert questions is triage.questions
  748. assert lang is None
  749. assert gen == 0
  750. service.tick()
  751. service.tick()
  752. assert len(lane.submits) == 1
  753. service.handle_event(_transcript(clock, "second"))
  754. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  755. service.tick()
  756. assert len(lane.submits) == 2
  757. assert lane.submits[1][0] == "- hello\n- second"
  758. def test_second_transcript_produces_second_submit():
  759. service, _, clock, _, lane = _triage_service()
  760. service.handle_event(_transcript(clock, "first"))
  761. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  762. service.tick()
  763. assert len(lane.submits) == 1
  764. service.handle_event(_transcript(clock, "second"))
  765. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  766. service.tick()
  767. assert len(lane.submits) == 2
  768. assert lane.submits[1][0] == "- first\n- second"
  769. def test_tick_under_50ms_with_blocked_lane():
  770. service, _, clock, _, lane = _triage_service()
  771. assert not lane.predict_gate.is_set()
  772. service.toggle_chat()
  773. service.handle_event(_transcript(clock, "hello"))
  774. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  775. start = time.perf_counter()
  776. service.tick()
  777. elapsed = time.perf_counter() - start
  778. assert len(lane.submits) == 1
  779. assert elapsed < 0.05
  780. def test_on_triage_result_emits_signals():
  781. service, emitted, clock, _, lane = _triage_service()
  782. service.toggle_chat()
  783. service.handle_event(_transcript(clock, "hello"))
  784. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  785. service.tick()
  786. _, _, _, gen = lane.submits[0]
  787. payload = {
  788. "order": ["urgency"],
  789. "items": {"urgency": {"kind": "noul"}},
  790. "escalated": False,
  791. "input_tokens": 12,
  792. }
  793. service._on_triage_result(gen, payload)
  794. staged = _triage_events(emitted)
  795. assert len(staged) == 1
  796. assert staged[0]["stage"] == "signals"
  797. assert staged[0]["triage"] == service.last_triage
  798. assert staged[0]["triage"]["escalated"] is False
  799. assert staged[0]["triage"]["input_tokens"] == 12
  800. assert service.status()["triage"] == service.last_triage
  801. def test_triage_events_carry_the_server_timestamp():
  802. service, emitted, clock, _, lane = _triage_service(brief_fn=lambda prompt: "RAW")
  803. service.toggle_chat()
  804. service.handle_event(_transcript(clock, "hello"))
  805. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  806. service.tick()
  807. _, _, _, gen = lane.submits[0]
  808. expected_ts = clock()
  809. service._on_triage_result(gen, _escalated_payload())
  810. signals = [e for e in _triage_events(emitted) if e.get("stage") == "signals"]
  811. assert len(signals) == 1
  812. assert isinstance(signals[0]["ts"], (int, float))
  813. assert signals[0]["ts"] == expected_ts
  814. job = [j for j in service._inference._queue if j.name == "brief-update"][0]
  815. job.run()
  816. contents = [e for e in _triage_events(emitted) if e.get("stage") == "content"]
  817. assert len(contents) == 1
  818. assert isinstance(contents[0]["ts"], (int, float))
  819. assert contents[0]["ts"] == expected_ts # content reuses the signals timestamp
  820. def test_on_triage_result_suppresses_stale_generation():
  821. service, emitted, clock, _, lane = _triage_service()
  822. service.toggle_chat()
  823. service.handle_event(_transcript(clock, "hello"))
  824. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  825. service.tick()
  826. _, _, _, gen = lane.submits[0]
  827. service.clear()
  828. service._on_triage_result(gen, _escalated_payload())
  829. assert service.last_triage is None
  830. assert [e for e in _triage_events(emitted) if e.get("stage") == "signals"] == []
  831. service.handle_event(_transcript(clock, "hello"))
  832. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  833. service.tick()
  834. assert len(lane.submits) == 2
  835. def test_pending_brief_capped_by_char_budget():
  836. """The buffer keeps the newest deltas within budget, dropping the oldest."""
  837. service, _, clock, _, _ = _triage_service(brief_fn=lambda prompt: "RAW")
  838. service.cfg.triage.brief_pending_char_budget = 30
  839. service.handle_event(_transcript(clock, "aaa"))
  840. service.handle_event(_transcript(clock, "bbbb"))
  841. assert service._pending_brief == ["Unknown: aaa", "Unknown: bbbb"]
  842. service.handle_event(_transcript(clock, "ccccc"))
  843. assert service._pending_brief == ["Unknown: bbbb", "Unknown: ccccc"]
  844. assert service.triage_history == ["aaa", "bbbb", "ccccc"]
  845. def test_pending_brief_untouched_without_triage():
  846. service, _, clock = _service()
  847. service.handle_event(_transcript(clock, "hello"))
  848. assert service._pending_brief == []
  849. assert service.triage_history == ["hello"]
  850. def test_on_triage_result_accepts_non_chat_mode():
  851. service, emitted, clock, _, lane = _triage_service()
  852. service.handle_event(_transcript(clock, "hello"))
  853. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  854. service.tick()
  855. _, _, _, gen = lane.submits[0]
  856. window = service._last_triage_window
  857. service._on_triage_result(gen, _escalated_payload())
  858. assert service.last_triage is not None
  859. assert service._last_triage_window == window
  860. assert [e.get("stage") for e in _triage_events(emitted)] == ["signals"]
  861. def test_on_triage_result_ignores_none_payload():
  862. service, emitted, clock, _, lane = _triage_service()
  863. service.toggle_chat()
  864. service.handle_event(_transcript(clock, "hello"))
  865. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  866. service.tick()
  867. _, _, _, gen = lane.submits[0]
  868. service._on_triage_result(gen, None)
  869. assert service.last_triage is None
  870. assert _triage_events(emitted) == []
  871. def test_none_payload_dispatches_nothing_and_keeps_deltas():
  872. """A Laya predict failure never dispatches: no job, no events, deltas stay."""
  873. calls: list[str] = []
  874. service, emitted, clock, _, lane = _triage_service(
  875. brief_fn=lambda prompt: calls.append(prompt) or "RAW"
  876. )
  877. service.toggle_chat()
  878. service.handle_event(_transcript(clock, "hello"))
  879. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  880. service.tick()
  881. _, _, _, gen = lane.submits[0]
  882. assert service._pending_brief == ["Unknown: hello"]
  883. service._on_triage_result(gen, None)
  884. assert service.last_triage is None
  885. assert [e.get("stage") for e in _triage_events(emitted)] == []
  886. assert [j.name for j in service._inference._queue] == ["chat"]
  887. assert calls == []
  888. assert service._pending_brief == ["Unknown: hello"]
  889. assert service._brief_outstanding is False
  890. def test_none_payload_without_brief_fn_enqueues_nothing():
  891. service, emitted, clock, _, lane = _triage_service()
  892. service.toggle_chat()
  893. service.handle_event(_transcript(clock, "hello"))
  894. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  895. service.tick()
  896. _, _, _, gen = lane.submits[0]
  897. service._on_triage_result(gen, None)
  898. assert service.last_triage is None
  899. assert _triage_events(emitted) == []
  900. assert [j.name for j in service._inference._queue] == ["chat"]
  901. assert service._pending_brief == ["Unknown: hello"]
  902. def test_on_triage_result_ignores_empty_signals():
  903. service, emitted, clock, _, lane = _triage_service(
  904. triage=FakeTriage(normalized={})
  905. )
  906. service.toggle_chat()
  907. service.handle_event(_transcript(clock, "hello"))
  908. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  909. service.tick()
  910. _, _, _, gen = lane.submits[0]
  911. service._on_triage_result(gen, _escalated_payload())
  912. assert service.last_triage is None
  913. assert _triage_events(emitted) == []
  914. def test_substantive_turn_dispatches_one_brief_job():
  915. """A substantive settled turn calls the gate once and queues one brief job."""
  916. service, emitted, clock, triage, lane = _triage_service(
  917. triage=FakeTriage(escalate=True), brief_fn=lambda prompt: "RAW"
  918. )
  919. service.toggle_chat()
  920. service.handle_event(_transcript(clock, "we might churn"))
  921. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  922. service.tick()
  923. _, _, _, gen = lane.submits[0]
  924. service._on_triage_result(
  925. gen, {"order": [], "items": {}, "escalated": False, "input_tokens": 0}
  926. )
  927. assert service.last_triage is not None
  928. assert service.last_triage["escalated"] is True
  929. assert service._last_brief_signals == service.last_triage
  930. assert service._inference.depth() == 2
  931. assert [j.name for j in service._inference._queue] == ["chat", "brief-update"]
  932. assert [e.get("stage") for e in _triage_events(emitted)] == ["signals"]
  933. assert len(triage.gate_calls) == 1
  934. assert service._brief_outstanding is True
  935. assert service._brief_token == 1
  936. def test_brief_dispatches_without_escalation():
  937. service, _, clock, _, lane = _triage_service(brief_fn=lambda prompt: "RAW")
  938. service.toggle_chat()
  939. service.handle_event(_transcript(clock, "all calm"))
  940. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  941. service.tick()
  942. _, _, _, gen = lane.submits[0]
  943. service._on_triage_result(
  944. gen, {"order": [], "items": {}, "escalated": False, "input_tokens": 0}
  945. )
  946. assert service.last_triage is not None
  947. assert service._inference.depth() == 2
  948. assert [j.name for j in service._inference._queue] == ["chat", "brief-update"]
  949. def test_gated_out_turn_skips_brief():
  950. """A gated-out turn stores signals but never calls brief_fn."""
  951. calls: list[str] = []
  952. service, emitted, clock, triage, lane = _triage_service(
  953. triage=FakeTriage(gate=False),
  954. brief_fn=lambda prompt: calls.append(prompt) or "RAW",
  955. )
  956. service.toggle_chat()
  957. service.handle_event(_transcript(clock, "small talk"))
  958. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  959. service.tick()
  960. _, _, _, gen = lane.submits[0]
  961. service._on_triage_result(gen, _escalated_payload())
  962. assert service.last_triage is not None
  963. assert "brief" not in service.last_triage # no prior brief to retain
  964. assert [e.get("stage") for e in _triage_events(emitted)] == ["signals"]
  965. assert calls == []
  966. assert [j.name for j in service._inference._queue] == ["chat"]
  967. assert service._brief_outstanding is False
  968. assert len(triage.gate_calls) == 1
  969. def test_gated_out_turn_retains_previous_brief():
  970. """A gated-out settled turn keeps the last accepted brief in the panel."""
  971. service, emitted, clock, triage, lane = _triage_service(
  972. triage=FakeTriage(gate=False), brief_fn=lambda prompt: "RAW"
  973. )
  974. service.toggle_chat()
  975. signals = _escalated_payload()
  976. service._last_brief_signals = signals
  977. token = _seed_brief(service, "Unknown: first")
  978. service._run_brief_update(0, signals, service._now(), token)
  979. assert service.last_triage is not None
  980. assert service.last_triage["brief"] == "RAW"
  981. emitted.clear()
  982. service.handle_event(_transcript(clock, "small talk"))
  983. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  984. service.tick()
  985. _, _, _, gen = lane.submits[0]
  986. service._on_triage_result(gen, _escalated_payload())
  987. assert service.last_triage is not None
  988. assert service.last_triage["brief"] == "RAW"
  989. assert "brief" not in service._last_brief_signals # raw signals stay raw
  990. staged = [e for e in _triage_events(emitted) if e.get("stage") == "signals"]
  991. assert len(staged) == 1
  992. assert staged[0]["triage"] == service.last_triage
  993. assert staged[0]["triage"]["brief"] == "RAW"
  994. assert len(triage.gate_calls) == 1
  995. def test_gated_out_turn_retains_brief_when_extract_disabled():
  996. """`extract_enabled = false` skips the dispatch but still retains the brief."""
  997. service, emitted, clock, _, lane = _triage_service(
  998. triage=FakeTriage(gate=False), brief_fn=lambda prompt: "RAW"
  999. )
  1000. service.toggle_chat()
  1001. signals = _escalated_payload()
  1002. service._last_brief_signals = signals
  1003. token = _seed_brief(service, "Unknown: first")
  1004. service._run_brief_update(0, signals, service._now(), token)
  1005. assert service.last_triage is not None
  1006. assert service.last_triage["brief"] == "RAW"
  1007. service.cfg.triage.extract_enabled = False
  1008. emitted.clear()
  1009. service.handle_event(_transcript(clock, "small talk"))
  1010. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  1011. service.tick()
  1012. _, _, _, gen = lane.submits[0]
  1013. service._on_triage_result(gen, _escalated_payload())
  1014. assert service.last_triage is not None
  1015. assert service.last_triage["brief"] == "RAW"
  1016. assert [j.name for j in service._inference._queue] == ["chat"]
  1017. staged = [e for e in _triage_events(emitted) if e.get("stage") == "signals"]
  1018. assert staged[0]["triage"]["brief"] == "RAW"
  1019. def test_gated_out_turn_retains_brief_without_brief_fn():
  1020. """No brief_fn means no dispatch, but a retained brief is still carried."""
  1021. service, emitted, clock, _, lane = _triage_service(triage=FakeTriage(gate=False))
  1022. service.toggle_chat()
  1023. service.last_triage = {**_escalated_payload(), "brief": "KEEP"}
  1024. emitted.clear()
  1025. service.handle_event(_transcript(clock, "small talk"))
  1026. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  1027. service.tick()
  1028. _, _, _, gen = lane.submits[0]
  1029. service._on_triage_result(gen, _escalated_payload())
  1030. assert service.last_triage["brief"] == "KEEP"
  1031. staged = [e for e in _triage_events(emitted) if e.get("stage") == "signals"]
  1032. assert staged[0]["triage"]["brief"] == "KEEP"
  1033. def test_later_accepted_update_replaces_retained_brief():
  1034. """A later accepted update overwrites the retained brief text."""
  1035. texts = iter(["OLD", "NEW"])
  1036. service, emitted, _, _, _ = _triage_service(brief_fn=lambda prompt: next(texts))
  1037. service.toggle_chat()
  1038. signals = _escalated_payload()
  1039. service._last_brief_signals = signals
  1040. token = _seed_brief(service, "Unknown: first")
  1041. service._run_brief_update(0, signals, service._now(), token)
  1042. assert service.last_triage is not None
  1043. assert service.last_triage["brief"] == "OLD"
  1044. token = _seed_brief(service, "Unknown: second")
  1045. service._run_brief_update(0, signals, service._now(), token)
  1046. assert service.last_triage is not None
  1047. assert service.last_triage["brief"] == "NEW"
  1048. contents = [e for e in _triage_events(emitted) if e.get("stage") == "content"]
  1049. assert contents[-1]["triage"]["brief"] == "NEW"
  1050. service.clear()
  1051. assert service.last_triage is None
  1052. def test_no_brief_when_disabled_in_config():
  1053. calls: list[str] = []
  1054. service, _, clock, _, lane = _triage_service(
  1055. triage=FakeTriage(escalate=True),
  1056. brief_fn=lambda prompt: calls.append(prompt) or "RAW",
  1057. )
  1058. service.cfg.triage.extract_enabled = False
  1059. service.toggle_chat()
  1060. service.handle_event(_transcript(clock, "churn risk"))
  1061. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  1062. service.tick()
  1063. _, _, _, gen = lane.submits[0]
  1064. service._on_triage_result(gen, _escalated_payload())
  1065. assert service.last_triage is not None
  1066. assert service.last_triage["escalated"] is True
  1067. assert calls == []
  1068. assert [j.name for j in service._inference._queue] == ["chat"]
  1069. def test_no_brief_without_brief_fn():
  1070. service, _, clock, _, lane = _triage_service(triage=FakeTriage(escalate=True))
  1071. service.toggle_chat()
  1072. service.handle_event(_transcript(clock, "churn risk"))
  1073. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  1074. service.tick()
  1075. _, _, _, gen = lane.submits[0]
  1076. service._on_triage_result(gen, _escalated_payload())
  1077. assert service.last_triage is not None
  1078. assert [j.name for j in service._inference._queue] == ["chat"]
  1079. assert service._brief_outstanding is False
  1080. def test_brief_refused_when_queue_full():
  1081. """A refused submit leaves deltas buffered and the outstanding flag clear."""
  1082. service, emitted, clock, _, lane = _triage_service(
  1083. triage=FakeTriage(escalate=True), brief_fn=lambda prompt: "RAW"
  1084. )
  1085. service._inference = InferenceQueue(size=2)
  1086. service.toggle_chat()
  1087. service.handle_event(_transcript(clock, "churn risk"))
  1088. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  1089. service.tick()
  1090. assert service._inference.depth() == 1
  1091. _, _, _, gen = lane.submits[0]
  1092. service._on_triage_result(gen, _escalated_payload())
  1093. assert service._inference.depth() == 1
  1094. assert service._inference._queue[0].name == "chat"
  1095. assert service.last_triage is not None
  1096. assert service.last_triage["escalated"] is True
  1097. assert [e.get("stage") for e in _triage_events(emitted)] == ["signals"]
  1098. assert service._pending_brief == ["Unknown: churn risk"]
  1099. assert service._brief_outstanding is False
  1100. def test_second_result_while_outstanding_is_refused():
  1101. """At most one brief job is outstanding: the second turn only stores signals."""
  1102. service, emitted, clock, _, lane = _triage_service(brief_fn=lambda prompt: "RAW")
  1103. service.toggle_chat()
  1104. service.handle_event(_transcript(clock, "first"))
  1105. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  1106. service.tick()
  1107. _, _, _, gen0 = lane.submits[0]
  1108. service._on_triage_result(gen0, _escalated_payload())
  1109. assert [j.name for j in service._inference._queue] == ["chat", "brief-update"]
  1110. service.handle_event(_transcript(clock, "second"))
  1111. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  1112. service.tick()
  1113. _, _, _, gen1 = lane.submits[1]
  1114. service._on_triage_result(gen1, _escalated_payload())
  1115. jobs = [j for j in service._inference._queue if j.name == "brief-update"]
  1116. assert len(jobs) == 1
  1117. assert [e.get("stage") for e in _triage_events(emitted)] == ["signals", "signals"]
  1118. assert service._brief_outstanding is True
  1119. assert service._pending_brief == ["Unknown: first", "Unknown: second"]
  1120. def _seed_brief(service, *deltas):
  1121. service._pending_brief = list(deltas)
  1122. service._brief_outstanding = True
  1123. return service._brief_token
  1124. def test_ledger_records_fact_and_survives_model_reemit():
  1125. """A recorded fact persists even when a later reply omits it."""
  1126. first = _brief_reply("Summary: rolling", ["The budget was $305 million."])
  1127. second = _brief_reply("Summary: newer", [])
  1128. replies = iter([first, second])
  1129. service, _, _, _, _ = _triage_service(brief_fn=lambda prompt: next(replies))
  1130. service._pending_brief = ["Unknown: one"]
  1131. service._brief_outstanding = True
  1132. service._run_brief_update(0, _escalated_payload(), service._now(), service._brief_token)
  1133. service._pending_brief = ["Unknown: two"]
  1134. service._brief_outstanding = True
  1135. service._run_brief_update(0, _escalated_payload(), service._now(), service._brief_token)
  1136. assert service.last_triage is not None
  1137. brief = service.last_triage["brief"]
  1138. assert "The budget was $305 million." in brief
  1139. assert service._fact_ledger.facts() == ["The budget was $305 million."]
  1140. def test_ledger_dedupes_repeated_fact():
  1141. """The same fact proposed twice is recorded once."""
  1142. reply = _brief_reply("Summary: s", ["Sense could find prey.", "sense could find prey"])
  1143. service, _, _, _, _ = _triage_service(brief_fn=lambda prompt: reply)
  1144. service._pending_brief = ["Unknown: one"]
  1145. service._brief_outstanding = True
  1146. service._run_brief_update(0, _escalated_payload(), service._now(), service._brief_token)
  1147. assert service._fact_ledger.facts() == ["Sense could find prey."]
  1148. def test_ledger_prompt_carries_ledger_and_narrative():
  1149. """The brief request hands the model the ledger, narrative, and new deltas."""
  1150. seen: list[str] = []
  1151. service, _, _, _, _ = _triage_service(
  1152. brief_fn=lambda prompt: seen.append(prompt) or _brief_reply("UPDATED")
  1153. )
  1154. service._fact_ledger.merge(["PRIOR FACT"])
  1155. service._last_brief_narrative = "PRIOR NARRATIVE"
  1156. service._pending_brief = ["Unknown: hello there"]
  1157. service._brief_outstanding = True
  1158. service._run_brief_update(0, _escalated_payload(), service._now(), service._brief_token)
  1159. assert len(seen) == 1
  1160. assert "CURRENT LEDGER:" in seen[0]
  1161. assert "- PRIOR FACT" in seen[0]
  1162. assert "CURRENT BRIEF:\nPRIOR NARRATIVE" in seen[0]
  1163. assert "NEW UTTERANCES:\n- Unknown: hello there" in seen[0]
  1164. def test_brief_merges_content_and_writes_file():
  1165. brief_file = FakeBriefFile()
  1166. service, emitted, _, triage, _ = _triage_service(
  1167. brief_fn=lambda prompt: "the brief", brief_file=brief_file
  1168. )
  1169. service.toggle_chat()
  1170. signals = _escalated_payload()
  1171. service._last_brief_signals = signals
  1172. token = _seed_brief(service, "Unknown: hello")
  1173. ts = service._now()
  1174. service._run_brief_update(0, signals, ts, token)
  1175. contents = [e for e in _triage_events(emitted) if e.get("stage") == "content"]
  1176. assert len(contents) == 1
  1177. assert contents[0]["triage"] == {**signals, "brief": "the brief"}
  1178. assert service.last_triage == contents[0]["triage"]
  1179. assert triage.prompt_calls == [(("Unknown: hello",), signals)]
  1180. assert brief_file.writes == ["the brief"]
  1181. assert service._pending_brief == []
  1182. assert service._brief_outstanding is False
  1183. def test_empty_brief_requeues_deltas():
  1184. """A `""` reply keeps signals, re-buffers the deltas, and clears the flag."""
  1185. service, emitted, _, _, _ = _triage_service(brief_fn=lambda prompt: "")
  1186. service.toggle_chat()
  1187. signals = _escalated_payload()
  1188. service.last_triage = signals
  1189. service._last_brief_signals = signals
  1190. token = _seed_brief(service, "Unknown: hello")
  1191. ts = service._now()
  1192. service._run_brief_update(0, signals, ts, token)
  1193. assert [e for e in _triage_events(emitted) if e.get("stage") == "content"] == []
  1194. assert service.last_triage == signals
  1195. assert "brief" not in service.last_triage
  1196. assert service._pending_brief == ["Unknown: hello"]
  1197. assert service._brief_outstanding is False
  1198. def test_brief_error_requeues_and_clears_flag():
  1199. """A raising brief_fn leaves the flag clear and the deltas buffered."""
  1200. def boom(prompt):
  1201. raise RuntimeError("llm down")
  1202. service, emitted, _, _, _ = _triage_service(brief_fn=boom)
  1203. service.toggle_chat()
  1204. token = _seed_brief(service, "Unknown: hello")
  1205. ts = service._now()
  1206. service._run_brief_update(0, _escalated_payload(), ts, token)
  1207. assert _triage_events(emitted) == []
  1208. assert service.last_triage is None
  1209. assert service._pending_brief == ["Unknown: hello"]
  1210. assert service._brief_outstanding is False
  1211. def test_brief_empty_buffer_returns_early():
  1212. """An empty buffer returns early: no call, no event, flag cleared."""
  1213. calls: list[str] = []
  1214. service, emitted, _, _, _ = _triage_service(
  1215. brief_fn=lambda prompt: calls.append(prompt) or "RAW"
  1216. )
  1217. service.toggle_chat()
  1218. service._brief_outstanding = True
  1219. token = service._brief_token
  1220. ts = service._now()
  1221. assert service._pending_brief == []
  1222. service._run_brief_update(0, _escalated_payload(), ts, token)
  1223. assert calls == []
  1224. assert _triage_events(emitted) == []
  1225. assert service._brief_outstanding is False
  1226. def test_brief_suppressed_after_reset():
  1227. service, emitted, _, _, _ = _triage_service(brief_fn=lambda prompt: "RAW")
  1228. service.toggle_chat()
  1229. service._pending_brief = ["Unknown: hello"]
  1230. service._reset_triage()
  1231. emitted.clear()
  1232. service._run_brief_update(0, _escalated_payload(), service._now(), 0)
  1233. assert _triage_events(emitted) == []
  1234. assert service.last_triage is None
  1235. assert service._pending_brief == ["Unknown: hello"]
  1236. def test_brief_works_after_leaving_chat():
  1237. seen = []
  1238. service, emitted, _, _, _ = _triage_service(
  1239. brief_fn=lambda prompt: seen.append(prompt) or "RAW"
  1240. )
  1241. service.toggle_chat()
  1242. assert service.modes.exit_chat() is True
  1243. token = _seed_brief(service, "Unknown: hello")
  1244. signals = _escalated_payload()
  1245. service._last_brief_signals = signals
  1246. service._run_brief_update(0, signals, service._now(), token)
  1247. assert seen != []
  1248. assert [e.get("stage") for e in _triage_events(emitted)] == ["content"]
  1249. assert service.last_triage is not None
  1250. assert service.last_triage["brief"] == "RAW"
  1251. def test_deltas_arriving_during_call_survive_and_flush():
  1252. """Deltas appended mid-call are not consumed; the finally flushes them."""
  1253. service, emitted, clock, _, _ = _triage_service()
  1254. service.toggle_chat()
  1255. signals = _escalated_payload()
  1256. service._last_brief_signals = signals
  1257. token = _seed_brief(service, "Unknown: first")
  1258. appended: list[int] = []
  1259. def _brief(prompt, on_io=None, finalize=None):
  1260. if not appended:
  1261. appended.append(1)
  1262. service.handle_event(_transcript(clock, "during call"))
  1263. return _brief_reply("first brief")
  1264. service._brief_fn = _brief
  1265. service._run_brief_update(0, signals, clock(), token)
  1266. contents = [e for e in _triage_events(emitted) if e.get("stage") == "content"]
  1267. assert len(contents) == 1
  1268. assert contents[0]["triage"]["brief"] == "first brief"
  1269. flushed = [j for j in service._inference._queue if j.name == "brief-update"]
  1270. assert len(flushed) == 1
  1271. assert service._brief_outstanding is True
  1272. assert service._pending_brief == ["Unknown: during call"]
  1273. flushed[0].run()
  1274. contents = [e for e in _triage_events(emitted) if e.get("stage") == "content"]
  1275. assert len(contents) == 2
  1276. assert contents[1]["triage"]["brief"] == "first brief"
  1277. assert service._pending_brief == []
  1278. assert service._brief_outstanding is False
  1279. def test_in_flight_brief_after_clear_emits_and_writes_nothing():
  1280. """Stale in-flight job: no event, no file write, no requeue, flag untouched."""
  1281. brief_file = FakeBriefFile()
  1282. service, emitted, clock, _, lane = _triage_service(
  1283. brief_fn=lambda prompt: "RAW", brief_file=brief_file
  1284. )
  1285. service.toggle_chat()
  1286. service.handle_event(_transcript(clock, "hello"))
  1287. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  1288. service.tick()
  1289. _, _, _, gen = lane.submits[0]
  1290. service._on_triage_result(gen, _escalated_payload())
  1291. job = [j for j in service._inference._queue if j.name == "brief-update"][0]
  1292. assert service._brief_outstanding is True
  1293. service.clear()
  1294. assert service._brief_outstanding is False
  1295. token_after_clear = service._brief_token
  1296. emitted.clear()
  1297. job.run()
  1298. assert [e for e in _triage_events(emitted)] == []
  1299. assert brief_file.writes == []
  1300. assert service._pending_brief == []
  1301. assert service.last_triage is None
  1302. assert service._brief_token == token_after_clear
  1303. assert service._brief_outstanding is False
  1304. def test_clear_resets_triage():
  1305. resets: list[int] = []
  1306. chats: list[int] = []
  1307. brief_file = FakeBriefFile()
  1308. service, emitted, clock, _, lane = _triage_service(
  1309. triage=FakeTriage(escalate=True),
  1310. brief_fn=lambda prompt: "RAW",
  1311. brief_file=brief_file,
  1312. brief_reset=lambda: resets.append(1),
  1313. chat_reset=lambda: chats.append(1),
  1314. )
  1315. service.toggle_chat()
  1316. service.handle_event(_transcript(clock, "churn"))
  1317. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  1318. service.tick()
  1319. _, _, _, gen = lane.submits[0]
  1320. service._on_triage_result(gen, _escalated_payload())
  1321. assert service._inference.depth() == 2
  1322. assert service._pending_brief == ["Unknown: churn"]
  1323. assert service._brief_outstanding is True
  1324. token_before = service._brief_token
  1325. assert service.clear() is True
  1326. assert service._triage_generation == 1
  1327. assert service.last_triage is None
  1328. assert service._last_triage_window == ()
  1329. assert service.triage_history == []
  1330. assert service._pending_brief == []
  1331. assert service._brief_token == token_before + 1
  1332. assert service._brief_outstanding is False
  1333. assert service._last_brief_signals is None
  1334. assert resets == [1]
  1335. assert brief_file.clears == 1
  1336. assert chats == [1]
  1337. assert lane.drops == 1
  1338. assert service._inference.depth() == 0
  1339. assert list(service._inference._queue) == []
  1340. cleared = [e for e in _triage_events(emitted) if e.get("stage") == "cleared"]
  1341. assert len(cleared) == 1
  1342. assert cleared[0]["triage"] is None
  1343. assert {"type": "cleared"} in emitted
  1344. signals_before = len(
  1345. [e for e in _triage_events(emitted) if e.get("stage") == "signals"]
  1346. )
  1347. service._on_triage_result(gen, _escalated_payload())
  1348. assert service.last_triage is None
  1349. assert (
  1350. len([e for e in _triage_events(emitted) if e.get("stage") == "signals"])
  1351. == signals_before
  1352. )
  1353. submits_before = len(lane.submits)
  1354. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  1355. service.tick()
  1356. assert len(lane.submits) == submits_before
  1357. def test_exit_chat_does_not_reset_triage():
  1358. chats: list[int] = []
  1359. bresets: list[int] = []
  1360. brief_file = FakeBriefFile()
  1361. service, emitted, clock, _, lane = _triage_service(
  1362. brief_fn=lambda prompt: "RAW",
  1363. chat_reset=lambda: chats.append(1),
  1364. brief_reset=lambda: bresets.append(1),
  1365. brief_file=brief_file,
  1366. )
  1367. service.toggle_chat()
  1368. service.handle_event(_transcript(clock, "hello"))
  1369. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  1370. service.tick()
  1371. assert len(lane.submits) == 1
  1372. _, _, _, gen = lane.submits[0]
  1373. service._on_triage_result(gen, _escalated_payload())
  1374. assert service.last_triage is not None
  1375. assert service._triage_generation == 0
  1376. assert service.toggle_chat() is True
  1377. assert service.modes.mode.value == "idle"
  1378. assert service._triage_generation == 0
  1379. assert service.last_triage is not None
  1380. assert service._last_triage_window == ("hello",)
  1381. assert service.triage_history == ["hello"]
  1382. assert service._pending_brief == ["Unknown: hello"]
  1383. assert service._last_brief_signals is not None
  1384. assert service._brief_outstanding is True
  1385. assert lane.drops == 0
  1386. cleared = [e for e in _triage_events(emitted) if e.get("stage") == "cleared"]
  1387. assert cleared == []
  1388. assert chats == [1]
  1389. assert bresets == []
  1390. assert brief_file.clears == 0
  1391. def test_toggle_chat_enter_does_not_touch_triage():
  1392. """Entering chat resets only the chat buffers; the brief engine is independent."""
  1393. bresets: list[int] = []
  1394. brief_file = FakeBriefFile()
  1395. service, emitted, clock, _, lane = _triage_service(
  1396. brief_fn=lambda prompt: "RAW",
  1397. brief_reset=lambda: bresets.append(1),
  1398. brief_file=brief_file,
  1399. )
  1400. service.handle_event(_transcript(clock, "hello"))
  1401. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  1402. service.tick()
  1403. _, _, _, gen = lane.submits[0]
  1404. service._on_triage_result(gen, _escalated_payload())
  1405. triage_before = service.last_triage
  1406. pending_before = list(service._pending_brief)
  1407. assert service.toggle_chat() is True
  1408. assert service.modes.mode.value == "chat"
  1409. assert service._triage_generation == 0
  1410. assert service.last_triage is triage_before
  1411. assert service._last_triage_window == ("hello",)
  1412. assert service.triage_history == ["hello"]
  1413. assert service._pending_brief == pending_before
  1414. assert service._last_brief_signals is not None
  1415. assert service._brief_outstanding is True
  1416. assert lane.drops == 0
  1417. assert bresets == []
  1418. assert brief_file.clears == 0
  1419. cleared = [e for e in _triage_events(emitted) if e.get("stage") == "cleared"]
  1420. assert cleared == []
  1421. def test_clear_without_triage_emits_no_triage_event():
  1422. service, emitted, _ = _service()
  1423. brief_file = FakeBriefFile()
  1424. bresets: list[int] = []
  1425. service._brief_file = brief_file
  1426. service._brief_reset = lambda: bresets.append(1)
  1427. service.clear()
  1428. assert {"type": "cleared"} in emitted
  1429. assert _triage_events(emitted) == []
  1430. assert brief_file.clears == 1
  1431. assert bresets == []
  1432. def test_stale_brief_after_clear_does_not_clear_newer_dispatch_flag():
  1433. """A stale in-flight job must not clear a newer dispatch's outstanding flag."""
  1434. brief_file = FakeBriefFile()
  1435. service, emitted, clock, _, lane = _triage_service(
  1436. brief_fn=lambda prompt: "RAW", brief_file=brief_file
  1437. )
  1438. service.toggle_chat()
  1439. service.handle_event(_transcript(clock, "hello"))
  1440. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  1441. service.tick()
  1442. _, _, _, gen = lane.submits[0]
  1443. service._on_triage_result(gen, _escalated_payload())
  1444. stale_job = [j for j in service._inference._queue if j.name == "brief-update"][0]
  1445. assert service._brief_outstanding is True
  1446. service.clear()
  1447. # A fresh turn dispatches a new brief AFTER clear bumped the token.
  1448. service.handle_event(_transcript(clock, "fresh"))
  1449. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  1450. service.tick()
  1451. _, _, _, gen2 = lane.submits[1]
  1452. service._on_triage_result(gen2, _escalated_payload())
  1453. assert service._brief_outstanding is True
  1454. newer_token = service._brief_token
  1455. pending_before = list(service._pending_brief)
  1456. triage_before = service.last_triage
  1457. emitted.clear()
  1458. stale_job.run()
  1459. assert _triage_events(emitted) == []
  1460. assert brief_file.writes == []
  1461. assert service._pending_brief == pending_before
  1462. assert service._brief_outstanding is True
  1463. assert service._brief_token == newer_token
  1464. assert service.last_triage is triage_before
  1465. def test_clear_resets_chat_latch():
  1466. service, emitted, _ = _service()
  1467. service.toggle_chat()
  1468. service._chat_queue_full = True
  1469. service._pending_chat = ["stuck text"]
  1470. service.clear()
  1471. assert service._chat_queue_full is False
  1472. assert service._pending_chat == []
  1473. assert {"type": "cleared"} in emitted
  1474. def test_triage_end_to_end_signals_content_cleared():
  1475. """Two settled turns collapse into ONE brief job (single-outstanding guard).
  1476. The second `_on_triage_result` is refused as `"outstanding"`, so the queue
  1477. holds one `brief-update` that consumes both deltas and emits one `content`.
  1478. The panel keeps the FIRST turn's signals until the next settled turn (lag).
  1479. """
  1480. prompts: list[str] = []
  1481. service, emitted, clock, triage, lane = _triage_service(
  1482. brief_fn=lambda prompt: prompts.append(prompt) or "the brief"
  1483. )
  1484. service.toggle_chat()
  1485. service.handle_event(_transcript(clock, "first thought"))
  1486. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  1487. service.tick()
  1488. assert len(lane.submits) == 1
  1489. _, _, _, gen0 = lane.submits[0]
  1490. service._on_triage_result(
  1491. gen0, {"order": ["urgency"], "items": {}, "escalated": False, "input_tokens": 1}
  1492. )
  1493. assert [e.get("stage") for e in _triage_events(emitted)] == ["signals"]
  1494. assert prompts == []
  1495. assert service.last_triage is not None
  1496. assert service.last_triage["escalated"] is False
  1497. assert [j.name for j in service._inference._queue] == ["chat", "brief-update"]
  1498. triage._escalate = True
  1499. service.handle_event(_transcript(clock, "we might churn"))
  1500. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  1501. service.tick()
  1502. assert len(lane.submits) == 2
  1503. _, _, _, gen1 = lane.submits[1]
  1504. service._on_triage_result(gen1, _escalated_payload())
  1505. assert [e.get("stage") for e in _triage_events(emitted)] == ["signals", "signals"]
  1506. assert [j.name for j in service._inference._queue] == [
  1507. "chat",
  1508. "brief-update",
  1509. "chat",
  1510. ]
  1511. for job in [j for j in service._inference._queue if j.name == "brief-update"]:
  1512. job.run()
  1513. contents = [e for e in _triage_events(emitted) if e.get("stage") == "content"]
  1514. assert len(contents) == 1
  1515. assert len(prompts) == 1
  1516. deltas, _ = triage.prompt_calls[0]
  1517. assert deltas == ("Unknown: first thought", "Unknown: we might churn")
  1518. assert contents[0]["triage"]["escalated"] is False
  1519. assert contents[0]["triage"]["brief"] == "the brief"
  1520. assert service.last_triage == contents[0]["triage"]
  1521. assert service.status()["triage"] == contents[0]["triage"]
  1522. service.clear()
  1523. cleared = [e for e in _triage_events(emitted) if e.get("stage") == "cleared"]
  1524. assert len(cleared) == 1
  1525. assert cleared[0]["triage"] is None
  1526. assert service.last_triage is None
  1527. service._on_triage_result(gen1, _escalated_payload())
  1528. assert [e.get("stage") for e in _triage_events(emitted)] == [
  1529. "signals",
  1530. "signals",
  1531. "content",
  1532. "cleared",
  1533. ]
  1534. assert service.toggle_chat() is True
  1535. service.handle_event(_transcript(clock, "idle thought"))
  1536. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  1537. service.tick()
  1538. assert len(lane.submits) == 3
  1539. assert lane.submits[2][0].endswith("- idle thought")
  1540. def test_tick_emits_status_on_triage_state_change():
  1541. service, emitted, _, triage, _ = _triage_service(
  1542. triage=FakeTriage(state_pair=("loading", "warming up"))
  1543. )
  1544. service.tick()
  1545. statuses = [e for e in emitted if e["type"] == "status"]
  1546. assert len(statuses) == 1
  1547. assert statuses[0]["triage_state"] == "loading"
  1548. assert statuses[0]["triage_reason"] == "warming up"
  1549. assert "triage" in statuses[0]
  1550. triage._state_pair = ("ok", "")
  1551. service.tick()
  1552. statuses = [e for e in emitted if e["type"] == "status"]
  1553. assert len(statuses) == 2
  1554. assert statuses[1]["triage_state"] == "ok"
  1555. assert statuses[1]["triage_reason"] == ""
  1556. assert "triage" in statuses[1]
  1557. service.tick()
  1558. assert len([e for e in emitted if e["type"] == "status"]) == 2
  1559. def test_no_status_emitted_when_triage_disabled():
  1560. service, emitted, _ = _service()
  1561. service.tick()
  1562. service.tick()
  1563. assert [e for e in emitted if e["type"] == "status"] == []
  1564. def test_tick_heals_triage_panel_after_lane_ready():
  1565. import time as _time
  1566. from pathlib import Path
  1567. from stt_daemon.assistant.laya_lane import LayaLane
  1568. from stt_daemon.assistant.triage import TriageAnalyzer
  1569. from stt_daemon.tui.state import ViewState
  1570. class _FakeRouter:
  1571. def preload(self, names):
  1572. return self
  1573. def predict(self, state, questions, model=None, lang=None, **kwargs):
  1574. if "_warmup" in questions:
  1575. return {"model": model, "answers": {}, "usage": {}, "routing": {}}
  1576. return {
  1577. "model": model,
  1578. "answers": {
  1579. "frustration": {
  1580. "noul": 0.1,
  1581. "confidence": 0.9,
  1582. "answer_confidence": 0.9,
  1583. },
  1584. "urgency": {
  1585. "choice": "low",
  1586. "confidence": 0.9,
  1587. "answer_confidence": 0.9,
  1588. },
  1589. },
  1590. "usage": {"input_tokens": 5},
  1591. }
  1592. def _factory(**kwargs):
  1593. return _FakeRouter()
  1594. cfg = Config()
  1595. cfg.assistant.turn_gap_s = 0.5
  1596. cfg.triage.questions_file = str(
  1597. Path(__file__).resolve().parent.parent / "questions.example.json"
  1598. )
  1599. clock = Clock()
  1600. emitted: list[dict] = []
  1601. def emit(type_, **fields):
  1602. emitted.append({"type": type_, **fields})
  1603. analyzer = TriageAnalyzer(cfg.triage)
  1604. assert analyzer.questions, "example questions must load"
  1605. holder: dict = {}
  1606. lane = LayaLane(
  1607. cfg.triage,
  1608. agent_factory=_factory,
  1609. on_result=lambda gen, payload: holder["svc"]._on_triage_result(gen, payload),
  1610. on_state=lambda state, reason: analyzer.refresh(state, reason),
  1611. )
  1612. service = AssistantService(
  1613. cfg,
  1614. FakeSubscriber(),
  1615. emit=emit,
  1616. time_fn=clock,
  1617. triage=analyzer,
  1618. laya_lane=lane,
  1619. chat_fn=_ok_reply,
  1620. )
  1621. holder["svc"] = service
  1622. try:
  1623. lane.start()
  1624. deadline = _time.monotonic() + 5.0
  1625. while not lane.ready() and _time.monotonic() < deadline:
  1626. _time.sleep(0.005)
  1627. assert lane.ready(), "lane did not become ready"
  1628. assert analyzer.state() == ("ok", "")
  1629. service.tick()
  1630. statuses = [e for e in emitted if e["type"] == "status"]
  1631. assert statuses, "tick emitted no status after lane ready"
  1632. assert statuses[-1]["triage_state"] == "ok"
  1633. service.handle_event(_transcript(clock, "hello"))
  1634. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  1635. service.tick()
  1636. deadline = _time.monotonic() + 5.0
  1637. while service.last_triage is None and _time.monotonic() < deadline:
  1638. _time.sleep(0.005)
  1639. assert service.last_triage is not None, "no triage signals from lane"
  1640. view = ViewState()
  1641. for event in emitted:
  1642. view.ingest(event)
  1643. assert view.triage_state == "ok"
  1644. lines = view.triage_lines()
  1645. assert lines
  1646. assert not any("unavailable" in line for line in lines)
  1647. assert not any("loading" in line for line in lines)
  1648. finally:
  1649. lane.stop()
  1650. def _dump_brief(prompt, on_io=None, finalize=None):
  1651. """Brief fake that mimics LlmClient.chat's on_io phases."""
  1652. if on_io is not None:
  1653. on_io({"phase": "request", "url": "http://llm/v1", "body": {"prompt": prompt}})
  1654. on_io({"phase": "response", "payload": {"content": "parsed"}, "error": None})
  1655. return _brief_reply("BRIEF")
  1656. def _run_triage_flow(service, emitted, clock, lane, payload):
  1657. service.toggle_chat()
  1658. service.handle_event(_transcript(clock, "hello"))
  1659. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  1660. service.tick()
  1661. _, _, _, gen = lane.submits[0]
  1662. service._on_triage_result(gen, payload)
  1663. return gen
  1664. def _dump_files(tmp_path):
  1665. return list(tmp_path.rglob("*.json"))
  1666. def test_dump_writes_full_laya_and_llm_io(tmp_path):
  1667. service, emitted, clock, triage, lane = _triage_service(brief_fn=_dump_brief)
  1668. service._triage_dump = TriageDumper(True, directory=str(tmp_path))
  1669. service.cfg.triage.dump_io = True
  1670. _run_triage_flow(service, emitted, clock, lane, _escalated_payload())
  1671. jobs = [j for j in service._inference._queue if j.name == "brief-update"]
  1672. assert len(jobs) == 1
  1673. jobs[0].run()
  1674. files = _dump_files(tmp_path)
  1675. assert len(files) == 1
  1676. assert re.fullmatch(r"\d{6}-\d{3}\.json", files[0].name)
  1677. data = json.loads(files[0].read_text(encoding="utf-8"))
  1678. assert data["ts"] == clock()
  1679. assert isinstance(data["iso"], str) and data["iso"]
  1680. assert data["laya"]["request"]["state"] == "- hello"
  1681. assert data["laya"]["request"]["questions"] == triage.questions
  1682. assert data["laya"]["request"]["model"] == "multilingual"
  1683. assert data["laya"]["request"]["max_len"] == 1024
  1684. assert data["laya"]["response"] == _escalated_payload()
  1685. assert data["laya"]["error"] is None
  1686. assert data["llm"]["request"]["url"] == "http://llm/v1"
  1687. assert data["llm"]["request"]["body"] == {
  1688. "prompt": "CURRENT LEDGER:\n(none yet)\n\nCURRENT BRIEF:\n(none yet)\n\n"
  1689. "NEW UTTERANCES:\n- Unknown: hello"
  1690. }
  1691. assert data["llm"]["response"] == {"content": "parsed"}
  1692. assert data["llm"]["error"] is None
  1693. assert service._triage_dump._pending == {}
  1694. def test_dump_laya_error_writes_laya_only_and_keeps_deltas(tmp_path):
  1695. """A Laya predict failure finalizes the Laya half with `llm: null`.
  1696. Nothing is dispatched, so no LLM half is ever recorded and the buffered
  1697. deltas survive for the next settled turn.
  1698. """
  1699. service, emitted, clock, _, lane = _triage_service(brief_fn=_dump_brief)
  1700. service._triage_dump = TriageDumper(True, directory=str(tmp_path))
  1701. service.cfg.triage.dump_io = True
  1702. _run_triage_flow(service, emitted, clock, lane, None)
  1703. assert [j.name for j in service._inference._queue] == ["chat"]
  1704. assert service._pending_brief == ["Unknown: hello"]
  1705. files = _dump_files(tmp_path)
  1706. assert len(files) == 1
  1707. data = json.loads(files[0].read_text(encoding="utf-8"))
  1708. assert data["laya"]["response"] is None
  1709. assert data["laya"]["error"] == "predict failed"
  1710. assert data["llm"] is None
  1711. assert service._triage_dump._pending == {}
  1712. def test_dump_without_brief_has_laya_only(tmp_path):
  1713. service, emitted, clock, _, lane = _triage_service(brief_fn=_dump_brief)
  1714. service._triage_dump = TriageDumper(True, directory=str(tmp_path))
  1715. service.cfg.triage.dump_io = True
  1716. service.cfg.triage.extract_enabled = False
  1717. _run_triage_flow(service, emitted, clock, lane, _escalated_payload())
  1718. files = _dump_files(tmp_path)
  1719. assert len(files) == 1
  1720. data = json.loads(files[0].read_text(encoding="utf-8"))
  1721. assert data["laya"]["response"] == _escalated_payload()
  1722. assert data["llm"] is None
  1723. assert service._triage_dump._pending == {}
  1724. def test_dump_queue_full_has_laya_only(tmp_path):
  1725. service, emitted, clock, _, lane = _triage_service(brief_fn=_dump_brief)
  1726. service._triage_dump = TriageDumper(True, directory=str(tmp_path))
  1727. service.cfg.triage.dump_io = True
  1728. service._inference = InferenceQueue(size=2)
  1729. _run_triage_flow(service, emitted, clock, lane, _escalated_payload())
  1730. assert service._inference.depth() == 1
  1731. assert [j.name for j in service._inference._queue] == ["chat"]
  1732. assert service._pending_brief == ["Unknown: hello"]
  1733. files = _dump_files(tmp_path)
  1734. assert len(files) == 1
  1735. data = json.loads(files[0].read_text(encoding="utf-8"))
  1736. assert data["laya"]["response"] == _escalated_payload()
  1737. assert data["llm"] is None
  1738. assert service._triage_dump._pending == {}
  1739. def test_dump_disabled_writes_nothing(tmp_path):
  1740. service, emitted, clock, _, lane = _triage_service(
  1741. brief_fn=lambda prompt: "RAW"
  1742. )
  1743. assert service._triage_dump.enabled is False
  1744. service._triage_dump = TriageDumper(False, directory=str(tmp_path))
  1745. _run_triage_flow(service, emitted, clock, lane, _escalated_payload())
  1746. jobs = [j for j in service._inference._queue if j.name == "brief-update"]
  1747. assert len(jobs) == 1
  1748. jobs[0].run()
  1749. assert _dump_files(tmp_path) == []
  1750. def test_dump_stale_result_discards_without_file(tmp_path):
  1751. service, emitted, clock, triage, lane = _triage_service(brief_fn=_dump_brief)
  1752. service._triage_dump = TriageDumper(True, directory=str(tmp_path))
  1753. service.cfg.triage.dump_io = True
  1754. service.toggle_chat()
  1755. service.handle_event(_transcript(clock, "hello"))
  1756. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  1757. service.tick()
  1758. _, _, _, gen = lane.submits[0]
  1759. real_normalize = triage.normalize
  1760. def stale_normalize(payload):
  1761. # Simulate a clear landing between the first check/begin and the re-check.
  1762. service._triage_generation += 1
  1763. return real_normalize(payload)
  1764. triage.normalize = stale_normalize
  1765. service._on_triage_result(gen, _escalated_payload())
  1766. assert _dump_files(tmp_path) == []
  1767. assert service._triage_dump._pending == {}
  1768. def test_dump_stale_brief_discards_without_file(tmp_path):
  1769. service, _, clock, _, _ = _triage_service(brief_fn=_dump_brief)
  1770. service._triage_dump = TriageDumper(True, directory=str(tmp_path))
  1771. service.cfg.triage.dump_io = True
  1772. ts = clock()
  1773. service._triage_dump.begin(ts, laya={"request": {}, "response": {}, "error": None})
  1774. service._pending_brief = ["Unknown: hello"]
  1775. service._triage_generation += 1 # stale before the brief even starts
  1776. service._run_brief_update(0, _escalated_payload(), ts, service._brief_token)
  1777. assert _dump_files(tmp_path) == []
  1778. assert service._triage_dump._pending == {}
  1779. assert service._pending_brief == ["Unknown: hello"]
  1780. def test_dump_brief_cleared_mid_flight_writes_nothing(tmp_path):
  1781. service, _, clock, _, _ = _triage_service(brief_fn=_dump_brief)
  1782. service._triage_dump = TriageDumper(True, directory=str(tmp_path))
  1783. service.cfg.triage.dump_io = True
  1784. def stale_brief(prompt, on_io=None, finalize=None):
  1785. # Simulate a clear landing mid-LLM-call (after the request phase fired).
  1786. service._triage_generation += 1
  1787. if on_io is not None:
  1788. on_io({"phase": "request", "url": "http://llm/v1", "body": {}})
  1789. on_io({"phase": "response", "payload": {"c": 1}, "error": None})
  1790. return _brief_reply("RAW")
  1791. service._brief_fn = stale_brief
  1792. service._pending_brief = ["Unknown: hello"]
  1793. service._brief_outstanding = True
  1794. token = service._brief_token
  1795. ts = clock()
  1796. service._triage_dump.begin(ts, laya={"request": {}, "response": {}, "error": None})
  1797. service._run_brief_update(0, _escalated_payload(), ts, token)
  1798. assert _dump_files(tmp_path) == []
  1799. assert service._triage_dump._pending == {}
  1800. assert service._pending_brief == []
  1801. assert service._brief_outstanding is False
  1802. def test_dump_gated_out_writes_laya_only_and_no_pending(tmp_path):
  1803. """A turn the gate leaves out writes `llm: null` and leaks no pending record."""
  1804. service, emitted, clock, triage, lane = _triage_service(
  1805. triage=FakeTriage(escalate=True, gate=False), brief_fn=_dump_brief
  1806. )
  1807. service._triage_dump = TriageDumper(True, directory=str(tmp_path))
  1808. service.cfg.triage.dump_io = True
  1809. _run_triage_flow(service, emitted, clock, lane, _escalated_payload())
  1810. assert [j.name for j in service._inference._queue] == ["chat"]
  1811. assert len(triage.gate_calls) == 1
  1812. files = _dump_files(tmp_path)
  1813. assert len(files) == 1
  1814. data = json.loads(files[0].read_text(encoding="utf-8"))
  1815. assert data["laya"]["response"] == _escalated_payload()
  1816. assert data["llm"] is None
  1817. assert service._triage_dump._pending == {}
  1818. def test_dump_coalesced_update_writes_laya_only_then_llm_only_flush(tmp_path):
  1819. """A coalesced turn writes a Laya-only record; the later flush a separate llm-only one."""
  1820. service, emitted, clock, _, lane = _triage_service(brief_fn=_dump_brief)
  1821. service._triage_dump = TriageDumper(True, directory=str(tmp_path))
  1822. service.cfg.triage.dump_io = True
  1823. service.toggle_chat()
  1824. service.handle_event(_transcript(clock, "first"))
  1825. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  1826. service.tick()
  1827. _, _, _, gen0 = lane.submits[0]
  1828. service._on_triage_result(gen0, _escalated_payload())
  1829. service.handle_event(_transcript(clock, "second"))
  1830. clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
  1831. service.tick()
  1832. _, _, _, gen1 = lane.submits[1]
  1833. service._on_triage_result(gen1, _escalated_payload())
  1834. assert service._brief_outstanding is True
  1835. appended: list[int] = []
  1836. def _brief(prompt, on_io=None, finalize=None):
  1837. if not appended:
  1838. appended.append(1)
  1839. service.handle_event(_transcript(clock, "during call"))
  1840. if on_io is not None:
  1841. on_io({"phase": "request", "url": "http://llm/v1", "body": {"prompt": prompt}})
  1842. on_io({"phase": "response", "payload": {"content": "parsed"}, "error": None})
  1843. return _brief_reply("BRIEF")
  1844. service._brief_fn = _brief
  1845. clock.advance(1.0)
  1846. job = [j for j in service._inference._queue if j.name == "brief-update"][0]
  1847. service._inference._queue.remove(job)
  1848. job.run()
  1849. flushed = [j for j in service._inference._queue if j.name == "brief-update"]
  1850. assert len(flushed) == 1
  1851. flushed[0].run()
  1852. assert service._triage_dump._pending == {}
  1853. records = [
  1854. json.loads(path.read_text(encoding="utf-8")) for path in _dump_files(tmp_path)
  1855. ]
  1856. assert len(records) == 3
  1857. coalesced = [r for r in records if r["laya"] is not None and r["llm"] is None]
  1858. flushed_records = [r for r in records if r["laya"] is None and r["llm"] is not None]
  1859. both = [r for r in records if r["laya"] is not None and r["llm"] is not None]
  1860. assert len(coalesced) == 1
  1861. assert len(flushed_records) == 1
  1862. assert len(both) == 1
  1863. assert coalesced[0]["ts"] != flushed_records[0]["ts"]
  1864. assert flushed_records[0]["llm"]["request"]["body"] == {
  1865. "prompt": "CURRENT LEDGER:\n(none yet)\n\nCURRENT BRIEF:\nBRIEF\n\n"
  1866. "NEW UTTERANCES:\n- Unknown: during call"
  1867. }
  1868. def test_chat_client_failure_emits_llm_error_and_service_survives():
  1869. """Adversarial (a): a chat client raising on `chat` surfaces as an `llm_error`
  1870. event and the service keeps functioning afterwards."""
  1871. from stt_daemon.assistant.llm import ConversationEngine, LlmError
  1872. class BoomClient:
  1873. def chat(self, messages, max_tokens=None, timeout_s=None, **kwargs):
  1874. raise LlmError("boom")
  1875. engine = ConversationEngine(Config().llm, BoomClient(), system_prompt="SYS")
  1876. service, emitted, clock = _service()
  1877. service.chat_fn = engine.send
  1878. assert service.toggle_chat() is True
  1879. service._run_chat("hello")
  1880. errors = [e for e in emitted if e["type"] == "error" and e.get("code") == "llm_error"]
  1881. assert errors and "boom" in errors[-1]["message"]
  1882. assert service.toggle_chat() is True
  1883. assert service.modes.mode.value == "idle"
  1884. # ---------------------------------------------------------------------------
  1885. # Conversation session adoption (SESSION/TRANSCRIPT session_dir).
  1886. # ---------------------------------------------------------------------------
  1887. def _session_event(clock, session_dir):
  1888. event = _ev(events.SESSION, clock)
  1889. event["session_id"] = session_dir.rsplit("/", 1)[-1]
  1890. event["session_dir"] = session_dir
  1891. return event
  1892. def _ring(service, clock, *items):
  1893. """Feed a daemon-seeded replay window: status -> items -> ring_end."""
  1894. service.handle_event(_ev(events.STATUS, clock))
  1895. for item in items:
  1896. service.handle_event(item)
  1897. service.handle_event(_ev(events.RING_END, clock))
  1898. def _cleared(emitted):
  1899. return [e for e in _triage_events(emitted) if e.get("stage") == "cleared"]
  1900. def test_status_includes_session_dir_without_brief_file():
  1901. service, _, clock = _service()
  1902. assert service.status()["session_dir"] is None
  1903. service.handle_event(_session_event(clock, "transcripts/2026-09-30-12-47-29"))
  1904. assert service.status()["session_dir"] == "transcripts/2026-09-30-12-47-29"
  1905. def test_live_session_event_sets_session_and_records_directory():
  1906. brief_file = FakeBriefFile()
  1907. service, _, clock, _, _ = _triage_service(brief_file=brief_file)
  1908. session = "transcripts/2026-09-30-12-47-29"
  1909. service.handle_event(_session_event(clock, session))
  1910. assert service.status()["session_dir"] == session
  1911. assert brief_file.directories == [session]
  1912. assert service._triage_generation == 0
  1913. def test_live_transcript_session_sets_session_without_wiping_utterance():
  1914. brief_file = FakeBriefFile()
  1915. service, _, clock, _, _ = _triage_service(brief_file=brief_file)
  1916. session = "transcripts/s1"
  1917. service.handle_event(_transcript(clock, "hello", session_dir=session))
  1918. assert service.status()["session_dir"] == session
  1919. assert brief_file.directories == [session]
  1920. assert service.triage_history == ["hello"]
  1921. assert service._pending_brief == ["Unknown: hello"]
  1922. assert service._triage_generation == 0
  1923. def test_brief_write_lands_under_session_dir(tmp_path):
  1924. from stt_daemon.assistant.brief_file import BriefFile
  1925. brief_file = BriefFile(True)
  1926. service, _, clock, _, _ = _triage_service(brief_file=brief_file)
  1927. session = str(tmp_path / "transcripts" / "s1")
  1928. service.handle_event(_transcript(clock, "hello", session_dir=session))
  1929. brief_file.write("the brief")
  1930. path = tmp_path / "transcripts" / "s1" / "brief.md"
  1931. assert path.read_text(encoding="utf-8") == "the brief"
  1932. def test_live_session_change_resets_triage_and_keeps_chat():
  1933. brief_file = FakeBriefFile()
  1934. resets: list[int] = []
  1935. service, emitted, clock, _, lane = _triage_service(
  1936. brief_file=brief_file, brief_reset=lambda: resets.append(1)
  1937. )
  1938. service.toggle_chat()
  1939. service.handle_event(_transcript(clock, "hello"))
  1940. service.handle_event(_session_event(clock, "transcripts/a"))
  1941. service.last_triage = {"signals": 1}
  1942. service._pending_brief = ["stale"]
  1943. emitted.clear()
  1944. service.handle_event(_session_event(clock, "transcripts/b"))
  1945. assert service.status()["session_dir"] == "transcripts/b"
  1946. assert service.last_triage is None
  1947. assert service._pending_brief == []
  1948. assert service._triage_generation == 1
  1949. assert service.chat_history == ["Unknown: hello"]
  1950. assert resets == [1]
  1951. assert lane.drops == 1
  1952. assert brief_file.directories == ["transcripts/a", "transcripts/b"]
  1953. assert len(_cleared(emitted)) == 1
  1954. def test_sessionless_transcript_does_not_reset():
  1955. service, _, clock, _, _ = _triage_service()
  1956. service.handle_event(_session_event(clock, "transcripts/a"))
  1957. service.last_triage = {"signals": 1}
  1958. service.handle_event(_transcript(clock, "hello"))
  1959. assert service._triage_generation == 0
  1960. assert service.last_triage == {"signals": 1}
  1961. assert service.status()["session_dir"] == "transcripts/a"
  1962. def test_same_dir_readoption_does_not_reset():
  1963. brief_file = FakeBriefFile()
  1964. service, _, clock, _, _ = _triage_service(brief_file=brief_file)
  1965. session = "transcripts/a"
  1966. service.handle_event(_session_event(clock, session))
  1967. service.last_triage = {"signals": 1}
  1968. service.handle_event(_transcript(clock, "again", session_dir=session))
  1969. assert service._triage_generation == 0
  1970. assert service.last_triage == {"signals": 1}
  1971. assert brief_file.directories == [session]
  1972. def test_session_change_without_brief_file_does_not_raise():
  1973. service, _, clock, _, _ = _triage_service(brief_file=None)
  1974. service.handle_event(_session_event(clock, "transcripts/a"))
  1975. service.handle_event(_session_event(clock, "transcripts/b"))
  1976. assert service.status()["session_dir"] == "transcripts/b"
  1977. assert service._triage_generation == 1
  1978. def test_replay_single_session_adopts_without_reset():
  1979. brief_file = FakeBriefFile()
  1980. service, emitted, clock, _, _ = _triage_service(brief_file=brief_file)
  1981. session = "transcripts/a"
  1982. _ring(service, clock, _transcript(clock, "hello", session_dir=session))
  1983. assert service.status()["session_dir"] == session
  1984. assert brief_file.directories == [session]
  1985. assert service._triage_generation == 0
  1986. assert _cleared(emitted) == []
  1987. assert service.triage_history == ["hello"]
  1988. def test_replay_two_sessions_commits_newest_and_resets_once():
  1989. brief_file = FakeBriefFile()
  1990. service, emitted, clock, _, _ = _triage_service(brief_file=brief_file)
  1991. a, b = "transcripts/a", "transcripts/b"
  1992. _ring(
  1993. service,
  1994. clock,
  1995. _session_event(clock, a),
  1996. _transcript(clock, "old turn", session_dir=a),
  1997. _session_event(clock, b),
  1998. _transcript(clock, "new turn", session_dir=b),
  1999. )
  2000. assert service.status()["session_dir"] == b
  2001. assert brief_file.directories == [b]
  2002. assert service._triage_generation == 1
  2003. assert service.last_triage is None
  2004. assert service._pending_brief == []
  2005. assert len(_cleared(emitted)) == 1
  2006. def test_reconnect_tailing_current_session_is_noop():
  2007. brief_file = FakeBriefFile()
  2008. service, emitted, clock, _, _ = _triage_service(brief_file=brief_file)
  2009. session = "transcripts/a"
  2010. service.handle_event(_session_event(clock, session))
  2011. service.last_triage = {"signals": 1}
  2012. emitted.clear()
  2013. _ring(service, clock, _transcript(clock, "replayed", session_dir=session))
  2014. assert service.status()["session_dir"] == session
  2015. assert brief_file.directories == [session]
  2016. assert service._triage_generation == 0
  2017. assert service.last_triage == {"signals": 1}
  2018. assert _cleared(emitted) == []
  2019. def test_reconnect_older_to_current_resets_once_without_rewind():
  2020. brief_file = FakeBriefFile()
  2021. service, emitted, clock, _, _ = _triage_service(brief_file=brief_file)
  2022. a, b = "transcripts/a", "transcripts/b"
  2023. service.handle_event(_session_event(clock, a))
  2024. service.last_triage = {"signals": 1}
  2025. emitted.clear()
  2026. _ring(
  2027. service,
  2028. clock,
  2029. _session_event(clock, a),
  2030. _transcript(clock, "old", session_dir=a),
  2031. _session_event(clock, b),
  2032. _transcript(clock, "new", session_dir=b),
  2033. )
  2034. assert service.status()["session_dir"] == b
  2035. assert brief_file.directories == [a, b]
  2036. assert service._triage_generation == 1
  2037. assert service.last_triage is None
  2038. assert len(_cleared(emitted)) == 1
  2039. def test_reconnect_only_newer_session_resets_once():
  2040. brief_file = FakeBriefFile()
  2041. service, _, clock, _, _ = _triage_service(brief_file=brief_file)
  2042. a, b = "transcripts/a", "transcripts/b"
  2043. service.handle_event(_session_event(clock, a))
  2044. service.last_triage = {"signals": 1}
  2045. _ring(service, clock, _transcript(clock, "new", session_dir=b))
  2046. assert service.status()["session_dir"] == b
  2047. assert service._triage_generation == 1
  2048. assert service.last_triage is None
  2049. assert brief_file.directories == [a, b]
  2050. def test_reconnect_span_older_current_clears_buffered_older_turns():
  2051. """A RING_END whose ring spanned an older session resets even when the
  2052. newest session already matches the adopted directory (no re-set_directory)."""
  2053. brief_file = FakeBriefFile()
  2054. service, emitted, clock, _, _ = _triage_service(brief_file=brief_file)
  2055. a, b = "transcripts/a", "transcripts/b"
  2056. _ring(service, clock, _session_event(clock, a))
  2057. assert service._triage_generation == 0
  2058. service.handle_event(_transcript(clock, "old turn", session_dir=a))
  2059. assert service._pending_brief == ["Unknown: old turn"]
  2060. service.handle_event(_session_event(clock, b))
  2061. assert service._triage_generation == 1
  2062. service.handle_event(_transcript(clock, "new turn", session_dir=b))
  2063. assert service._pending_brief == ["Unknown: new turn"]
  2064. emitted.clear()
  2065. _ring(
  2066. service,
  2067. clock,
  2068. _session_event(clock, a),
  2069. _transcript(clock, "old turn", session_dir=a),
  2070. _session_event(clock, b),
  2071. _transcript(clock, "new turn", session_dir=b),
  2072. )
  2073. assert service.status()["session_dir"] == b
  2074. assert brief_file.directories == [a, b]
  2075. assert service._pending_brief == []
  2076. assert service._triage_generation == 2
  2077. assert len(_cleared(emitted)) == 1
  2078. def test_daemon_restart_new_session_resets_once():
  2079. brief_file = FakeBriefFile()
  2080. service, _, clock, _, _ = _triage_service(brief_file=brief_file)
  2081. service.handle_event(_session_event(clock, "transcripts/a"))
  2082. service.last_triage = {"signals": 1}
  2083. service.handle_event(_session_event(clock, "transcripts/b"))
  2084. assert service.status()["session_dir"] == "transcripts/b"
  2085. assert service._triage_generation == 1
  2086. assert service.last_triage is None
  2087. assert brief_file.directories == ["transcripts/a", "transcripts/b"]