| 123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637638639640641642643644645646647648649650651652653654655656657658659660661662663664665666667668669670671672673674675676677678679680681682683684685686687688689690691692693694695696697698699700701702703704705706707708709710711712713714715716717718719720721722723724725726727728729730731732733734735736737738739740741742743744745746747748749750751752753754755756757758759760761762763764765766767768769770771772773774775776777778779780781782783784785786787788789790791792793794795796797798799800801802803804805806807808809810811812813814815816817818819820821822823824825826827828829830831832833834835836837838839840841842843844845846847848849850851852853854855856857858859860861862863864865866867868869870871872873874875876877878879880881882883884885886887888889890891892893894895896897898899900901902903904905906907908909910911912913914915916917918919920921922923924925926927928929930931932933934935936937938939940941942943944945946947948949950951952953954955956957958959960961962963964965966967968969970971972973974975976977978979980981982983984985986987988989990991992993994995996997998999100010011002100310041005100610071008100910101011101210131014101510161017101810191020102110221023102410251026102710281029103010311032103310341035103610371038103910401041104210431044104510461047104810491050105110521053105410551056105710581059106010611062106310641065106610671068106910701071107210731074107510761077107810791080108110821083108410851086108710881089109010911092109310941095109610971098109911001101110211031104110511061107110811091110111111121113111411151116111711181119112011211122112311241125112611271128112911301131113211331134113511361137113811391140114111421143114411451146114711481149115011511152115311541155115611571158115911601161116211631164116511661167116811691170117111721173117411751176117711781179118011811182118311841185118611871188118911901191119211931194119511961197119811991200120112021203120412051206120712081209121012111212121312141215121612171218121912201221122212231224122512261227122812291230123112321233123412351236123712381239124012411242124312441245124612471248124912501251125212531254125512561257125812591260126112621263126412651266126712681269127012711272127312741275127612771278127912801281128212831284128512861287128812891290129112921293129412951296129712981299130013011302130313041305130613071308130913101311131213131314131513161317131813191320132113221323132413251326132713281329133013311332133313341335133613371338133913401341134213431344134513461347134813491350135113521353135413551356135713581359136013611362136313641365136613671368136913701371137213731374137513761377137813791380138113821383138413851386138713881389139013911392139313941395139613971398139914001401140214031404140514061407140814091410141114121413141414151416141714181419142014211422142314241425142614271428142914301431143214331434143514361437143814391440144114421443144414451446144714481449145014511452145314541455145614571458145914601461146214631464146514661467146814691470147114721473147414751476147714781479148014811482148314841485148614871488148914901491149214931494149514961497149814991500150115021503150415051506150715081509151015111512151315141515151615171518151915201521152215231524152515261527152815291530153115321533153415351536153715381539154015411542154315441545154615471548154915501551155215531554155515561557155815591560156115621563156415651566156715681569157015711572157315741575157615771578157915801581158215831584158515861587158815891590159115921593159415951596159715981599160016011602160316041605160616071608160916101611161216131614161516161617161816191620162116221623162416251626162716281629163016311632163316341635163616371638163916401641164216431644164516461647164816491650165116521653165416551656165716581659166016611662166316641665166616671668166916701671167216731674167516761677167816791680168116821683168416851686168716881689169016911692169316941695169616971698169917001701170217031704170517061707170817091710171117121713171417151716171717181719172017211722172317241725172617271728172917301731173217331734173517361737173817391740174117421743174417451746174717481749175017511752175317541755175617571758175917601761176217631764176517661767176817691770177117721773177417751776177717781779178017811782178317841785178617871788178917901791179217931794179517961797179817991800180118021803180418051806180718081809181018111812181318141815181618171818181918201821182218231824182518261827182818291830183118321833183418351836183718381839184018411842184318441845184618471848184918501851185218531854185518561857185818591860186118621863186418651866186718681869187018711872187318741875187618771878187918801881188218831884188518861887188818891890189118921893189418951896189718981899190019011902190319041905190619071908190919101911191219131914191519161917191819191920192119221923192419251926192719281929193019311932193319341935193619371938193919401941194219431944194519461947194819491950195119521953195419551956195719581959196019611962196319641965196619671968196919701971197219731974197519761977197819791980198119821983198419851986198719881989199019911992199319941995199619971998199920002001200220032004200520062007200820092010201120122013201420152016201720182019202020212022202320242025202620272028202920302031203220332034203520362037203820392040204120422043204420452046204720482049205020512052205320542055205620572058205920602061206220632064206520662067206820692070207120722073207420752076207720782079208020812082208320842085208620872088208920902091209220932094209520962097209820992100210121022103210421052106210721082109211021112112211321142115211621172118211921202121212221232124212521262127212821292130213121322133213421352136213721382139214021412142214321442145214621472148214921502151215221532154215521562157215821592160216121622163216421652166216721682169217021712172217321742175217621772178217921802181218221832184218521862187218821892190219121922193219421952196219721982199220022012202220322042205220622072208220922102211221222132214221522162217221822192220222122222223222422252226222722282229223022312232223322342235223622372238223922402241224222432244224522462247224822492250225122522253225422552256225722582259226022612262226322642265226622672268226922702271227222732274227522762277227822792280228122822283228422852286228722882289229022912292229322942295229622972298229923002301230223032304230523062307230823092310231123122313231423152316231723182319232023212322232323242325232623272328232923302331233223332334233523362337233823392340234123422343234423452346234723482349235023512352235323542355235623572358235923602361236223632364236523662367236823692370237123722373237423752376237723782379238023812382238323842385238623872388238923902391239223932394239523962397239823992400240124022403240424052406240724082409241024112412241324142415241624172418241924202421242224232424242524262427242824292430243124322433243424352436243724382439244024412442244324442445244624472448244924502451245224532454245524562457245824592460246124622463246424652466246724682469247024712472247324742475247624772478247924802481248224832484248524862487248824892490249124922493249424952496249724982499250025012502250325042505250625072508250925102511251225132514251525162517251825192520252125222523252425252526252725282529253025312532253325342535253625372538253925402541254225432544254525462547254825492550255125522553255425552556255725582559256025612562256325642565256625672568256925702571257225732574257525762577257825792580258125822583258425852586258725882589259025912592259325942595259625972598259926002601260226032604260526062607260826092610261126122613261426152616261726182619262026212622262326242625262626272628262926302631263226332634263526362637263826392640264126422643264426452646264726482649265026512652265326542655265626572658265926602661266226632664266526662667266826692670267126722673267426752676267726782679268026812682268326842685268626872688268926902691269226932694269526962697269826992700270127022703270427052706270727082709271027112712271327142715271627172718271927202721272227232724272527262727272827292730273127322733273427352736273727382739274027412742274327442745274627472748274927502751275227532754275527562757275827592760276127622763276427652766276727682769277027712772277327742775277627772778277927802781278227832784278527862787278827892790279127922793279427952796279727982799280028012802280328042805280628072808280928102811281228132814281528162817281828192820282128222823282428252826282728282829283028312832283328342835283628372838283928402841284228432844284528462847284828492850285128522853285428552856285728582859286028612862286328642865286628672868286928702871287228732874287528762877287828792880288128822883288428852886288728882889289028912892289328942895289628972898289929002901290229032904290529062907290829092910291129122913291429152916291729182919292029212922292329242925292629272928292929302931293229332934293529362937293829392940294129422943294429452946294729482949295029512952295329542955295629572958295929602961296229632964296529662967296829692970297129722973297429752976297729782979298029812982298329842985298629872988298929902991299229932994299529962997299829993000300130023003300430053006300730083009301030113012301330143015301630173018301930203021302230233024 |
- """Tests for the assistant service (Phase 2) using synthetic event streams."""
- import itertools
- import json
- import re
- import threading
- import time
- from typing import Any
- from stt_daemon import events
- from stt_daemon.assistant.inference import InferenceJob, InferenceQueue
- from stt_daemon.assistant.service import EXECUTE_BUSY, AssistantService
- from stt_daemon.assistant.triage import TriageAnalyzer
- from stt_daemon.assistant.triage_dump import TriageDumper
- from stt_daemon.config import Config
- _sequence = itertools.count(1)
- # A real analyzer (pure, stdlib-only helpers) backing the fake's retention
- # guard so guard behaviour is exercised end to end.
- _real_analyzer = TriageAnalyzer(Config().triage)
- class Clock:
- def __init__(self, start=1000.0):
- self.t = float(start)
- def __call__(self):
- return self.t
- def advance(self, dt):
- self.t += float(dt)
- class FakeSubscriber:
- def events(self):
- return iter(())
- def close(self):
- pass
- def _service():
- cfg = Config()
- clock = Clock()
- emitted: list[dict] = []
- def emit(type_, **fields):
- emitted.append({"type": type_, **fields})
- service = AssistantService(cfg, FakeSubscriber(), emit=emit, time_fn=clock)
- return service, emitted, clock
- def _ev(type_, clock, **fields):
- event = {"v": 1, "type": type_, "seq": next(_sequence), "ts": clock()}
- event.update(fields)
- return event
- def _transcript(clock, text, ts=None, session_dir=None):
- event = {
- "v": 1,
- "type": events.TRANSCRIPT,
- "seq": next(_sequence),
- "ts": clock() if ts is None else ts,
- "text": text,
- }
- if session_dir is not None:
- event["session_dir"] = session_dir
- return event
- def test_ready_requires_matching_segment_done():
- service, _, clock = _service()
- service.handle_event(_ev(events.SPEECH_START, clock))
- assert service.ready() is False
- service.handle_event(_ev(events.SPEECH_STOP, clock, seg_id=1))
- assert service.ready() is False # awaiting segment 1
- service.handle_event(_ev(events.SEGMENT_DONE, clock, seg_id=1, emitted=True))
- assert service.ready() is True
- def test_stale_segment_done_does_not_satisfy_later_turn():
- service, _, clock = _service()
- service.handle_event(_ev(events.SPEECH_STOP, clock, seg_id=1))
- service.handle_event(_ev(events.SPEECH_START, clock))
- service.handle_event(_ev(events.SPEECH_STOP, clock, seg_id=2))
- service.handle_event(_ev(events.SEGMENT_DONE, clock, seg_id=1, emitted=True))
- assert service.ready() is False # still awaiting segment 2
- service.handle_event(_ev(events.SEGMENT_DONE, clock, seg_id=2, emitted=True))
- assert service.ready() is True
- def test_gated_segment_done_clears_readiness():
- service, _, clock = _service()
- service.handle_event(_ev(events.SPEECH_STOP, clock, seg_id=3))
- service.handle_event(_ev(events.SEGMENT_DONE, clock, seg_id=3, emitted=False))
- assert service.ready() is True
- def test_speech_stop_without_seg_id_clears_readiness():
- """A discarded turn closes with speech_stop but no seg_id; readiness must recover."""
- service, _, clock = _service()
- service.handle_event(_ev(events.SPEECH_START, clock))
- assert service.ready() is False
- service.handle_event(_ev(events.SPEECH_STOP, clock)) # discarded: no seg_id
- assert service.speech_open is False
- assert service.awaited_seg_id is None
- assert service.ready() is True
- def test_status_resets_stale_speech_state_on_reconnect():
- service, _, clock = _service()
- service.handle_event(_ev(events.SPEECH_START, clock))
- assert service.speech_open is True
- service.handle_event(_ev(events.STATUS, clock, capture="x", segments_done=0))
- assert service.speech_open is False
- assert service.awaited_seg_id is None
- assert service.ready() is True
- def test_command_buffer_uses_arm_timestamp():
- service, _, clock = _service()
- clock.advance(10)
- assert service.arm() is True
- arm_ts = service.arm_ts
- assert arm_ts is not None
- # Replayed transcript from before arming is ignored.
- service.handle_event(_transcript(clock, "old", ts=arm_ts - 5))
- assert service.command_text == ""
- service.handle_event(_transcript(clock, "what time is it"))
- assert service.command_text == "what time is it"
- def test_mutual_exclusion_between_command_and_chat():
- service, _, _ = _service()
- assert service.toggle_chat() is True
- assert service.arm() is False # cannot arm in chat
- assert service.toggle_chat() is True # back to idle
- assert service.arm() is True
- assert service.toggle_chat() is False # cannot chat while armed
- def test_arm_timeout_disarms_and_emits_error():
- service, emitted, clock = _service()
- service.arm()
- clock.advance(service.cfg.assistant.command_arm_timeout_s + 0.1)
- service.tick()
- assert service.modes.mode.value == "idle"
- assert service.command_text == ""
- assert any(e["type"] == "error" and e["code"] == "arm_timeout" for e in emitted)
- def test_long_speech_does_not_disarm():
- service, emitted, clock = _service()
- service.arm()
- service.handle_event(_ev(events.SPEECH_START, clock))
- clock.advance(service.cfg.assistant.command_arm_timeout_s + 30.0)
- service.tick()
- assert service.modes.mode.value == "command_armed"
- assert not any(e["type"] == "error" for e in emitted)
- def test_captured_command_survives_arm_timeout():
- service, emitted, clock = _service()
- service.arm()
- service.handle_event(_transcript(clock, "what time is it"))
- service.handle_event(_ev(events.SPEECH_STOP, clock, seg_id=1))
- service.handle_event(_ev(events.SEGMENT_DONE, clock, seg_id=1, emitted=True))
- clock.advance(service.cfg.assistant.command_arm_timeout_s + 30.0)
- service.tick()
- assert service.modes.mode.value == "command_armed"
- assert service.command_text == "what time is it"
- assert not any(e["type"] == "error" for e in emitted)
- def test_stt_stall_cancels_armed_command():
- service, emitted, clock = _service()
- service.handle_event(_ev(events.HEARTBEAT, clock, worker_stall_s=0.0))
- service.arm()
- clock.advance(service.cfg.assistant.stall_timeout_ms / 1000.0 + 0.5)
- service.tick()
- assert service.modes.mode.value == "idle"
- assert any(e["type"] == "error" and e["code"] == "stt_stall" for e in emitted)
- def test_worker_stall_marks_stt_degraded():
- service, _, clock = _service()
- long_stall = service.cfg.assistant.worker_stall_ms / 1000.0 + 1.0
- service.handle_event(_ev(events.HEARTBEAT, clock, worker_stall_s=long_stall))
- assert service.stt_ok() is False
- assert service.ready() is False
- def test_chat_idle_timeout_exits_chat():
- service, _, clock = _service()
- assert service.toggle_chat() is True
- clock.advance(service.cfg.assistant.chat_idle_timeout_s + 0.1)
- service.tick()
- assert service.modes.mode.value == "idle"
- def test_chat_exit_phrase_exits_chat():
- service, _, clock = _service()
- assert service.toggle_chat() is True
- service.set_chat_capture(True)
- service.handle_event(_transcript(clock, "That's all."))
- assert service.modes.mode.value == "idle"
- def test_exit_phrase_preserves_chat_history():
- service, _, clock = _service()
- service.toggle_chat()
- service.set_chat_capture(True)
- service.handle_event(_transcript(clock, "hello"))
- service.handle_event(_transcript(clock, "That's all."))
- assert service.modes.mode.value == "idle"
- assert service.chat_history == ["Unknown: hello", "Unknown: That's all."]
- def test_viewer_detached_exits_chat_and_keeps_history():
- service, _, clock = _service()
- assert service.toggle_chat() is True
- service.set_chat_capture(True)
- service.handle_event(_transcript(clock, "hello"))
- assert service.viewer_detached() is True
- assert service.modes.mode.value == "idle"
- assert service.chat_history == ["Unknown: hello"]
- def test_viewer_detached_is_noop_outside_chat():
- service, _, _ = _service()
- assert service.viewer_detached() is False
- assert service.modes.mode.value == "idle"
- def test_exit_chat_preserves_history_and_does_not_reset():
- cfg = Config()
- resets: list[int] = []
- service = AssistantService(
- cfg, FakeSubscriber(), time_fn=Clock(), chat_reset=lambda: resets.append(1)
- )
- service.toggle_chat()
- service.set_chat_capture(True)
- service.handle_event(_transcript(Clock(), "hello"))
- service.viewer_detached()
- service.toggle_chat()
- assert resets == []
- assert service.chat_history == ["Unknown: hello"]
- def test_chat_accumulates_turns():
- service, _, clock = _service()
- service.toggle_chat()
- service.set_chat_capture(True)
- for text in ("hello there", "how are you"):
- service.handle_event(_transcript(clock, text))
- assert service.chat_history == ["Unknown: hello there", "Unknown: how are you"]
- def test_chat_capture_off_skips_spoken_transcripts_and_exit_phrase():
- service, _, clock = _service()
- service.toggle_chat()
- assert service.set_chat_capture(False) is True
- service.handle_event(_transcript(clock, "hello"))
- service.handle_event(_transcript(clock, "That's all."))
- assert service.chat_history == []
- assert service._pending_chat == []
- assert service.modes.mode.value == "chat"
- def test_chat_capture_off_still_allows_typed_turns_and_triage():
- service, _, clock = _service()
- service.toggle_chat()
- service.set_chat_capture(False)
- service.handle_event(_transcript(clock, "spoken"))
- assert service.submit_chat_text("typed") is True
- assert service.chat_history == ["typed"]
- assert service.triage_history == ["Unknown: spoken"]
- def test_set_chat_capture_emits_once_and_reports_status():
- service, emitted, _ = _service()
- assert service.status()["chat_capture"] is False
- assert service.set_chat_capture(True) is True
- assert [e for e in emitted if e["type"] == "chat_capture"] == [
- {"type": "chat_capture", "on": True}
- ]
- assert service.status()["chat_capture"] is True
- emitted.clear()
- service.set_chat_capture(True)
- assert emitted == []
- def test_triage_chat_off_ignores_chat_turns():
- service, _, _, _, lane = _triage_service()
- service._run_chat("typed")
- assert lane.submits == []
- assert service.triage_history == []
- def test_triage_chat_sends_reply_only_when_capture_on():
- service, _, _, _, lane = _triage_service()
- service.toggle_chat()
- service.set_chat_capture(True)
- service.set_triage_chat(True)
- service._run_chat("spoken, already in triage")
- assert service.triage_history == ["Assistant: ok"]
- assert lane.submits[0][0] == "- Assistant: ok"
- def test_triage_chat_sends_user_and_reply_when_capture_off():
- service, _, _, _, lane = _triage_service()
- service.toggle_chat()
- service.set_chat_capture(False)
- service.set_triage_chat(True)
- service._run_chat("typed")
- assert service.triage_history == ["You: typed", "Assistant: ok"]
- assert lane.submits[0][0] == "- You: typed\n- Assistant: ok"
- def test_set_triage_chat_emits_once_and_reports_status():
- service, emitted, _, _, _ = _triage_service()
- assert service.status()["triage_chat"] is False
- assert service.set_triage_chat(True) is True
- assert [e for e in emitted if e["type"] == "triage_chat"] == [
- {"type": "triage_chat", "on": True}
- ]
- assert service.status()["triage_chat"] is True
- emitted.clear()
- service.set_triage_chat(True)
- assert emitted == []
- def test_submit_chat_text_requires_chat_and_dispatches_immediately():
- cfg = Config()
- cfg.assistant.turn_gap_s = 999.0
- replies: list[str] = []
- emitted: list[dict] = []
- def emit(type_, **fields):
- emitted.append({"type": type_, **fields})
- service = AssistantService(
- cfg,
- FakeSubscriber(),
- emit=emit,
- chat_fn=lambda text: replies.append(text) or "ok",
- time_fn=Clock(),
- )
- assert service.submit_chat_text("hi") is False
- assert service.submit_chat_text(" ") is False
- service.toggle_chat()
- service.start()
- try:
- assert service.submit_chat_text("hi") is True
- deadline = time.time() + 2.0
- while time.time() < deadline and not replies:
- time.sleep(0.01)
- finally:
- service.stop()
- assert replies == ["hi"]
- assert service.chat_history == ["hi"]
- assert service._pending_chat == []
- assert any(
- e["type"] == "chat_message" and e.get("role") == "user" and e.get("text") == "hi"
- for e in emitted
- )
- def test_execute_clears_command_buffer_immediately():
- service, emitted, clock = _service()
- service.arm()
- service.handle_event(_transcript(clock, "do it"))
- service.handle_event(_ev(events.SPEECH_STOP, clock, seg_id=1))
- service.handle_event(_ev(events.SEGMENT_DONE, clock, seg_id=1, emitted=True))
- assert service.execute() == "do it"
- assert service.modes.mode.value == "executing"
- assert service.command_text == ""
- assert service.command_edited is False
- assert service.arm_ts is None
- assert any(e["type"] == "command_text" and e["text"] == "" for e in emitted)
- def test_execute_requires_readiness():
- service, _, clock = _service()
- service.arm()
- service.handle_event(_transcript(clock, "do it"))
- service.handle_event(_ev(events.SPEECH_START, clock))
- assert service.execute() is None # speech still open
- assert service.modes.mode.value == "command_armed"
- service.handle_event(_ev(events.SPEECH_STOP, clock, seg_id=1))
- assert service.execute() is None # awaiting segment 1
- service.handle_event(_ev(events.SEGMENT_DONE, clock, seg_id=1, emitted=True))
- assert service.execute() == "do it"
- assert service.modes.mode.value == "executing"
- assert service.finish() is True
- assert service.modes.mode.value == "idle"
- def test_execute_reports_busy_when_queue_rejects():
- service, emitted, clock = _service()
- # A zero-capacity lane rejects the priority command job on submit.
- service._inference = InferenceQueue(size=0)
- service.executor = object()
- service.arm()
- service.handle_event(_transcript(clock, "do it"))
- service.handle_event(_ev(events.SPEECH_STOP, clock, seg_id=1))
- service.handle_event(_ev(events.SEGMENT_DONE, clock, seg_id=1, emitted=True))
- assert service.execute() is EXECUTE_BUSY
- assert service.modes.mode.value == "idle"
- assert not any(e.get("code") == "busy" for e in emitted)
- def test_turn_ended_requires_quiet_gap():
- service, _, clock = _service()
- service.handle_event(_ev(events.SPEECH_STOP, clock, seg_id=1))
- service.handle_event(_ev(events.SEGMENT_DONE, clock, seg_id=1, emitted=True))
- assert service.ready() is True
- assert service.turn_ended() is False
- clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
- assert service.turn_ended() is True
- def test_emits_mode_and_command_text():
- service, emitted, clock = _service()
- service.arm()
- assert {"type": "mode", "mode": "command_armed"} in emitted
- service.handle_event(_transcript(clock, "hi"))
- assert any(e["type"] == "command_text" and e["text"] == "hi" for e in emitted)
- def test_cancel_clears_command_buffer():
- service, _, clock = _service()
- service.arm()
- service.handle_event(_transcript(clock, "hi"))
- assert service.cancel() is True
- assert service.modes.mode.value == "idle"
- assert service.command_text == ""
- assert service.arm_ts is None
- def test_pending_chat_is_not_lost_across_threads():
- """Transcripts appended on the reader thread while the ticker dispatches
- must all reach the model: the join-and-clear in _dispatch_chat is atomic,
- and the user bubble is emitted by the worker in _run_chat."""
- cfg = Config()
- cfg.assistant.turn_gap_s = 0.01
- dispatched: list[str] = []
- lock = threading.Lock()
- def emit(type_, **fields):
- if type_ == "chat_message" and fields.get("role") == "user":
- with lock:
- dispatched.append(fields["text"])
- service = AssistantService(cfg, FakeSubscriber(), emit=emit, chat_fn=lambda text: "ok")
- service.toggle_chat()
- service.set_chat_capture(True)
- service.start()
- try:
- total = 200
- producer = threading.Thread(
- target=lambda: [
- service.handle_event(
- {
- "v": 1,
- "type": events.TRANSCRIPT,
- "seq": i,
- "ts": time.time(),
- "text": f"w{i}",
- }
- )
- for i in range(total)
- ],
- daemon=True,
- )
- producer.start()
- deadline = time.time() + 10.0
- while time.time() < deadline:
- service.tick()
- with lock:
- words = sum(len(text.split()) for text in dispatched)
- done = words == 2 * total
- if not producer.is_alive() and done:
- break
- time.sleep(0.002)
- producer.join(timeout=5)
- with lock:
- words = sum(len(text.split()) for text in dispatched)
- assert words == 2 * total
- finally:
- service.stop()
- def _full_queue_service():
- service, emitted, clock = _service()
- service.toggle_chat()
- service._inference = InferenceQueue(size=1)
- service._inference.submit(
- InferenceJob(name="blocker", run=lambda: None, evictable=False)
- )
- return service, emitted, clock
- def test_chat_refusal_rebuffers_and_emits_queue_full_once():
- """A refused chat submit re-buffers under lock and emits queue_full on flip."""
- service, emitted, _ = _full_queue_service()
- service._pending_chat = ["hello world"]
- service._dispatch_chat()
- assert service._pending_chat == ["hello world"]
- assert service._chat_queue_full is True
- errors = [e for e in emitted if e["type"] == "error" and e.get("code") == "queue_full"]
- assert len(errors) == 1
- assert [e for e in emitted if e["type"] == "chat_message"] == []
- service._dispatch_chat()
- assert service._pending_chat == ["hello world"]
- errors = [e for e in emitted if e["type"] == "error" and e.get("code") == "queue_full"]
- assert len(errors) == 1
- def test_chat_dispatch_success_clears_latch_without_user_bubble():
- """Success clears the latch; the user bubble comes from _run_chat, not dispatch."""
- service, emitted, _ = _full_queue_service()
- service._pending_chat = ["hello world"]
- service._chat_queue_full = True
- service._inference.drop(lambda j: True)
- service._dispatch_chat()
- assert service._pending_chat == []
- assert service._chat_queue_full is False
- assert [e for e in emitted if e["type"] == "chat_message"] == []
- def test_run_chat_emits_user_first_then_reply():
- service, emitted, _ = _service()
- service.chat_fn = lambda text: "reply!"
- service._run_chat("hello")
- assert emitted == [
- {"type": "chat_message", "role": "user", "text": "hello"},
- {"type": "chat_message", "role": "assistant", "text": "reply!"},
- ]
- def test_chat_notify_emits_compaction_note():
- service, emitted, _ = _service()
- service.chat_notify("compacted", turns=4)
- assert {
- "type": "chat_message",
- "role": "note",
- "text": "Compacted 4 earlier turns into a summary.",
- } in emitted
- def test_chat_notify_emits_truncated_error():
- service, emitted, _ = _service()
- service.chat_notify("truncated", message="cut off")
- assert {"type": "error", "code": "truncated", "message": "cut off"} in emitted
- def test_clear_empties_chat_history():
- service, emitted, clock = _service()
- service.toggle_chat()
- service.set_chat_capture(True)
- for text in ("hello", "how are you"):
- service.handle_event(_transcript(clock, text))
- assert service.chat_history == ["Unknown: hello", "Unknown: how are you"]
- assert len(service._pending_chat) == 2
- assert service.clear() is True
- assert service.chat_history == []
- assert service._pending_chat == []
- assert {"type": "cleared"} in emitted
- def test_clear_invokes_chat_reset():
- cfg = Config()
- resets: list[int] = []
- service = AssistantService(
- cfg, FakeSubscriber(), time_fn=Clock(), chat_reset=lambda: resets.append(1)
- )
- service.toggle_chat()
- service.clear()
- assert resets == [1]
- def test_clear_does_not_change_mode():
- service, _, clock = _service()
- service.toggle_chat()
- assert service.modes.mode.value == "chat"
- service.clear()
- assert service.modes.mode.value == "chat"
- def test_clear_always_returns_true():
- service, _, _ = _service()
- assert service.clear() is True
- service.toggle_chat()
- service.handle_event(_ev(events.TRANSCRIPT, Clock(), text="test"))
- assert service.clear() is True
- def test_heartbeat_emits_inference_depth_and_in_flight():
- """Calling tick() emits heartbeat with inference_depth (int) and inference_in_flight (bool)."""
- service, emitted, clock = _service()
- service.tick()
- heartbeats = [e for e in emitted if e["type"] == "heartbeat"]
- assert len(heartbeats) == 1
- heartbeat = heartbeats[0]
- assert "inference_depth" in heartbeat
- assert isinstance(heartbeat["inference_depth"], int)
- assert "inference_in_flight" in heartbeat
- assert isinstance(heartbeat["inference_in_flight"], bool)
- def test_status_contains_inference_depth_and_in_flight():
- """status() snapshot contains inference_depth (int) and inference_in_flight (bool)."""
- service, _, _ = _service()
- status = service.status()
- assert "inference_depth" in status
- assert isinstance(status["inference_depth"], int)
- assert "inference_in_flight" in status
- assert isinstance(status["inference_in_flight"], bool)
- _AUTO = object()
- class FakeTriage:
- def __init__(
- self,
- questions=_AUTO,
- state_pair=("ok", ""),
- escalate=False,
- parsed=_AUTO,
- normalized=_AUTO,
- gate=True,
- ):
- if questions is _AUTO:
- questions = {"urgency": {"type": "noul", "instructions": "how urgent"}}
- self._questions = questions
- self._state_pair = state_pair
- self._escalate = escalate
- self._parsed = parsed
- self._normalized = normalized
- self._gate = gate
- self.build_state_calls: list[tuple] = []
- self.normalize_calls: list = []
- self.prompt_calls: list[tuple] = []
- self.gate_calls: list = []
- @property
- def questions(self):
- return self._questions
- def state(self):
- return self._state_pair
- def build_state(self, window):
- self.build_state_calls.append(tuple(window))
- return "\n".join("- " + str(item) for item in (window or []))
- def normalize(self, payload):
- self.normalize_calls.append(payload)
- if self._normalized is not _AUTO:
- return self._normalized
- if not isinstance(payload, dict):
- return {}
- signals = {"order": [], "items": {}, "escalated": False, "input_tokens": 0}
- signals.update(payload)
- if self._escalate:
- signals["escalated"] = True
- return signals
- def build_brief_prompt(self, deltas, signals):
- self.prompt_calls.append(
- (tuple(deltas), dict(signals) if isinstance(signals, dict) else signals)
- )
- return "BRIEF-PROMPT"
- def build_ledger_prompt(self, narrative, ledger, deltas, signals):
- self.prompt_calls.append(
- (tuple(deltas), dict(signals) if isinstance(signals, dict) else signals)
- )
- ledger_text = "\n".join("- " + f for f in ledger) or "(none yet)"
- body = "\n".join("- " + d for d in deltas)
- return (
- f"CURRENT LEDGER:\n{ledger_text}\n\n"
- f"CURRENT BRIEF:\n{narrative or '(none yet)'}\n\n"
- f"NEW UTTERANCES:\n{body}"
- )
- def parse_ledger_reply(self, text, truncated=False):
- return _real_analyzer.parse_ledger_reply(text, truncated=truncated)
- def is_regression(self, prior_brief, new_brief):
- return _real_analyzer.is_regression(prior_brief, new_brief)
- def should_escalate(self, signals):
- return _real_analyzer.should_escalate(signals)
- def parse_facts(self, block):
- return _real_analyzer.parse_facts(block)
- def parse_brief(self, text):
- if self._parsed is _AUTO:
- return text if text else None
- return self._parsed
- def should_update_brief(self, signals, prior=None):
- self.gate_calls.append(signals)
- if self._gate is _AUTO:
- return _real_analyzer.should_update_brief(signals, prior)
- return self._gate
- class FakeBriefFile:
- """Recording stand-in for BriefFile (write/clear/set_directory never raise)."""
- def __init__(self):
- self.writes: list[str] = []
- self.clears = 0
- self.directories: list[str] = []
- def set_directory(self, directory):
- self.directories.append(directory)
- def write(self, text):
- self.writes.append(text)
- def clear(self):
- self.clears += 1
- class FakeLane:
- def __init__(self, ready=True):
- self._ready = ready
- self.submits: list[tuple] = []
- self.drops = 0
- self.predict_gate = threading.Event()
- def ready(self):
- return self._ready
- def state(self):
- return ("ok", "") if self._ready else ("loading", "")
- def submit(self, state, questions, lang, generation):
- self.submits.append((state, questions, lang, generation))
- return True
- def drop_pending(self):
- self.drops += 1
- class FakeDebugSink:
- def __init__(self):
- self.events: list[tuple] = []
- def emit(self, type_, **fields):
- self.events.append((type_, fields))
- def _ok_reply(text):
- return "ok"
- def _brief_reply(narrative="", facts=None):
- """Build a ledger-format reply the analyzer's parser can consume."""
- body = "\n".join("- " + fact for fact in (facts or [])) or "none"
- return f"NEW FACTS:\n{body}\n\nBRIEF:\n{narrative}"
- def _triage_service(
- triage=None,
- lane=None,
- brief_fn=None,
- chat_fn: Any = _AUTO,
- brief_file=None,
- brief_reset=None,
- chat_reset=None,
- debug_sink=None,
- brief_finish: Any = "stop",
- ):
- cfg = Config()
- cfg.assistant.turn_gap_s = 0.5
- clock = Clock()
- emitted: list[dict] = []
- def emit(type_, **fields):
- emitted.append({"type": type_, **fields})
- if triage is None:
- triage = FakeTriage()
- if lane is None:
- lane = FakeLane()
- if chat_fn is _AUTO:
- chat_fn = _ok_reply
- factory = (lambda: debug_sink) if debug_sink is not None else None
- service = AssistantService(
- cfg,
- FakeSubscriber(),
- emit=emit,
- time_fn=clock,
- triage=triage,
- laya_lane=lane,
- brief_fn=_wrap_brief_fn(brief_fn, brief_finish),
- brief_reset=brief_reset,
- brief_file=brief_file,
- chat_fn=chat_fn,
- chat_reset=chat_reset,
- debug_sink_factory=factory,
- )
- return service, emitted, clock, triage, lane
- def _wrap_brief_fn(brief_fn, finish_reason="stop"):
- """Adapt a simple `prompt -> text` stub to the engine's call signature.
- A plain string return is treated as the volatile narrative half of a
- ledger reply, so existing stubs keep reading naturally. ``finish_reason``
- may be a callable taking the reply so a test can mark one reply truncated.
- """
- if brief_fn is None:
- return None
- def wrapped(prompt, on_io=None, finalize=None):
- kwargs = {}
- if on_io is not None:
- kwargs["on_io"] = on_io
- try:
- result = brief_fn(prompt, **kwargs)
- except TypeError:
- result = brief_fn(prompt)
- if finalize is not None:
- reason = finish_reason(result) if callable(finish_reason) else finish_reason
- result = finalize(result, reason)
- is_ledger = "BRIEF:" in result or "NEW FACTS:" in result
- if isinstance(result, str) and result and not is_ledger:
- result = _brief_reply(narrative=result)
- return result
- return wrapped
- def _triage_events(emitted):
- return [e for e in emitted if e["type"] == "triage"]
- def _escalated_payload():
- return {"order": [], "items": {}, "escalated": True, "input_tokens": 3}
- def test_triage_status_disabled_when_no_analyzer():
- service, _, _ = _service()
- status = service.status()
- assert status["triage_state"] == "disabled"
- assert status["triage_reason"] == ""
- assert status["triage"] is None
- def test_triage_status_reflects_analyzer():
- service, _, _, _, _ = _triage_service(
- triage=FakeTriage(state_pair=("loading", "warming up"))
- )
- status = service.status()
- assert status["triage_state"] == "loading"
- assert status["triage_reason"] == "warming up"
- assert status["triage"] is None
- def test_status_contains_questions_from_analyzer():
- questions = {
- "urgency": {"type": "noul", "instructions": "how urgent"},
- "sentiment": {"type": "score", "instructions": "tone", "criteria": ["low", "high"]},
- }
- service, _, _, triage, _ = _triage_service(triage=FakeTriage(questions=questions))
- status = service.status()
- assert status["questions"] == questions
- assert status["questions"] is triage.questions
- def test_status_questions_none_without_analyzer():
- service, _, _ = _service()
- assert service.status()["questions"] is None
- def test_status_event_carries_questions():
- service, emitted, _, triage, _ = _triage_service()
- service.tick()
- statuses = [e for e in emitted if e["type"] == "status"]
- assert len(statuses) == 1
- assert statuses[0]["questions"] is triage.questions
- def test_triage_captures_transcript_lang():
- service, _, clock, _, _ = _triage_service()
- assert service._last_transcript_lang is None
- event = _transcript(clock, "hola")
- event["lang"] = "es"
- service.handle_event(event)
- assert service._last_transcript_lang == "es"
- service.handle_event(_transcript(clock, "hello"))
- assert service._last_transcript_lang is None
- def test_maybe_triage_passes_lang_to_lane():
- service, _, clock, _, lane = _triage_service()
- event = _transcript(clock, "hola")
- event["lang"] = "es"
- service.handle_event(event)
- clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
- service.tick()
- assert len(lane.submits) == 1
- _, _, lang, _ = lane.submits[0]
- assert lang == "es"
- def test_maybe_triage_runs_in_idle_mode():
- service, _, clock, triage, lane = _triage_service()
- service.handle_event(_transcript(clock, "hello"))
- clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
- service.tick()
- assert len(lane.submits) == 1
- state, questions, lang, gen = lane.submits[0]
- assert state == "- Unknown: hello"
- assert questions is triage.questions
- assert lang is None
- assert gen == 0
- assert triage.build_state_calls == [("Unknown: hello",)]
- assert service.triage_history == ["Unknown: hello"]
- def test_maybe_triage_uses_transcript_buffer_not_chat_history():
- service, _, clock, triage, lane = _triage_service(chat_fn=None)
- service.chat_history = ["stale chat only"]
- clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
- service.tick()
- assert lane.submits == []
- assert triage.build_state_calls == []
- service.handle_event(_transcript(clock, "hello"))
- clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
- service.tick()
- assert len(lane.submits) == 1
- assert triage.build_state_calls == [("Unknown: hello",)]
- def test_maybe_triage_requires_settled_turn():
- service, _, clock, _, lane = _triage_service()
- service.handle_event(_transcript(clock, "hello"))
- service.tick()
- assert lane.submits == []
- def test_maybe_triage_periodic_fires_before_turn_settles():
- service, _, clock, _, lane = _triage_service()
- service.cfg.triage.periodic_s = 0.2
- service.handle_event(_transcript(clock, "hello"))
- assert service.turn_ended() is False
- clock.advance(0.25) # due (0.2) yet still quieter than turn_gap_s (0.5)
- service.tick()
- assert service.turn_ended() is False
- assert len(lane.submits) == 1
- assert lane.submits[0][0] == "- Unknown: hello"
- def test_maybe_triage_periodic_disabled_ignores_accumulating_speech():
- service, _, clock, _, lane = _triage_service()
- service.cfg.triage.periodic_s = 0.0
- service.handle_event(_transcript(clock, "hello"))
- clock.advance(0.25)
- service.tick()
- assert service.turn_ended() is False
- assert lane.submits == []
- def test_maybe_triage_periodic_rearms_after_submit():
- service, _, clock, _, lane = _triage_service()
- service.cfg.triage.periodic_s = 0.2
- service.handle_event(_transcript(clock, "first"))
- clock.advance(0.25)
- service.tick()
- assert len(lane.submits) == 1
- service.tick()
- service.tick()
- assert len(lane.submits) == 1 # identical window, no new speech
- service.handle_event(_transcript(clock, "second"))
- clock.advance(0.25)
- service.tick()
- assert len(lane.submits) == 2
- assert lane.submits[1][0] == "- Unknown: first\n- Unknown: second"
- def test_triage_debug_emits_submit_and_result():
- sink = FakeDebugSink()
- service, _, clock, _, lane = _triage_service(debug_sink=sink)
- service.handle_event(_transcript(clock, "hello"))
- clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
- service.tick()
- submits = [event for event in sink.events if event[0] == "triage-submit"]
- assert submits == [
- ("triage-submit", {"trigger": "settled", "window": 1, "generation": 0})
- ]
- _, _, _, gen = lane.submits[0]
- service._on_triage_result(gen, _escalated_payload())
- results = [event for event in sink.events if event[0] == "triage-result"]
- assert len(results) == 1
- assert results[0][1]["escalated"] is True
- assert results[0][1]["generation"] == 0
- def test_triage_debug_marks_periodic_trigger():
- sink = FakeDebugSink()
- service, _, clock, _, lane = _triage_service(debug_sink=sink)
- service.cfg.triage.periodic_s = 0.2
- service.handle_event(_transcript(clock, "hello"))
- clock.advance(0.25)
- service.tick()
- submits = [event for event in sink.events if event[0] == "triage-submit"]
- assert submits[0][1]["trigger"] == "periodic"
- def test_triage_debug_emits_brief_dispatch():
- sink = FakeDebugSink()
- service, _, clock, _, lane = _triage_service(
- brief_fn=lambda prompt: "RAW", debug_sink=sink
- )
- service.handle_event(_transcript(clock, "hello"))
- clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
- service.tick()
- _, _, _, gen = lane.submits[0]
- service._on_triage_result(gen, _escalated_payload())
- brief = [event for event in sink.events if event[0] == "triage-brief"]
- assert brief == [("triage-brief", {"action": "dispatch", "generation": 0})]
- def test_triage_debug_emits_brief_gate_skip():
- sink = FakeDebugSink()
- service, _, clock, _, lane = _triage_service(
- triage=FakeTriage(gate=False), brief_fn=lambda prompt: "RAW", debug_sink=sink
- )
- service.handle_event(_transcript(clock, "hello"))
- clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
- service.tick()
- _, _, _, gen = lane.submits[0]
- service._on_triage_result(gen, _escalated_payload())
- brief = [event for event in sink.events if event[0] == "triage-brief"]
- assert brief == [
- ("triage-brief", {"action": "skip", "reason": "gate", "generation": 0})
- ]
- def test_maybe_triage_skips_unready_lane():
- service, _, clock, _, lane = _triage_service(lane=FakeLane(ready=False))
- service.handle_event(_transcript(clock, "hello"))
- clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
- service.tick()
- assert lane.submits == []
- def test_maybe_triage_skips_without_questions():
- service, _, clock, triage, lane = _triage_service(
- triage=FakeTriage(questions=None)
- )
- service.handle_event(_transcript(clock, "hello"))
- clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
- service.tick()
- assert lane.submits == []
- assert triage.build_state_calls == []
- def test_maybe_triage_dedupes_identical_window():
- service, _, clock, triage, lane = _triage_service()
- service.handle_event(_transcript(clock, "hello"))
- clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
- service.tick()
- assert len(lane.submits) == 1
- state, questions, lang, gen = lane.submits[0]
- assert state == "- Unknown: hello"
- assert questions is triage.questions
- assert lang is None
- assert gen == 0
- service.tick()
- service.tick()
- assert len(lane.submits) == 1
- service.handle_event(_transcript(clock, "second"))
- clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
- service.tick()
- assert len(lane.submits) == 2
- assert lane.submits[1][0] == "- Unknown: hello\n- Unknown: second"
- def test_second_transcript_produces_second_submit():
- service, _, clock, _, lane = _triage_service()
- service.handle_event(_transcript(clock, "first"))
- clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
- service.tick()
- assert len(lane.submits) == 1
- service.handle_event(_transcript(clock, "second"))
- clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
- service.tick()
- assert len(lane.submits) == 2
- assert lane.submits[1][0] == "- Unknown: first\n- Unknown: second"
- def test_tick_under_50ms_with_blocked_lane():
- service, _, clock, _, lane = _triage_service()
- assert not lane.predict_gate.is_set()
- service.toggle_chat()
- service.handle_event(_transcript(clock, "hello"))
- clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
- start = time.perf_counter()
- service.tick()
- elapsed = time.perf_counter() - start
- assert len(lane.submits) == 1
- assert elapsed < 0.05
- def test_on_triage_result_emits_signals():
- service, emitted, clock, _, lane = _triage_service()
- service.toggle_chat()
- service.handle_event(_transcript(clock, "hello"))
- clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
- service.tick()
- _, _, _, gen = lane.submits[0]
- payload = {
- "order": ["urgency"],
- "items": {"urgency": {"kind": "noul"}},
- "escalated": False,
- "input_tokens": 12,
- }
- service._on_triage_result(gen, payload)
- staged = _triage_events(emitted)
- assert len(staged) == 1
- assert staged[0]["stage"] == "signals"
- assert staged[0]["triage"] == service.last_triage
- assert staged[0]["triage"]["escalated"] is False
- assert staged[0]["triage"]["input_tokens"] == 12
- assert service.status()["triage"] == service.last_triage
- def test_triage_events_carry_the_server_timestamp():
- service, emitted, clock, _, lane = _triage_service(brief_fn=lambda prompt: "RAW")
- service.toggle_chat()
- service.handle_event(_transcript(clock, "hello"))
- clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
- service.tick()
- _, _, _, gen = lane.submits[0]
- expected_ts = clock()
- service._on_triage_result(gen, _escalated_payload())
- signals = [e for e in _triage_events(emitted) if e.get("stage") == "signals"]
- assert len(signals) == 1
- assert isinstance(signals[0]["ts"], (int, float))
- assert signals[0]["ts"] == expected_ts
- job = [j for j in service._inference._queue if j.name == "brief-update"][0]
- job.run()
- contents = [e for e in _triage_events(emitted) if e.get("stage") == "content"]
- assert len(contents) == 1
- assert isinstance(contents[0]["ts"], (int, float))
- assert contents[0]["ts"] == expected_ts # content reuses the signals timestamp
- def test_on_triage_result_suppresses_stale_generation():
- service, emitted, clock, _, lane = _triage_service()
- service.toggle_chat()
- service.handle_event(_transcript(clock, "hello"))
- clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
- service.tick()
- _, _, _, gen = lane.submits[0]
- service.clear()
- service._on_triage_result(gen, _escalated_payload())
- assert service.last_triage is None
- assert [e for e in _triage_events(emitted) if e.get("stage") == "signals"] == []
- service.handle_event(_transcript(clock, "hello"))
- clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
- service.tick()
- assert len(lane.submits) == 2
- def test_pending_brief_capped_by_char_budget():
- """The buffer keeps the newest deltas within budget, dropping the oldest."""
- service, _, clock, _, _ = _triage_service(brief_fn=lambda prompt: "RAW")
- service.cfg.triage.brief_pending_char_budget = 30
- service.handle_event(_transcript(clock, "aaa"))
- service.handle_event(_transcript(clock, "bbbb"))
- assert service._pending_brief == ["Unknown: aaa", "Unknown: bbbb"]
- service.handle_event(_transcript(clock, "ccccc"))
- assert service._pending_brief == ["Unknown: bbbb", "Unknown: ccccc"]
- assert service.triage_history == ["Unknown: aaa", "Unknown: bbbb", "Unknown: ccccc"]
- def test_pending_brief_untouched_without_triage():
- service, _, clock = _service()
- service.handle_event(_transcript(clock, "hello"))
- assert service._pending_brief == []
- assert service.triage_history == ["Unknown: hello"]
- def test_on_triage_result_accepts_non_chat_mode():
- service, emitted, clock, _, lane = _triage_service()
- service.handle_event(_transcript(clock, "hello"))
- clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
- service.tick()
- _, _, _, gen = lane.submits[0]
- window = service._last_triage_window
- service._on_triage_result(gen, _escalated_payload())
- assert service.last_triage is not None
- assert service._last_triage_window == window
- assert [e.get("stage") for e in _triage_events(emitted)] == ["signals"]
- def test_on_triage_result_ignores_none_payload():
- service, emitted, clock, _, lane = _triage_service()
- service.toggle_chat()
- service.handle_event(_transcript(clock, "hello"))
- clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
- service.tick()
- _, _, _, gen = lane.submits[0]
- service._on_triage_result(gen, None)
- assert service.last_triage is None
- assert _triage_events(emitted) == []
- def test_none_payload_dispatches_nothing_and_keeps_deltas():
- """A Laya predict failure never dispatches: no job, no events, deltas stay."""
- calls: list[str] = []
- service, emitted, clock, _, lane = _triage_service(
- brief_fn=lambda prompt: calls.append(prompt) or "RAW"
- )
- service.toggle_chat()
- service.set_chat_capture(True)
- service.handle_event(_transcript(clock, "hello"))
- clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
- service.tick()
- _, _, _, gen = lane.submits[0]
- assert service._pending_brief == ["Unknown: hello"]
- service._on_triage_result(gen, None)
- assert service.last_triage is None
- assert [e.get("stage") for e in _triage_events(emitted)] == []
- assert [j.name for j in service._inference._queue] == ["chat"]
- assert calls == []
- assert service._pending_brief == ["Unknown: hello"]
- assert service._brief_outstanding is False
- def test_none_payload_without_brief_fn_enqueues_nothing():
- service, emitted, clock, _, lane = _triage_service()
- service.toggle_chat()
- service.set_chat_capture(True)
- service.handle_event(_transcript(clock, "hello"))
- clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
- service.tick()
- _, _, _, gen = lane.submits[0]
- service._on_triage_result(gen, None)
- assert service.last_triage is None
- assert _triage_events(emitted) == []
- assert [j.name for j in service._inference._queue] == ["chat"]
- assert service._pending_brief == ["Unknown: hello"]
- def test_on_triage_result_ignores_empty_signals():
- service, emitted, clock, _, lane = _triage_service(
- triage=FakeTriage(normalized={})
- )
- service.toggle_chat()
- service.handle_event(_transcript(clock, "hello"))
- clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
- service.tick()
- _, _, _, gen = lane.submits[0]
- service._on_triage_result(gen, _escalated_payload())
- assert service.last_triage is None
- assert _triage_events(emitted) == []
- def test_substantive_turn_dispatches_one_brief_job():
- """A substantive settled turn calls the gate once and queues one brief job."""
- service, emitted, clock, triage, lane = _triage_service(
- triage=FakeTriage(escalate=True), brief_fn=lambda prompt: "RAW"
- )
- service.toggle_chat()
- service.set_chat_capture(True)
- service.handle_event(_transcript(clock, "we might churn"))
- clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
- service.tick()
- _, _, _, gen = lane.submits[0]
- service._on_triage_result(
- gen, {"order": [], "items": {}, "escalated": False, "input_tokens": 0}
- )
- assert service.last_triage is not None
- assert service.last_triage["escalated"] is True
- assert service._last_brief_signals == service.last_triage
- assert service._inference.depth() == 2
- assert [j.name for j in service._inference._queue] == ["chat", "brief-update"]
- assert [e.get("stage") for e in _triage_events(emitted)] == ["signals"]
- assert len(triage.gate_calls) == 1
- assert service._brief_outstanding is True
- assert service._brief_token == 1
- def test_brief_dispatches_without_escalation():
- service, _, clock, _, lane = _triage_service(brief_fn=lambda prompt: "RAW")
- service.toggle_chat()
- service.set_chat_capture(True)
- service.handle_event(_transcript(clock, "all calm"))
- clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
- service.tick()
- _, _, _, gen = lane.submits[0]
- service._on_triage_result(
- gen, {"order": [], "items": {}, "escalated": False, "input_tokens": 0}
- )
- assert service.last_triage is not None
- assert service._inference.depth() == 2
- assert [j.name for j in service._inference._queue] == ["chat", "brief-update"]
- def test_gated_out_turn_skips_brief():
- """A gated-out turn stores signals but never calls brief_fn."""
- calls: list[str] = []
- service, emitted, clock, triage, lane = _triage_service(
- triage=FakeTriage(gate=False),
- brief_fn=lambda prompt: calls.append(prompt) or "RAW",
- )
- service.toggle_chat()
- service.set_chat_capture(True)
- service.handle_event(_transcript(clock, "small talk"))
- clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
- service.tick()
- _, _, _, gen = lane.submits[0]
- service._on_triage_result(gen, _escalated_payload())
- assert service.last_triage is not None
- assert "brief" not in service.last_triage # no prior brief to retain
- assert [e.get("stage") for e in _triage_events(emitted)] == ["signals"]
- assert calls == []
- assert [j.name for j in service._inference._queue] == ["chat"]
- assert service._brief_outstanding is False
- assert len(triage.gate_calls) == 1
- def test_gated_out_turn_retains_previous_brief():
- """A gated-out settled turn keeps the last accepted brief in the panel."""
- service, emitted, clock, triage, lane = _triage_service(
- triage=FakeTriage(gate=False), brief_fn=lambda prompt: "RAW"
- )
- service.toggle_chat()
- signals = _escalated_payload()
- service._last_brief_signals = signals
- token = _seed_brief(service, "Unknown: first")
- service._run_brief_update(0, signals, service._now(), token)
- assert service.last_triage is not None
- assert service.last_triage["brief"] == "RAW"
- emitted.clear()
- service.handle_event(_transcript(clock, "small talk"))
- clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
- service.tick()
- _, _, _, gen = lane.submits[0]
- service._on_triage_result(gen, _escalated_payload())
- assert service.last_triage is not None
- assert service.last_triage["brief"] == "RAW"
- assert "brief" not in service._last_brief_signals # raw signals stay raw
- staged = [e for e in _triage_events(emitted) if e.get("stage") == "signals"]
- assert len(staged) == 1
- assert staged[0]["triage"] == service.last_triage
- assert staged[0]["triage"]["brief"] == "RAW"
- assert len(triage.gate_calls) == 1
- def test_gated_out_turn_retains_brief_when_extract_disabled():
- """`extract_enabled = false` skips the dispatch but still retains the brief."""
- service, emitted, clock, _, lane = _triage_service(
- triage=FakeTriage(gate=False), brief_fn=lambda prompt: "RAW"
- )
- service.toggle_chat()
- service.set_chat_capture(True)
- signals = _escalated_payload()
- service._last_brief_signals = signals
- token = _seed_brief(service, "Unknown: first")
- service._run_brief_update(0, signals, service._now(), token)
- assert service.last_triage is not None
- assert service.last_triage["brief"] == "RAW"
- service.cfg.triage.extract_enabled = False
- emitted.clear()
- service.handle_event(_transcript(clock, "small talk"))
- clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
- service.tick()
- _, _, _, gen = lane.submits[0]
- service._on_triage_result(gen, _escalated_payload())
- assert service.last_triage is not None
- assert service.last_triage["brief"] == "RAW"
- assert [j.name for j in service._inference._queue] == ["chat"]
- staged = [e for e in _triage_events(emitted) if e.get("stage") == "signals"]
- assert staged[0]["triage"]["brief"] == "RAW"
- def test_gated_out_turn_retains_brief_without_brief_fn():
- """No brief_fn means no dispatch, but a retained brief is still carried."""
- service, emitted, clock, _, lane = _triage_service(triage=FakeTriage(gate=False))
- service.toggle_chat()
- service.last_triage = {**_escalated_payload(), "brief": "KEEP"}
- emitted.clear()
- service.handle_event(_transcript(clock, "small talk"))
- clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
- service.tick()
- _, _, _, gen = lane.submits[0]
- service._on_triage_result(gen, _escalated_payload())
- assert service.last_triage["brief"] == "KEEP"
- staged = [e for e in _triage_events(emitted) if e.get("stage") == "signals"]
- assert staged[0]["triage"]["brief"] == "KEEP"
- def test_later_accepted_update_replaces_retained_brief():
- """A later accepted update overwrites the retained brief text."""
- texts = iter(["OLD", "NEW"])
- service, emitted, _, _, _ = _triage_service(brief_fn=lambda prompt: next(texts))
- service.toggle_chat()
- signals = _escalated_payload()
- service._last_brief_signals = signals
- token = _seed_brief(service, "Unknown: first")
- service._run_brief_update(0, signals, service._now(), token)
- assert service.last_triage is not None
- assert service.last_triage["brief"] == "OLD"
- token = _seed_brief(service, "Unknown: second")
- service._run_brief_update(0, signals, service._now(), token)
- assert service.last_triage is not None
- assert service.last_triage["brief"] == "NEW"
- contents = [e for e in _triage_events(emitted) if e.get("stage") == "content"]
- assert contents[-1]["triage"]["brief"] == "NEW"
- service.clear()
- assert service.last_triage is None
- def test_no_brief_when_disabled_in_config():
- calls: list[str] = []
- service, _, clock, _, lane = _triage_service(
- triage=FakeTriage(escalate=True),
- brief_fn=lambda prompt: calls.append(prompt) or "RAW",
- )
- service.cfg.triage.extract_enabled = False
- service.toggle_chat()
- service.set_chat_capture(True)
- service.handle_event(_transcript(clock, "churn risk"))
- clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
- service.tick()
- _, _, _, gen = lane.submits[0]
- service._on_triage_result(gen, _escalated_payload())
- assert service.last_triage is not None
- assert service.last_triage["escalated"] is True
- assert calls == []
- assert [j.name for j in service._inference._queue] == ["chat"]
- def test_no_brief_without_brief_fn():
- service, _, clock, _, lane = _triage_service(triage=FakeTriage(escalate=True))
- service.toggle_chat()
- service.set_chat_capture(True)
- service.handle_event(_transcript(clock, "churn risk"))
- clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
- service.tick()
- _, _, _, gen = lane.submits[0]
- service._on_triage_result(gen, _escalated_payload())
- assert service.last_triage is not None
- assert [j.name for j in service._inference._queue] == ["chat"]
- assert service._brief_outstanding is False
- def test_brief_refused_when_queue_full():
- """A refused submit leaves deltas buffered and the outstanding flag clear."""
- service, emitted, clock, _, lane = _triage_service(
- triage=FakeTriage(escalate=True), brief_fn=lambda prompt: "RAW"
- )
- service._inference = InferenceQueue(size=2)
- service.toggle_chat()
- service.set_chat_capture(True)
- service.handle_event(_transcript(clock, "churn risk"))
- clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
- service.tick()
- assert service._inference.depth() == 1
- _, _, _, gen = lane.submits[0]
- service._on_triage_result(gen, _escalated_payload())
- assert service._inference.depth() == 1
- assert service._inference._queue[0].name == "chat"
- assert service.last_triage is not None
- assert service.last_triage["escalated"] is True
- assert [e.get("stage") for e in _triage_events(emitted)] == ["signals"]
- assert service._pending_brief == ["Unknown: churn risk"]
- assert service._brief_outstanding is False
- def test_second_result_while_outstanding_is_refused():
- """At most one brief job is outstanding: the second turn only stores signals."""
- service, emitted, clock, _, lane = _triage_service(brief_fn=lambda prompt: "RAW")
- service.toggle_chat()
- service.set_chat_capture(True)
- service.handle_event(_transcript(clock, "first"))
- clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
- service.tick()
- _, _, _, gen0 = lane.submits[0]
- service._on_triage_result(gen0, _escalated_payload())
- assert [j.name for j in service._inference._queue] == ["chat", "brief-update"]
- service.handle_event(_transcript(clock, "second"))
- clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
- service.tick()
- _, _, _, gen1 = lane.submits[1]
- service._on_triage_result(gen1, _escalated_payload())
- jobs = [j for j in service._inference._queue if j.name == "brief-update"]
- assert len(jobs) == 1
- assert [e.get("stage") for e in _triage_events(emitted)] == ["signals", "signals"]
- assert service._brief_outstanding is True
- assert service._pending_brief == ["Unknown: first", "Unknown: second"]
- def _seed_brief(service, *deltas):
- service._pending_brief = list(deltas)
- service._brief_outstanding = True
- return service._brief_token
- def test_ledger_records_fact_and_survives_model_reemit():
- """A recorded fact persists even when a later reply omits it."""
- first = _brief_reply("Summary: rolling", ["The budget was $305 million."])
- second = _brief_reply("Summary: newer", [])
- replies = iter([first, second])
- service, _, _, _, _ = _triage_service(brief_fn=lambda prompt: next(replies))
- service._pending_brief = ["Unknown: one"]
- service._brief_outstanding = True
- service._run_brief_update(0, _escalated_payload(), service._now(), service._brief_token)
- service._pending_brief = ["Unknown: two"]
- service._brief_outstanding = True
- service._run_brief_update(0, _escalated_payload(), service._now(), service._brief_token)
- assert service.last_triage is not None
- brief = service.last_triage["brief"]
- assert "The budget was $305 million." in brief
- assert service._fact_ledger.facts() == ["The budget was $305 million."]
- def test_ledger_dedupes_repeated_fact():
- """The same fact proposed twice is recorded once."""
- reply = _brief_reply("Summary: s", ["Sense could find prey.", "sense could find prey"])
- service, _, _, _, _ = _triage_service(brief_fn=lambda prompt: reply)
- service._pending_brief = ["Unknown: one"]
- service._brief_outstanding = True
- service._run_brief_update(0, _escalated_payload(), service._now(), service._brief_token)
- assert service._fact_ledger.facts() == ["Sense could find prey."]
- def test_truncated_brief_reply_keeps_prior_narrative_and_facts():
- """A reply cut at the token limit must not replace the accepted narrative."""
- sink = FakeDebugSink()
- replies = iter(
- [
- _brief_reply("Summary: good\n\nOpen Questions:\n- who owns it?"),
- _brief_reply("Summary: cut mid-wor", ["fact one durable", "fact two"]),
- ]
- )
- service, _, _, _, _ = _triage_service(
- brief_fn=lambda prompt: next(replies),
- brief_finish=lambda text: "length" if "cut mid-wor" in text else "stop",
- debug_sink=sink,
- )
- service._pending_brief = ["Unknown: one"]
- service._brief_outstanding = True
- service._run_brief_update(0, _escalated_payload(), service._now(), service._brief_token)
- service._pending_brief = ["Unknown: two"]
- service._brief_outstanding = True
- service._run_brief_update(0, _escalated_payload(), service._now(), service._brief_token)
- assert service._last_brief_narrative.startswith("Summary: good")
- assert "cut mid-wor" not in service.last_triage["brief"]
- assert service._fact_ledger.facts() == ["fact one durable"]
- rejects = [
- event
- for event in sink.events
- if event[0] == "triage-brief" and event[1].get("action") == "reject"
- ]
- assert rejects
- assert rejects[-1][1]["reason"] == "truncated"
- def test_brief_rewrite_that_drops_a_section_is_rejected():
- """Dropping a canonical section keeps the prior, more complete brief."""
- replies = iter(
- [
- _brief_reply("Summary: full\n\nOpen Questions:\n- who owns it?"),
- _brief_reply("Summary: only"),
- ]
- )
- service, _, _, _, _ = _triage_service(brief_fn=lambda prompt: next(replies))
- service._pending_brief = ["Unknown: one"]
- service._brief_outstanding = True
- service._run_brief_update(0, _escalated_payload(), service._now(), service._brief_token)
- service._pending_brief = ["Unknown: two"]
- service._brief_outstanding = True
- service._run_brief_update(0, _escalated_payload(), service._now(), service._brief_token)
- assert "Open Questions:" in service.last_triage["brief"]
- assert "Summary: only" not in service.last_triage["brief"]
- def test_ledger_prompt_carries_ledger_and_narrative():
- """The brief request hands the model the ledger, narrative, and new deltas."""
- seen: list[str] = []
- service, _, _, _, _ = _triage_service(
- brief_fn=lambda prompt: seen.append(prompt) or _brief_reply("UPDATED")
- )
- service._fact_ledger.merge(["PRIOR FACT"])
- service._last_brief_narrative = "PRIOR NARRATIVE"
- service._pending_brief = ["Unknown: hello there"]
- service._brief_outstanding = True
- service._run_brief_update(0, _escalated_payload(), service._now(), service._brief_token)
- assert len(seen) == 1
- assert "CURRENT LEDGER:" in seen[0]
- assert "- PRIOR FACT" in seen[0]
- assert "CURRENT BRIEF:\nPRIOR NARRATIVE" in seen[0]
- assert "NEW UTTERANCES:\n- Unknown: hello there" in seen[0]
- def test_brief_merges_content_and_writes_file():
- brief_file = FakeBriefFile()
- service, emitted, _, triage, _ = _triage_service(
- brief_fn=lambda prompt: "the brief", brief_file=brief_file
- )
- service.toggle_chat()
- signals = _escalated_payload()
- service._last_brief_signals = signals
- token = _seed_brief(service, "Unknown: hello")
- ts = service._now()
- service._run_brief_update(0, signals, ts, token)
- contents = [e for e in _triage_events(emitted) if e.get("stage") == "content"]
- assert len(contents) == 1
- assert contents[0]["triage"] == {**signals, "brief": "the brief"}
- assert service.last_triage == contents[0]["triage"]
- assert triage.prompt_calls == [(("Unknown: hello",), signals)]
- assert brief_file.writes == ["the brief"]
- assert service._pending_brief == []
- assert service._brief_outstanding is False
- def test_empty_brief_requeues_deltas():
- """A `""` reply keeps signals, re-buffers the deltas, and clears the flag."""
- service, emitted, _, _, _ = _triage_service(brief_fn=lambda prompt: "")
- service.toggle_chat()
- signals = _escalated_payload()
- service.last_triage = signals
- service._last_brief_signals = signals
- token = _seed_brief(service, "Unknown: hello")
- ts = service._now()
- service._run_brief_update(0, signals, ts, token)
- assert [e for e in _triage_events(emitted) if e.get("stage") == "content"] == []
- assert service.last_triage == signals
- assert "brief" not in service.last_triage
- assert service._pending_brief == ["Unknown: hello"]
- assert service._brief_outstanding is False
- def test_brief_error_requeues_and_clears_flag():
- """A raising brief_fn leaves the flag clear and the deltas buffered."""
- def boom(prompt):
- raise RuntimeError("llm down")
- service, emitted, _, _, _ = _triage_service(brief_fn=boom)
- service.toggle_chat()
- token = _seed_brief(service, "Unknown: hello")
- ts = service._now()
- service._run_brief_update(0, _escalated_payload(), ts, token)
- assert _triage_events(emitted) == []
- assert service.last_triage is None
- assert service._pending_brief == ["Unknown: hello"]
- assert service._brief_outstanding is False
- def test_brief_empty_buffer_returns_early():
- """An empty buffer returns early: no call, no event, flag cleared."""
- calls: list[str] = []
- service, emitted, _, _, _ = _triage_service(
- brief_fn=lambda prompt: calls.append(prompt) or "RAW"
- )
- service.toggle_chat()
- service._brief_outstanding = True
- token = service._brief_token
- ts = service._now()
- assert service._pending_brief == []
- service._run_brief_update(0, _escalated_payload(), ts, token)
- assert calls == []
- assert _triage_events(emitted) == []
- assert service._brief_outstanding is False
- def test_brief_suppressed_after_reset():
- service, emitted, _, _, _ = _triage_service(brief_fn=lambda prompt: "RAW")
- service.toggle_chat()
- service._pending_brief = ["Unknown: hello"]
- service._reset_triage()
- emitted.clear()
- service._run_brief_update(0, _escalated_payload(), service._now(), 0)
- assert _triage_events(emitted) == []
- assert service.last_triage is None
- assert service._pending_brief == ["Unknown: hello"]
- def test_brief_works_after_leaving_chat():
- seen = []
- service, emitted, _, _, _ = _triage_service(
- brief_fn=lambda prompt: seen.append(prompt) or "RAW"
- )
- service.toggle_chat()
- assert service.modes.exit_chat() is True
- token = _seed_brief(service, "Unknown: hello")
- signals = _escalated_payload()
- service._last_brief_signals = signals
- service._run_brief_update(0, signals, service._now(), token)
- assert seen != []
- assert [e.get("stage") for e in _triage_events(emitted)] == ["content"]
- assert service.last_triage is not None
- assert service.last_triage["brief"] == "RAW"
- def test_deltas_arriving_during_call_survive_and_flush():
- """Deltas appended mid-call are not consumed; the finally flushes them."""
- service, emitted, clock, _, _ = _triage_service()
- service.toggle_chat()
- signals = _escalated_payload()
- service._last_brief_signals = signals
- token = _seed_brief(service, "Unknown: first")
- appended: list[int] = []
- def _brief(prompt, on_io=None, finalize=None):
- if not appended:
- appended.append(1)
- service.handle_event(_transcript(clock, "during call"))
- return _brief_reply("first brief")
- service._brief_fn = _brief
- service._run_brief_update(0, signals, clock(), token)
- contents = [e for e in _triage_events(emitted) if e.get("stage") == "content"]
- assert len(contents) == 1
- assert contents[0]["triage"]["brief"] == "first brief"
- flushed = [j for j in service._inference._queue if j.name == "brief-update"]
- assert len(flushed) == 1
- assert service._brief_outstanding is True
- assert service._pending_brief == ["Unknown: during call"]
- flushed[0].run()
- contents = [e for e in _triage_events(emitted) if e.get("stage") == "content"]
- assert len(contents) == 2
- assert contents[1]["triage"]["brief"] == "first brief"
- assert service._pending_brief == []
- assert service._brief_outstanding is False
- def test_in_flight_brief_after_clear_emits_and_writes_nothing():
- """Stale in-flight job: no event, no file write, no requeue, flag untouched."""
- brief_file = FakeBriefFile()
- service, emitted, clock, _, lane = _triage_service(
- brief_fn=lambda prompt: "RAW", brief_file=brief_file
- )
- service.toggle_chat()
- service.handle_event(_transcript(clock, "hello"))
- clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
- service.tick()
- _, _, _, gen = lane.submits[0]
- service._on_triage_result(gen, _escalated_payload())
- job = [j for j in service._inference._queue if j.name == "brief-update"][0]
- assert service._brief_outstanding is True
- service.clear()
- assert service._brief_outstanding is False
- token_after_clear = service._brief_token
- emitted.clear()
- job.run()
- assert [e for e in _triage_events(emitted)] == []
- assert brief_file.writes == []
- assert service._pending_brief == []
- assert service.last_triage is None
- assert service._brief_token == token_after_clear
- assert service._brief_outstanding is False
- def test_clear_resets_triage():
- resets: list[int] = []
- chats: list[int] = []
- brief_file = FakeBriefFile()
- service, emitted, clock, _, lane = _triage_service(
- triage=FakeTriage(escalate=True),
- brief_fn=lambda prompt: "RAW",
- brief_file=brief_file,
- brief_reset=lambda: resets.append(1),
- chat_reset=lambda: chats.append(1),
- )
- service.toggle_chat()
- service.set_chat_capture(True)
- service.handle_event(_transcript(clock, "churn"))
- clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
- service.tick()
- _, _, _, gen = lane.submits[0]
- service._on_triage_result(gen, _escalated_payload())
- assert service._inference.depth() == 2
- assert service._pending_brief == ["Unknown: churn"]
- assert service._brief_outstanding is True
- token_before = service._brief_token
- assert service.clear() is True
- assert service._triage_generation == 1
- assert service.last_triage is None
- assert service._last_triage_window == ()
- assert service.triage_history == []
- assert service._pending_brief == []
- assert service._brief_token == token_before + 1
- assert service._brief_outstanding is False
- assert service._last_brief_signals is None
- assert resets == [1]
- assert brief_file.clears == 1
- assert chats == [1]
- assert lane.drops == 1
- assert service._inference.depth() == 0
- assert list(service._inference._queue) == []
- cleared = [e for e in _triage_events(emitted) if e.get("stage") == "cleared"]
- assert len(cleared) == 1
- assert cleared[0]["triage"] is None
- assert {"type": "cleared"} in emitted
- signals_before = len(
- [e for e in _triage_events(emitted) if e.get("stage") == "signals"]
- )
- service._on_triage_result(gen, _escalated_payload())
- assert service.last_triage is None
- assert (
- len([e for e in _triage_events(emitted) if e.get("stage") == "signals"])
- == signals_before
- )
- submits_before = len(lane.submits)
- clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
- service.tick()
- assert len(lane.submits) == submits_before
- def test_exit_chat_does_not_reset_triage():
- chats: list[int] = []
- bresets: list[int] = []
- brief_file = FakeBriefFile()
- service, emitted, clock, _, lane = _triage_service(
- brief_fn=lambda prompt: "RAW",
- chat_reset=lambda: chats.append(1),
- brief_reset=lambda: bresets.append(1),
- brief_file=brief_file,
- )
- service.toggle_chat()
- service.handle_event(_transcript(clock, "hello"))
- clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
- service.tick()
- assert len(lane.submits) == 1
- _, _, _, gen = lane.submits[0]
- service._on_triage_result(gen, _escalated_payload())
- assert service.last_triage is not None
- assert service._triage_generation == 0
- assert service.toggle_chat() is True
- assert service.modes.mode.value == "idle"
- assert service._triage_generation == 0
- assert service.last_triage is not None
- assert service._last_triage_window == ("Unknown: hello",)
- assert service.triage_history == ["Unknown: hello"]
- assert service._pending_brief == ["Unknown: hello"]
- assert service._last_brief_signals is not None
- assert service._brief_outstanding is True
- assert lane.drops == 0
- cleared = [e for e in _triage_events(emitted) if e.get("stage") == "cleared"]
- assert cleared == []
- assert chats == []
- assert bresets == []
- assert brief_file.clears == 0
- def test_toggle_chat_enter_does_not_touch_triage():
- """Entering chat resets only the chat buffers; the brief engine is independent."""
- bresets: list[int] = []
- brief_file = FakeBriefFile()
- service, emitted, clock, _, lane = _triage_service(
- brief_fn=lambda prompt: "RAW",
- brief_reset=lambda: bresets.append(1),
- brief_file=brief_file,
- )
- service.handle_event(_transcript(clock, "hello"))
- clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
- service.tick()
- _, _, _, gen = lane.submits[0]
- service._on_triage_result(gen, _escalated_payload())
- triage_before = service.last_triage
- pending_before = list(service._pending_brief)
- assert service.toggle_chat() is True
- assert service.modes.mode.value == "chat"
- assert service._triage_generation == 0
- assert service.last_triage is triage_before
- assert service._last_triage_window == ("Unknown: hello",)
- assert service.triage_history == ["Unknown: hello"]
- assert service._pending_brief == pending_before
- assert service._last_brief_signals is not None
- assert service._brief_outstanding is True
- assert lane.drops == 0
- assert bresets == []
- assert brief_file.clears == 0
- cleared = [e for e in _triage_events(emitted) if e.get("stage") == "cleared"]
- assert cleared == []
- def test_clear_without_triage_emits_no_triage_event():
- service, emitted, _ = _service()
- brief_file = FakeBriefFile()
- bresets: list[int] = []
- service._brief_file = brief_file
- service._brief_reset = lambda: bresets.append(1)
- service.clear()
- assert {"type": "cleared"} in emitted
- assert _triage_events(emitted) == []
- assert brief_file.clears == 1
- assert bresets == []
- def test_stale_brief_after_clear_does_not_clear_newer_dispatch_flag():
- """A stale in-flight job must not clear a newer dispatch's outstanding flag."""
- brief_file = FakeBriefFile()
- service, emitted, clock, _, lane = _triage_service(
- brief_fn=lambda prompt: "RAW", brief_file=brief_file
- )
- service.toggle_chat()
- service.set_chat_capture(True)
- service.handle_event(_transcript(clock, "hello"))
- clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
- service.tick()
- _, _, _, gen = lane.submits[0]
- service._on_triage_result(gen, _escalated_payload())
- stale_job = [j for j in service._inference._queue if j.name == "brief-update"][0]
- assert service._brief_outstanding is True
- service.clear()
- # A fresh turn dispatches a new brief AFTER clear bumped the token.
- service.handle_event(_transcript(clock, "fresh"))
- clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
- service.tick()
- _, _, _, gen2 = lane.submits[1]
- service._on_triage_result(gen2, _escalated_payload())
- assert service._brief_outstanding is True
- newer_token = service._brief_token
- pending_before = list(service._pending_brief)
- triage_before = service.last_triage
- emitted.clear()
- stale_job.run()
- assert _triage_events(emitted) == []
- assert brief_file.writes == []
- assert service._pending_brief == pending_before
- assert service._brief_outstanding is True
- assert service._brief_token == newer_token
- assert service.last_triage is triage_before
- def test_clear_resets_chat_latch():
- service, emitted, _ = _service()
- service.toggle_chat()
- service._chat_queue_full = True
- service._pending_chat = ["stuck text"]
- service.clear()
- assert service._chat_queue_full is False
- assert service._pending_chat == []
- assert {"type": "cleared"} in emitted
- def test_triage_end_to_end_signals_content_cleared():
- """Two settled turns collapse into ONE brief job (single-outstanding guard).
- The second `_on_triage_result` is refused as `"outstanding"`, so the queue
- holds one `brief-update` that consumes both deltas and emits one `content`.
- The panel keeps the FIRST turn's signals until the next settled turn (lag).
- """
- prompts: list[str] = []
- service, emitted, clock, triage, lane = _triage_service(
- brief_fn=lambda prompt: prompts.append(prompt) or "the brief"
- )
- service.toggle_chat()
- service.set_chat_capture(True)
- service.handle_event(_transcript(clock, "first thought"))
- clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
- service.tick()
- assert len(lane.submits) == 1
- _, _, _, gen0 = lane.submits[0]
- service._on_triage_result(
- gen0, {"order": ["urgency"], "items": {}, "escalated": False, "input_tokens": 1}
- )
- assert [e.get("stage") for e in _triage_events(emitted)] == ["signals"]
- assert prompts == []
- assert service.last_triage is not None
- assert service.last_triage["escalated"] is False
- assert [j.name for j in service._inference._queue] == ["chat", "brief-update"]
- triage._escalate = True
- service.handle_event(_transcript(clock, "we might churn"))
- clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
- service.tick()
- assert len(lane.submits) == 2
- _, _, _, gen1 = lane.submits[1]
- service._on_triage_result(gen1, _escalated_payload())
- assert [e.get("stage") for e in _triage_events(emitted)] == ["signals", "signals"]
- assert [j.name for j in service._inference._queue] == [
- "chat",
- "brief-update",
- "chat",
- ]
- for job in [j for j in service._inference._queue if j.name == "brief-update"]:
- job.run()
- contents = [e for e in _triage_events(emitted) if e.get("stage") == "content"]
- assert len(contents) == 1
- assert len(prompts) == 1
- deltas, _ = triage.prompt_calls[0]
- assert deltas == ("Unknown: first thought", "Unknown: we might churn")
- assert contents[0]["triage"]["escalated"] is False
- assert contents[0]["triage"]["brief"] == "the brief"
- assert service.last_triage == contents[0]["triage"]
- assert service.status()["triage"] == contents[0]["triage"]
- service.clear()
- cleared = [e for e in _triage_events(emitted) if e.get("stage") == "cleared"]
- assert len(cleared) == 1
- assert cleared[0]["triage"] is None
- assert service.last_triage is None
- service._on_triage_result(gen1, _escalated_payload())
- assert [e.get("stage") for e in _triage_events(emitted)] == [
- "signals",
- "signals",
- "content",
- "cleared",
- ]
- assert service.toggle_chat() is True
- service.handle_event(_transcript(clock, "idle thought"))
- clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
- service.tick()
- assert len(lane.submits) == 3
- assert lane.submits[2][0].endswith("- Unknown: idle thought")
- def test_tick_emits_status_on_triage_state_change():
- service, emitted, _, triage, _ = _triage_service(
- triage=FakeTriage(state_pair=("loading", "warming up"))
- )
- service.tick()
- statuses = [e for e in emitted if e["type"] == "status"]
- assert len(statuses) == 1
- assert statuses[0]["triage_state"] == "loading"
- assert statuses[0]["triage_reason"] == "warming up"
- assert "triage" in statuses[0]
- triage._state_pair = ("ok", "")
- service.tick()
- statuses = [e for e in emitted if e["type"] == "status"]
- assert len(statuses) == 2
- assert statuses[1]["triage_state"] == "ok"
- assert statuses[1]["triage_reason"] == ""
- assert "triage" in statuses[1]
- service.tick()
- assert len([e for e in emitted if e["type"] == "status"]) == 2
- def test_no_status_emitted_when_triage_disabled():
- service, emitted, _ = _service()
- service.tick()
- service.tick()
- assert [e for e in emitted if e["type"] == "status"] == []
- def test_tick_heals_triage_panel_after_lane_ready():
- import time as _time
- from pathlib import Path
- from stt_daemon.assistant.laya_lane import LayaLane
- from stt_daemon.assistant.triage import TriageAnalyzer
- from stt_daemon.tui.state import ViewState
- class _FakeRouter:
- def preload(self, names):
- return self
- def predict(self, state, questions, model=None, lang=None, **kwargs):
- if "_warmup" in questions:
- return {"model": model, "answers": {}, "usage": {}, "routing": {}}
- return {
- "model": model,
- "answers": {
- "frustration": {
- "noul": 0.1,
- "confidence": 0.9,
- "answer_confidence": 0.9,
- },
- "urgency": {
- "choice": "low",
- "confidence": 0.9,
- "answer_confidence": 0.9,
- },
- },
- "usage": {"input_tokens": 5},
- }
- def _factory(**kwargs):
- return _FakeRouter()
- cfg = Config()
- cfg.assistant.turn_gap_s = 0.5
- cfg.triage.questions_file = str(
- Path(__file__).resolve().parent.parent / "questions.example.json"
- )
- clock = Clock()
- emitted: list[dict] = []
- def emit(type_, **fields):
- emitted.append({"type": type_, **fields})
- analyzer = TriageAnalyzer(cfg.triage)
- assert analyzer.questions, "example questions must load"
- holder: dict = {}
- lane = LayaLane(
- cfg.triage,
- agent_factory=_factory,
- on_result=lambda gen, payload: holder["svc"]._on_triage_result(gen, payload),
- on_state=lambda state, reason: analyzer.refresh(state, reason),
- )
- service = AssistantService(
- cfg,
- FakeSubscriber(),
- emit=emit,
- time_fn=clock,
- triage=analyzer,
- laya_lane=lane,
- chat_fn=_ok_reply,
- )
- holder["svc"] = service
- try:
- lane.start()
- deadline = _time.monotonic() + 5.0
- while not lane.ready() and _time.monotonic() < deadline:
- _time.sleep(0.005)
- assert lane.ready(), "lane did not become ready"
- assert analyzer.state() == ("ok", "")
- service.tick()
- statuses = [e for e in emitted if e["type"] == "status"]
- assert statuses, "tick emitted no status after lane ready"
- assert statuses[-1]["triage_state"] == "ok"
- service.handle_event(_transcript(clock, "hello"))
- clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
- service.tick()
- deadline = _time.monotonic() + 5.0
- while service.last_triage is None and _time.monotonic() < deadline:
- _time.sleep(0.005)
- assert service.last_triage is not None, "no triage signals from lane"
- view = ViewState()
- for event in emitted:
- view.ingest(event)
- assert view.triage_state == "ok"
- lines = view.triage_lines()
- assert lines
- assert not any("unavailable" in line for line in lines)
- assert not any("loading" in line for line in lines)
- finally:
- lane.stop()
- def _dump_brief(prompt, on_io=None, finalize=None):
- """Brief fake that mimics LlmClient.chat's on_io phases."""
- if on_io is not None:
- on_io({"phase": "request", "url": "http://llm/v1", "body": {"prompt": prompt}})
- on_io(
- {
- "phase": "response",
- "payload": {"content": "parsed"},
- "error": None,
- "duration_ms": 250.0,
- }
- )
- return _brief_reply("BRIEF")
- def _run_triage_flow(service, emitted, clock, lane, payload):
- service.toggle_chat()
- service.set_chat_capture(True)
- service.handle_event(_transcript(clock, "hello"))
- clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
- service.tick()
- _, _, _, gen = lane.submits[0]
- service._on_triage_result(gen, payload)
- return gen
- def _dump_files(tmp_path):
- return list(tmp_path.rglob("*.json"))
- def test_dump_writes_full_laya_and_llm_io(tmp_path):
- service, emitted, clock, triage, lane = _triage_service(brief_fn=_dump_brief)
- service._triage_dump = TriageDumper(True, directory=str(tmp_path))
- service.cfg.triage.dump_io = True
- _run_triage_flow(service, emitted, clock, lane, _escalated_payload())
- jobs = [j for j in service._inference._queue if j.name == "brief-update"]
- assert len(jobs) == 1
- jobs[0].run()
- files = _dump_files(tmp_path)
- assert len(files) == 1
- assert re.fullmatch(r"\d{6}-\d{3}\.json", files[0].name)
- data = json.loads(files[0].read_text(encoding="utf-8"))
- assert data["ts"] == clock()
- assert isinstance(data["iso"], str) and data["iso"]
- assert data["laya"]["request"]["state"] == "- Unknown: hello"
- assert data["laya"]["request"]["questions"] == triage.questions
- assert data["laya"]["request"]["model"] == "multilingual"
- assert data["laya"]["request"]["max_len"] == 1024
- assert data["laya"]["response"] == _escalated_payload()
- assert data["laya"]["error"] is None
- assert data["llm"]["request"]["url"] == "http://llm/v1"
- assert data["llm"]["request"]["body"] == {
- "prompt": "CURRENT LEDGER:\n(none yet)\n\nCURRENT BRIEF:\n(none yet)\n\n"
- "NEW UTTERANCES:\n- Unknown: hello"
- }
- assert data["llm"]["response"] == {"content": "parsed"}
- assert data["llm"]["error"] is None
- assert data["llm"]["duration_ms"] == 250.0
- assert service._triage_dump._pending == {}
- def test_dump_laya_error_writes_laya_only_and_keeps_deltas(tmp_path):
- """A Laya predict failure finalizes the Laya half with `llm: null`.
- Nothing is dispatched, so no LLM half is ever recorded and the buffered
- deltas survive for the next settled turn.
- """
- service, emitted, clock, _, lane = _triage_service(brief_fn=_dump_brief)
- service._triage_dump = TriageDumper(True, directory=str(tmp_path))
- service.cfg.triage.dump_io = True
- _run_triage_flow(service, emitted, clock, lane, None)
- assert [j.name for j in service._inference._queue] == ["chat"]
- assert service._pending_brief == ["Unknown: hello"]
- files = _dump_files(tmp_path)
- assert len(files) == 1
- data = json.loads(files[0].read_text(encoding="utf-8"))
- assert data["laya"]["response"] is None
- assert data["laya"]["error"] == "predict failed"
- assert data["llm"] is None
- assert service._triage_dump._pending == {}
- def test_dump_without_brief_has_laya_only(tmp_path):
- service, emitted, clock, _, lane = _triage_service(brief_fn=_dump_brief)
- service._triage_dump = TriageDumper(True, directory=str(tmp_path))
- service.cfg.triage.dump_io = True
- service.cfg.triage.extract_enabled = False
- _run_triage_flow(service, emitted, clock, lane, _escalated_payload())
- files = _dump_files(tmp_path)
- assert len(files) == 1
- data = json.loads(files[0].read_text(encoding="utf-8"))
- assert data["laya"]["response"] == _escalated_payload()
- assert data["llm"] is None
- assert service._triage_dump._pending == {}
- def test_dump_queue_full_has_laya_only(tmp_path):
- service, emitted, clock, _, lane = _triage_service(brief_fn=_dump_brief)
- service._triage_dump = TriageDumper(True, directory=str(tmp_path))
- service.cfg.triage.dump_io = True
- service._inference = InferenceQueue(size=2)
- _run_triage_flow(service, emitted, clock, lane, _escalated_payload())
- assert service._inference.depth() == 1
- assert [j.name for j in service._inference._queue] == ["chat"]
- assert service._pending_brief == ["Unknown: hello"]
- files = _dump_files(tmp_path)
- assert len(files) == 1
- data = json.loads(files[0].read_text(encoding="utf-8"))
- assert data["laya"]["response"] == _escalated_payload()
- assert data["llm"] is None
- assert service._triage_dump._pending == {}
- def test_dump_disabled_writes_nothing(tmp_path):
- service, emitted, clock, _, lane = _triage_service(
- brief_fn=lambda prompt: "RAW"
- )
- assert service._triage_dump.enabled is False
- service._triage_dump = TriageDumper(False, directory=str(tmp_path))
- _run_triage_flow(service, emitted, clock, lane, _escalated_payload())
- jobs = [j for j in service._inference._queue if j.name == "brief-update"]
- assert len(jobs) == 1
- jobs[0].run()
- assert _dump_files(tmp_path) == []
- def test_dump_stale_result_discards_without_file(tmp_path):
- service, emitted, clock, triage, lane = _triage_service(brief_fn=_dump_brief)
- service._triage_dump = TriageDumper(True, directory=str(tmp_path))
- service.cfg.triage.dump_io = True
- service.toggle_chat()
- service.handle_event(_transcript(clock, "hello"))
- clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
- service.tick()
- _, _, _, gen = lane.submits[0]
- real_normalize = triage.normalize
- def stale_normalize(payload):
- # Simulate a clear landing between the first check/begin and the re-check.
- service._triage_generation += 1
- return real_normalize(payload)
- triage.normalize = stale_normalize
- service._on_triage_result(gen, _escalated_payload())
- assert _dump_files(tmp_path) == []
- assert service._triage_dump._pending == {}
- def test_dump_stale_brief_discards_without_file(tmp_path):
- service, _, clock, _, _ = _triage_service(brief_fn=_dump_brief)
- service._triage_dump = TriageDumper(True, directory=str(tmp_path))
- service.cfg.triage.dump_io = True
- ts = clock()
- service._triage_dump.begin(ts, laya={"request": {}, "response": {}, "error": None})
- service._pending_brief = ["Unknown: hello"]
- service._triage_generation += 1 # stale before the brief even starts
- service._run_brief_update(0, _escalated_payload(), ts, service._brief_token)
- assert _dump_files(tmp_path) == []
- assert service._triage_dump._pending == {}
- assert service._pending_brief == ["Unknown: hello"]
- def test_dump_brief_cleared_mid_flight_writes_nothing(tmp_path):
- service, _, clock, _, _ = _triage_service(brief_fn=_dump_brief)
- service._triage_dump = TriageDumper(True, directory=str(tmp_path))
- service.cfg.triage.dump_io = True
- def stale_brief(prompt, on_io=None, finalize=None):
- # Simulate a clear landing mid-LLM-call (after the request phase fired).
- service._triage_generation += 1
- if on_io is not None:
- on_io({"phase": "request", "url": "http://llm/v1", "body": {}})
- on_io({"phase": "response", "payload": {"c": 1}, "error": None})
- return _brief_reply("RAW")
- service._brief_fn = stale_brief
- service._pending_brief = ["Unknown: hello"]
- service._brief_outstanding = True
- token = service._brief_token
- ts = clock()
- service._triage_dump.begin(ts, laya={"request": {}, "response": {}, "error": None})
- service._run_brief_update(0, _escalated_payload(), ts, token)
- assert _dump_files(tmp_path) == []
- assert service._triage_dump._pending == {}
- assert service._pending_brief == []
- assert service._brief_outstanding is False
- def test_dump_gated_out_writes_laya_only_and_no_pending(tmp_path):
- """A turn the gate leaves out writes `llm: null` and leaks no pending record."""
- service, emitted, clock, triage, lane = _triage_service(
- triage=FakeTriage(escalate=True, gate=False), brief_fn=_dump_brief
- )
- service._triage_dump = TriageDumper(True, directory=str(tmp_path))
- service.cfg.triage.dump_io = True
- _run_triage_flow(service, emitted, clock, lane, _escalated_payload())
- assert [j.name for j in service._inference._queue] == ["chat"]
- assert len(triage.gate_calls) == 1
- files = _dump_files(tmp_path)
- assert len(files) == 1
- data = json.loads(files[0].read_text(encoding="utf-8"))
- assert data["laya"]["response"] == _escalated_payload()
- assert data["llm"] is None
- assert service._triage_dump._pending == {}
- def test_dump_coalesced_update_writes_laya_only_then_llm_only_flush(tmp_path):
- """A coalesced turn writes a Laya-only record; the later flush a separate llm-only one."""
- service, emitted, clock, _, lane = _triage_service(brief_fn=_dump_brief)
- service._triage_dump = TriageDumper(True, directory=str(tmp_path))
- service.cfg.triage.dump_io = True
- service.toggle_chat()
- service.handle_event(_transcript(clock, "first"))
- clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
- service.tick()
- _, _, _, gen0 = lane.submits[0]
- service._on_triage_result(gen0, _escalated_payload())
- service.handle_event(_transcript(clock, "second"))
- clock.advance(service.cfg.assistant.turn_gap_s + 0.1)
- service.tick()
- _, _, _, gen1 = lane.submits[1]
- service._on_triage_result(gen1, _escalated_payload())
- assert service._brief_outstanding is True
- appended: list[int] = []
- def _brief(prompt, on_io=None, finalize=None):
- if not appended:
- appended.append(1)
- service.handle_event(_transcript(clock, "during call"))
- if on_io is not None:
- on_io({"phase": "request", "url": "http://llm/v1", "body": {"prompt": prompt}})
- on_io({"phase": "response", "payload": {"content": "parsed"}, "error": None})
- return _brief_reply("BRIEF")
- service._brief_fn = _brief
- clock.advance(1.0)
- job = [j for j in service._inference._queue if j.name == "brief-update"][0]
- service._inference._queue.remove(job)
- job.run()
- flushed = [j for j in service._inference._queue if j.name == "brief-update"]
- assert len(flushed) == 1
- flushed[0].run()
- assert service._triage_dump._pending == {}
- records = [
- json.loads(path.read_text(encoding="utf-8")) for path in _dump_files(tmp_path)
- ]
- assert len(records) == 3
- coalesced = [r for r in records if r["laya"] is not None and r["llm"] is None]
- flushed_records = [r for r in records if r["laya"] is None and r["llm"] is not None]
- both = [r for r in records if r["laya"] is not None and r["llm"] is not None]
- assert len(coalesced) == 1
- assert len(flushed_records) == 1
- assert len(both) == 1
- assert coalesced[0]["ts"] != flushed_records[0]["ts"]
- assert flushed_records[0]["llm"]["request"]["body"] == {
- "prompt": "CURRENT LEDGER:\n(none yet)\n\nCURRENT BRIEF:\nBRIEF\n\n"
- "NEW UTTERANCES:\n- Unknown: during call"
- }
- def test_chat_client_failure_emits_llm_error_and_service_survives():
- """Adversarial (a): a chat client raising on `chat` surfaces as an `llm_error`
- event and the service keeps functioning afterwards."""
- from stt_daemon.assistant.llm import ConversationEngine, LlmError
- class BoomClient:
- def chat(self, messages, max_tokens=None, timeout_s=None, **kwargs):
- raise LlmError("boom")
- engine = ConversationEngine(Config().llm, BoomClient(), system_prompt="SYS")
- service, emitted, clock = _service()
- service.chat_fn = engine.send
- assert service.toggle_chat() is True
- service._run_chat("hello")
- errors = [e for e in emitted if e["type"] == "error" and e.get("code") == "llm_error"]
- assert errors and "boom" in errors[-1]["message"]
- assert service.toggle_chat() is True
- assert service.modes.mode.value == "idle"
- # ---------------------------------------------------------------------------
- # Conversation session adoption (SESSION/TRANSCRIPT session_dir).
- # ---------------------------------------------------------------------------
- def _session_event(clock, session_dir):
- event = _ev(events.SESSION, clock)
- event["session_id"] = session_dir.rsplit("/", 1)[-1]
- event["session_dir"] = session_dir
- return event
- def _ring(service, clock, *items):
- """Feed a daemon-seeded replay window: status -> items -> ring_end."""
- service.handle_event(_ev(events.STATUS, clock))
- for item in items:
- service.handle_event(item)
- service.handle_event(_ev(events.RING_END, clock))
- def _cleared(emitted):
- return [e for e in _triage_events(emitted) if e.get("stage") == "cleared"]
- def test_status_includes_session_dir_without_brief_file():
- service, _, clock = _service()
- assert service.status()["session_dir"] is None
- service.handle_event(_session_event(clock, "transcripts/2026-09-30-12-47-29"))
- assert service.status()["session_dir"] == "transcripts/2026-09-30-12-47-29"
- def test_live_session_event_sets_session_and_records_directory():
- brief_file = FakeBriefFile()
- service, _, clock, _, _ = _triage_service(brief_file=brief_file)
- session = "transcripts/2026-09-30-12-47-29"
- service.handle_event(_session_event(clock, session))
- assert service.status()["session_dir"] == session
- assert brief_file.directories == [session]
- assert service._triage_generation == 0
- def test_live_transcript_session_sets_session_without_wiping_utterance():
- brief_file = FakeBriefFile()
- service, _, clock, _, _ = _triage_service(brief_file=brief_file)
- session = "transcripts/s1"
- service.handle_event(_transcript(clock, "hello", session_dir=session))
- assert service.status()["session_dir"] == session
- assert brief_file.directories == [session]
- assert service.triage_history == ["Unknown: hello"]
- assert service._pending_brief == ["Unknown: hello"]
- assert service._triage_generation == 0
- def test_brief_write_lands_under_session_dir(tmp_path):
- from stt_daemon.assistant.brief_file import BriefFile
- brief_file = BriefFile(True)
- service, _, clock, _, _ = _triage_service(brief_file=brief_file)
- session = str(tmp_path / "transcripts" / "s1")
- service.handle_event(_transcript(clock, "hello", session_dir=session))
- brief_file.write("the brief")
- path = tmp_path / "transcripts" / "s1" / "brief.md"
- assert path.read_text(encoding="utf-8") == "the brief"
- def test_live_session_change_resets_triage_and_keeps_chat():
- brief_file = FakeBriefFile()
- resets: list[int] = []
- service, emitted, clock, _, lane = _triage_service(
- brief_file=brief_file, brief_reset=lambda: resets.append(1)
- )
- service.toggle_chat()
- service.set_chat_capture(True)
- service.handle_event(_transcript(clock, "hello"))
- service.handle_event(_session_event(clock, "transcripts/a"))
- service.last_triage = {"signals": 1}
- service._pending_brief = ["stale"]
- emitted.clear()
- service.handle_event(_session_event(clock, "transcripts/b"))
- assert service.status()["session_dir"] == "transcripts/b"
- assert service.last_triage is None
- assert service._pending_brief == []
- assert service._triage_generation == 1
- assert service.chat_history == ["Unknown: hello"]
- assert resets == [1]
- assert lane.drops == 1
- assert brief_file.directories == ["transcripts/a", "transcripts/b"]
- assert len(_cleared(emitted)) == 1
- def test_sessionless_transcript_does_not_reset():
- service, _, clock, _, _ = _triage_service()
- service.handle_event(_session_event(clock, "transcripts/a"))
- service.last_triage = {"signals": 1}
- service.handle_event(_transcript(clock, "hello"))
- assert service._triage_generation == 0
- assert service.last_triage == {"signals": 1}
- assert service.status()["session_dir"] == "transcripts/a"
- def test_same_dir_readoption_does_not_reset():
- brief_file = FakeBriefFile()
- service, _, clock, _, _ = _triage_service(brief_file=brief_file)
- session = "transcripts/a"
- service.handle_event(_session_event(clock, session))
- service.last_triage = {"signals": 1}
- service.handle_event(_transcript(clock, "again", session_dir=session))
- assert service._triage_generation == 0
- assert service.last_triage == {"signals": 1}
- assert brief_file.directories == [session]
- def test_session_change_without_brief_file_does_not_raise():
- service, _, clock, _, _ = _triage_service(brief_file=None)
- service.handle_event(_session_event(clock, "transcripts/a"))
- service.handle_event(_session_event(clock, "transcripts/b"))
- assert service.status()["session_dir"] == "transcripts/b"
- assert service._triage_generation == 1
- def test_replay_single_session_adopts_without_reset():
- brief_file = FakeBriefFile()
- service, emitted, clock, _, _ = _triage_service(brief_file=brief_file)
- session = "transcripts/a"
- _ring(service, clock, _transcript(clock, "hello", session_dir=session))
- assert service.status()["session_dir"] == session
- assert brief_file.directories == [session]
- assert service._triage_generation == 0
- assert _cleared(emitted) == []
- assert service.triage_history == ["Unknown: hello"]
- def test_replay_two_sessions_commits_newest_and_resets_once():
- brief_file = FakeBriefFile()
- service, emitted, clock, _, _ = _triage_service(brief_file=brief_file)
- a, b = "transcripts/a", "transcripts/b"
- _ring(
- service,
- clock,
- _session_event(clock, a),
- _transcript(clock, "old turn", session_dir=a),
- _session_event(clock, b),
- _transcript(clock, "new turn", session_dir=b),
- )
- assert service.status()["session_dir"] == b
- assert brief_file.directories == [b]
- assert service._triage_generation == 1
- assert service.last_triage is None
- assert service._pending_brief == []
- assert len(_cleared(emitted)) == 1
- def test_reconnect_tailing_current_session_is_noop():
- brief_file = FakeBriefFile()
- service, emitted, clock, _, _ = _triage_service(brief_file=brief_file)
- session = "transcripts/a"
- service.handle_event(_session_event(clock, session))
- service.last_triage = {"signals": 1}
- emitted.clear()
- _ring(service, clock, _transcript(clock, "replayed", session_dir=session))
- assert service.status()["session_dir"] == session
- assert brief_file.directories == [session]
- assert service._triage_generation == 0
- assert service.last_triage == {"signals": 1}
- assert _cleared(emitted) == []
- def test_reconnect_older_to_current_resets_once_without_rewind():
- brief_file = FakeBriefFile()
- service, emitted, clock, _, _ = _triage_service(brief_file=brief_file)
- a, b = "transcripts/a", "transcripts/b"
- service.handle_event(_session_event(clock, a))
- service.last_triage = {"signals": 1}
- emitted.clear()
- _ring(
- service,
- clock,
- _session_event(clock, a),
- _transcript(clock, "old", session_dir=a),
- _session_event(clock, b),
- _transcript(clock, "new", session_dir=b),
- )
- assert service.status()["session_dir"] == b
- assert brief_file.directories == [a, b]
- assert service._triage_generation == 1
- assert service.last_triage is None
- assert len(_cleared(emitted)) == 1
- def test_reconnect_only_newer_session_resets_once():
- brief_file = FakeBriefFile()
- service, _, clock, _, _ = _triage_service(brief_file=brief_file)
- a, b = "transcripts/a", "transcripts/b"
- service.handle_event(_session_event(clock, a))
- service.last_triage = {"signals": 1}
- _ring(service, clock, _transcript(clock, "new", session_dir=b))
- assert service.status()["session_dir"] == b
- assert service._triage_generation == 1
- assert service.last_triage is None
- assert brief_file.directories == [a, b]
- def test_reconnect_span_older_current_clears_buffered_older_turns():
- """A RING_END whose ring spanned an older session resets even when the
- newest session already matches the adopted directory (no re-set_directory)."""
- brief_file = FakeBriefFile()
- service, emitted, clock, _, _ = _triage_service(brief_file=brief_file)
- a, b = "transcripts/a", "transcripts/b"
- _ring(service, clock, _session_event(clock, a))
- assert service._triage_generation == 0
- service.handle_event(_transcript(clock, "old turn", session_dir=a))
- assert service._pending_brief == ["Unknown: old turn"]
- service.handle_event(_session_event(clock, b))
- assert service._triage_generation == 1
- service.handle_event(_transcript(clock, "new turn", session_dir=b))
- assert service._pending_brief == ["Unknown: new turn"]
- emitted.clear()
- _ring(
- service,
- clock,
- _session_event(clock, a),
- _transcript(clock, "old turn", session_dir=a),
- _session_event(clock, b),
- _transcript(clock, "new turn", session_dir=b),
- )
- assert service.status()["session_dir"] == b
- assert brief_file.directories == [a, b]
- assert service._pending_brief == []
- assert service._triage_generation == 2
- assert len(_cleared(emitted)) == 1
- def test_daemon_restart_new_session_resets_once():
- brief_file = FakeBriefFile()
- service, _, clock, _, _ = _triage_service(brief_file=brief_file)
- service.handle_event(_session_event(clock, "transcripts/a"))
- service.last_triage = {"signals": 1}
- service.handle_event(_session_event(clock, "transcripts/b"))
- assert service.status()["session_dir"] == "transcripts/b"
- assert service._triage_generation == 1
- assert service.last_triage is None
- assert brief_file.directories == ["transcripts/a", "transcripts/b"]
- def _dwell_service(confirm):
- service, emitted, clock, _, lane = _triage_service(
- triage=FakeTriage(questions={"blocker": {"type": "noul", "instructions": "x"}})
- )
- service.cfg.triage.confirm_windows = confirm
- return service, emitted, clock, lane
- def _blocker_payload(p):
- return {
- "order": ["blocker"],
- "items": {
- "blocker": {
- "kind": "noul",
- "p": p,
- "threshold": 0.5,
- "flagged": p >= 0.5,
- }
- },
- "escalated": p >= 0.5,
- "input_tokens": 0,
- }
- def test_dwell_holds_a_single_window_spike_back():
- service, emitted, _, _ = _dwell_service(2)
- service._on_triage_result(0, _blocker_payload(0.95))
- assert service.last_triage["items"]["blocker"]["flagged"] is False
- service._on_triage_result(0, _blocker_payload(0.95))
- assert service.last_triage["items"]["blocker"]["flagged"] is True
- def test_dwell_resets_when_the_signal_drops():
- service, _, _, _ = _dwell_service(2)
- service._on_triage_result(0, _blocker_payload(0.95))
- service._on_triage_result(0, _blocker_payload(0.10))
- service._on_triage_result(0, _blocker_payload(0.95))
- assert service.last_triage["items"]["blocker"]["flagged"] is False
- service._on_triage_result(0, _blocker_payload(0.95))
- assert service.last_triage["items"]["blocker"]["flagged"] is True
- def test_dwell_disabled_with_one_confirm_window():
- service, _, _, _ = _dwell_service(1)
- service._on_triage_result(0, _blocker_payload(0.95))
- assert service.last_triage["items"]["blocker"]["flagged"] is True
- def test_clear_resets_dwell_streaks():
- service, _, _, _ = _dwell_service(2)
- service._on_triage_result(0, _blocker_payload(0.95))
- assert service._signal_streaks["blocker"] == 1
- service.clear()
- assert service._signal_streaks == {}
|